Revert "Remove underscores from test names to follow GTest convention…

…s //media." #2 This reverts commit dd89c95. Reason: https://groups.google.com/a/chromium.org/g/chromium-dev/c/KxzyXKv7adQ Based on the discussion here, I have decided to terminate this work. This CL was uploaded by git cl split. [email protected] Bug: 377144451 Change-Id: I6718ca868173be505d6d180dc1760a706eac65cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6065105 Commit-Queue: Ho Cheung <[email protected]> Reviewed-by: Nasko Oskov <[email protected]> Reviewed-by: Colin Blundell <[email protected]> Cr-Commit-Position: refs/heads/main@{#1391390}
jamlee-t · Dec 4, 2024 · 97f19cb · 97f19cb
1 parent 792c88e
commit 97f19cb
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/media/mojo/mojom/video_decoder_config_mojom_traits_unittest.cc b/media/mojo/mojom/video_decoder_config_mojom_traits_unittest.cc
@@ -25,7 +25,7 @@ static const gfx::Size kNaturalSize(320, 240);
 
 }  // namespace
 
-TEST(VideoDecoderConfigStructTraitsTest, ConvertVideoDecoderConfigNormal) {
+TEST(VideoDecoderConfigStructTraitsTest, ConvertVideoDecoderConfig_Normal) {
   const uint8_t kExtraData[] = "config extra data";
   const std::vector<uint8_t> kExtraDataVector(
       &kExtraData[0], &kExtraData[0] + std::size(kExtraData));
@@ -57,7 +57,7 @@ TEST(VideoDecoderConfigStructTraitsTest,
   EXPECT_TRUE(output.Matches(input));
 }
 
-TEST(VideoDecoderConfigStructTraitsTest, ConvertVideoDecoderConfigEncrypted) {
+TEST(VideoDecoderConfigStructTraitsTest, ConvertVideoDecoderConfig_Encrypted) {
   VideoDecoderConfig input(VideoCodec::kVP8, VP8PROFILE_ANY,
                            VideoDecoderConfig::AlphaMode::kIsOpaque,
                            VideoColorSpace(), kNoTransformation, kCodedSize,

diff --git a/media/mojo/mojom/video_encode_accelerator_mojom_traits_unittest.cc b/media/mojo/mojom/video_encode_accelerator_mojom_traits_unittest.cc
@@ -70,7 +70,7 @@ TEST(VideoEncoderInfoStructTraitTest, RoundTrip) {
   EXPECT_EQ(input, output);
 }
 
-TEST(VideoBitrateAllocationStructTraitTest, ConstantBitrateRoundTrip) {
+TEST(VideoBitrateAllocationStructTraitTest, ConstantBitrate_RoundTrip) {
   ::media::VideoBitrateAllocation input_allocation;
   ASSERT_TRUE(input_allocation.SetBitrate(0, 0, 1000u));
   ASSERT_TRUE(input_allocation.SetBitrate(1, 0, 3500u));
@@ -213,7 +213,7 @@ TEST(VideoEncodeAcceleratorConfigStructTraitTest, RoundTripVariableBitrate) {
   EXPECT_EQ(input_config, output_config);
 }
 
-TEST(VariableBitrateStructTraitTest, PeakZeroBpsRejected) {
+TEST(VariableBitrateStructTraitTest, PeakZeroBps_Rejected) {
   mojom::VariableBitratePtr mojom_variable_bitrate =
       mojom::VariableBitrate::New();
   mojom_variable_bitrate->target_bps = 0u;
@@ -225,7 +225,7 @@ TEST(VariableBitrateStructTraitTest, PeakZeroBpsRejected) {
   EXPECT_FALSE(result);
 }
 
-TEST(VariableBitrateStructTraitTest, PeakLessThanTargetRejected) {
+TEST(VariableBitrateStructTraitTest, PeakLessThanTarget_Rejected) {
   mojom::VariableBitratePtr mojom_variable_bitrate =
       mojom::VariableBitrate::New();
   mojom_variable_bitrate->target_bps = 6000u;