[pull] master from chromium:master #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
https://skia.googlesource.com/skia.git/+log/d8c2750cf607..d9bf97c5e249 2021-04-20 [email protected] Roll Chromium from 3e8dec5 to f2c9d79 (436 revisions) 2021-04-20 [email protected] Roll ANGLE from b027dfeb83d0 to b574643ef28c (7 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: [email protected] Change-Id: Ib832971db26b08fe9d5000f1626057e17cab720b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2839491 Commit-Queue: chromium-autoroll <[email protected]> Bot-Commit: chromium-autoroll <[email protected]> Cr-Commit-Position: refs/heads/master@{#874164}
Add base of MultiWordSuggester to the assistive framework. Also add a new method to the Suggester interface, allowing us to inject and display suggestions generated outside of the framework. BUG=1146266 Change-Id: I11db0a229fc65d13d96d7b719237036c20ad160f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2838239 Commit-Queue: Curtis McMullan <[email protected]> Reviewed-by: Jing Wang <[email protected]> Reviewed-by: Darren Shen <[email protected]> Cr-Commit-Position: refs/heads/master@{#874165}
Just confirming what spec says in this one. Change-Id: I18ad4a726330dc3be58b08ce25aa36c2f9e171ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2836871 Commit-Queue: Aleks Totic <[email protected]> Reviewed-by: David Grogan <[email protected]> Cr-Commit-Position: refs/heads/master@{#874166}
SWAs should be launched with LaunchSystemWebAppAsync. This CL migrates the it from using AppService::Launch. The new launch logic ignores event_flags, which has no effect on SWA. Bug: 1198427 Change-Id: I856764de752141a3fb55fdf54b43f00842cfcb7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2839584 Commit-Queue: Jiewei Qian <[email protected]> Commit-Queue: calamity <[email protected]> Auto-Submit: Jiewei Qian <[email protected]> Reviewed-by: calamity <[email protected]> Cr-Commit-Position: refs/heads/master@{#874167}
https://webrtc.googlesource.com/src.git/+log/0d3c09a8fe5f..dcac9fe3d164 2021-04-19 [email protected] Add may_contain_cursor property to DesktopFrame to avoid double capture 2021-04-19 [email protected] Exclude WS_EX_TOOLWINDOWs for WgcCapturerWin. 2021-04-19 [email protected] Remove DataChannelType and deprecated option disable_sctp_data_channels 2021-04-19 [email protected] Handle OnPacketSent on the network thread via MediaChannel. 2021-04-19 [email protected] Refactors Vp9UncompressedHeaderParser. 2021-04-19 [email protected] Fix unsafe variable access in RTCStatsCollector 2021-04-19 [email protected] Ban std::shared_ptr in style guide 2021-04-19 [email protected] Add support for setting the initial state to the pending task flag. 2021-04-19 [email protected] Add thread accessors to Call. 2021-04-19 [email protected] Fix an example in SequenceChecker documentation 2021-04-19 [email protected] Update last received keyframe packet timestamp on all packets with the same RTP timestamp. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: [email protected] Change-Id: If32821d3df2623f8c36a038955ec4f2b30e8fe8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2839523 Commit-Queue: chromium-autoroll <[email protected]> Bot-Commit: chromium-autoroll <[email protected]> Cr-Commit-Position: refs/heads/master@{#874168}
This reverts commit 7874d93. Reason for revert: Causing flakes on linux E.g. https://ci.chromium.org/p/chromium/builders/ci/Linux%20Tests/99620 Original change's description: > Enable AXTreeSerializer to support partial serialization. > > Previously AXTreeSerializer already supported the idea of > stopping after a certain amount of time or a certain > number of nodes had been serialized, but it was only > intended to be used for a one-time tree snapshot. > > This change enables AXTreeSerializer to return the > list of incomplete nodes, so that you can follow up and > finish serializing the tree. > > This is a useful building block in reducing accessibility > jankiness. > > Bug: 1200437 > AX-Relnotes: N/A > Change-Id: I6857fe1957418ddbd47fa75c3409e2ac12117e62 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2832493 > Commit-Queue: Dominic Mazzoni <[email protected]> > Reviewed-by: Aaron Leventhal <[email protected]> > Cr-Commit-Position: refs/heads/master@{#874090} Bug: 1200437 Change-Id: I92d71c2ea034c3eec385f99e181c3f9e6a78899a No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2839783 Bot-Commit: Rubber Stamper <[email protected]> Owners-Override: Fergal Daly <[email protected]> Commit-Queue: Fergal Daly <[email protected]> Cr-Commit-Position: refs/heads/master@{#874169}
There was a TODO in autofill code to replace the current tunneling of profile type from /chrome with getting it directly from BrowserContext. The TODO is removed and one use case is updated. But the other use case cannot be updated since it is in AutofillManager where there is no reference to BrowserContext and having BrowserContext there requires a similar amount of tunneling. NOTE: This CL does not change any behavior. Bug: 1169142 Change-Id: Ic21da4206b04f1a3fdfb86376c013d6aff21f817 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2827930 Reviewed-by: Evan Stade <[email protected]> Commit-Queue: Ramin Halavati <[email protected]> Cr-Commit-Position: refs/heads/master@{#874170}
No real change to behaviour, we pull sshfs mounting logic out of CrostiniRestarter and put it into its own class. The code in CrostiniSshfsHelper is copy/pasted with the following exceptions: * Removed references to Restarter specific behaviour e.g. checking for abort * A different approach to queue multiple requests instead of relying on CrostiniManager. * Allow VolumeManager to be set and called in tests * Use a ScopedObservation instead of a regular observer Bug: 1142321 Test: Unit tests, CQ, deploy and start Crostini Change-Id: Idb5bc7521b27ddd38fd8ac7de9b40f423c56891e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2830056 Reviewed-by: Nicholas Verne <[email protected]> Reviewed-by: Joel Hockey <[email protected]> Commit-Queue: David Munro <[email protected]> Cr-Commit-Position: refs/heads/master@{#874171}
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/ebb3e438e158..abcf296bb00d 2021-04-20 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC [email protected] on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: [email protected] Change-Id: I4f9d868cc17d246d909a20f45e6c4d6366def756 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2837210 Commit-Queue: chromium-autoroll <[email protected]> Bot-Commit: chromium-autoroll <[email protected]> Cr-Commit-Position: refs/heads/master@{#874172}
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: [email protected] Disable-Retries: true Change-Id: If2093b86ccefa8e90675308ae19c63293b129113 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2839489 Commit-Queue: chromium-autoroll <[email protected]> Bot-Commit: chromium-autoroll <[email protected]> Cr-Commit-Position: refs/heads/master@{#874173}
There are a couple of quirks that only FF implements. I propose modifying the spec, and depreciating the quirks. Change-Id: Id73a73e152b7f1557a236e4f3c7393fed52f4927 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2836834 Commit-Queue: Aleks Totic <[email protected]> Reviewed-by: David Grogan <[email protected]> Cr-Commit-Position: refs/heads/master@{#874174}
On Windows, both Ctrl+a and Alt+a perform "select all" in the PDF Viewer, when only Ctrl+a should work. On Mac, both Ctrl+a and Command+a perform "select all", when only Command+a should work. Fix this issue in pdf_viewer.js by adding hasCtrlModifier() to pdf_viewer_utils.js, which selects the appropriate modifier based on the platform. Then use hasCtrlModifier() to handle "select all" commands. The code for hasCtrlModifier() comes from existing code in pdf_viewer.js that correctly handles other shortcut keys. Then audit other keyboard modifier checks and note why some should not use hasCtrlModifier(), or add a TODO in an undecided case. Also use hasCtrlModifier() in pdf_viewer_pp.js for the same reason. Change-Id: Ib6c725b7445794b9aee195812eb846ec87386c03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2830700 Commit-Queue: Lei Zhang <[email protected]> Reviewed-by: dpapad <[email protected]> Cr-Commit-Position: refs/heads/master@{#874175}
Added ownership of the following to [email protected] - c/a/settings_strings_grdp/* - c/a/settings_strings.grdp - c/b/ui/webui/settings/settings_localized_strings_provider* Change-Id: I0907629f0c46d0c198466d469277926969ef09b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2834094 Reviewed-by: dpapad <[email protected]> Reviewed-by: Esmael Elmoslimany <[email protected]> Reviewed-by: Greg Thompson <[email protected]> Commit-Queue: Theodore Olsauskas-Warren <[email protected]> Cr-Commit-Position: refs/heads/master@{#874176}
Change-Id: I3004805661bd31b7b26984b1b89636da4f5dc45e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2834117 Reviewed-by: Brian Malcolm <[email protected]> Reviewed-by: Alexander Hendrich <[email protected]> Commit-Queue: Jit Yao Yap <[email protected]> Cr-Commit-Position: refs/heads/master@{#874177}
crrev.com/c/2805110 broke the build No-try: true Bug: 1056170 Change-Id: I8e37e11a906bd07b31351fc144b433cfa9ab3a38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2837833 Auto-Submit: Omer Katz <[email protected]> Reviewed-by: Tal Pressman <[email protected]> Reviewed-by: Kentaro Hara <[email protected]> Commit-Queue: Tal Pressman <[email protected]> Commit-Queue: Kentaro Hara <[email protected]> Cr-Commit-Position: refs/heads/master@{#874178}
times out Bug: 1200264 Change-Id: I0a64e7aac7482605af0459137ab75ed6ec3870e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2835866 Reviewed-by: Katie Dektar <[email protected]> Commit-Queue: Olga Sharonova <[email protected]> Cr-Commit-Position: refs/heads/master@{#874179}
Bug: 1199282,1200233 Change-Id: I860e24884ed083fcde4426f6b1a606e2a311c531 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2825940 Reviewed-by: Arthur Sonzogni <[email protected]> Commit-Queue: Yifan Luo <[email protected]> Cr-Commit-Position: refs/heads/master@{#874180}
Change-Id: I5af9d0bb785474c29528f69907f09cfd9f7f4e2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2839346 Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#874181}
Bug: 1196576 Change-Id: Ia18fab1e7745deed78acc105b38d900cb67e750f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2838970 Commit-Queue: Kent Tamura <[email protected]> Reviewed-by: Yoshifumi Inoue <[email protected]> Reviewed-by: Koji Ishii <[email protected]> Cr-Commit-Position: refs/heads/master@{#874182}
Bug: 1164280,1170277 Change-Id: I096a3002e2fa04683a63d651bcaec0d4c00c2c50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2831634 Auto-Submit: Carlos Caballero <[email protected]> Reviewed-by: Matt Falkenhagen <[email protected]> Reviewed-by: Reilly Grant <[email protected]> Commit-Queue: Sreeja Kamishetty <[email protected]> Cr-Commit-Position: refs/heads/master@{#874183}
…erDialogTest This cl replaces MockitoAnnotations.initMocks() with MockitoJUnit.rule().strictness(Strictness.STRICT_STUBS) in AccountPickerDialogTest Bug: 1186674 Change-Id: Ie495e98ec0853f53a89a515738f9e1c4f1ad4eb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2821517 Reviewed-by: Alice Wang <[email protected]> Commit-Queue: Tanmoy Mollik <[email protected]> Cr-Commit-Position: refs/heads/master@{#874184}
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/androidx-chromium Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: [email protected],[email protected] Change-Id: Ic7707d574bf3bbfab25c64901b141da80d60328e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2839496 Commit-Queue: chromium-autoroll <[email protected]> Bot-Commit: chromium-autoroll <[email protected]> Cr-Commit-Position: refs/heads/master@{#874185}
base::StringTokenizer::token() creates a new std::string each time. Many callers do not even need a std::string, so just update them to use token_piece() instead. This CL was uploaded by git cl split. [email protected] Bug: 1199547 Change-Id: I91f81f2faac773fc8c44fb3043363234f65fe6a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2833272 Auto-Submit: Daniel Cheng <[email protected]> Reviewed-by: Will Cassella <[email protected]> Commit-Queue: Daniel Cheng <[email protected]> Cr-Commit-Position: refs/heads/master@{#874186}
This reverts commit 9837459. Reason for revert: The ChromiumOS tast-test [1] that was blocking this string change in Chromium was made informational in [2]. However, it seems that this change failed to roll into Chromium [3]. The tast-test has now been disabled for Chromium altogether [3], which is why the string should now be able to land in Chromium. [1] https://source.chromium.org/chromiumos/chromiumos/codesearch/+/main:src/platform/tast-tests/src/chromiumos/tast/local/bundles/cros/policy/allow_deleting_browser_history.go;l=97?q=%22Clears%20history%20and%20autocompletions%20in%20the%20address%20bar.%22 [2] crrev.com/c/2825430 [3] crrev.com/c/2831081 Original change's description: > Revert "[Search history link]: Update CBD dialog string to 'search box'" > > This reverts commit b78b22a. > > Reason for revert: Causes policy.AllowDeletingBrowserHistory to fail consistently. See https://ci.chromium.org/ui/p/chromium/builders/ci/chromeos-amd64-generic-rel/52257/overview > > Original change's description: > > [Search history link]: Update CBD dialog string to 'search box' > > > > Update the CBD dialog string from 'address bar' to 'search box' after > > corresponding UXW feedback. > > > > Bug: 1192623 > > Change-Id: Ifb6e624d5a6f71bebd319982f4ad969a56671e11 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2821308 > > Commit-Queue: Rainhard Findling <[email protected]> > > Commit-Queue: Esmael Elmoslimany <[email protected]> > > Reviewed-by: Rainhard Findling <[email protected]> > > Reviewed-by: Esmael Elmoslimany <[email protected]> > > Auto-Submit: Rainhard Findling <[email protected]> > > Cr-Commit-Position: refs/heads/master@{#873371} > > Bug: 1192623 > Change-Id: Iff3015cafc5137b7a4e43d637c82ca9dd2320ead > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2830127 > Bot-Commit: Rubber Stamper <[email protected]> > Reviewed-by: Chris Mumford <[email protected]> > Reviewed-by: Esmael Elmoslimany <[email protected]> > Commit-Queue: Chris Mumford <[email protected]> > Cr-Commit-Position: refs/heads/master@{#873548} Bug: 1192623 Change-Id: Id164526704f9d55f9fd11ffacfaae7ab4f6fce16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2835747 Bot-Commit: Rubber Stamper <[email protected]> Reviewed-by: Rainhard Findling <[email protected]> Reviewed-by: Esmael Elmoslimany <[email protected]> Commit-Queue: Rainhard Findling <[email protected]> Cr-Commit-Position: refs/heads/master@{#874187}
After r851021 we started to use :focus-visible instead of :focus in the default UA stylesheet. Other UA stylesheets were modified, and in the case of date/time pickers that caused a bug when the user clicks on a number it didn't get highlighted. This patch fixes the issue by coming back to :focus in renderer/core/html/resources/input_multiple_fields.css. We add a new test to avoid similar regressions in the future. BUG=1199352 TEST=web_tests/fast/forms/time/time-picker-click.html Change-Id: Ide43d343724eb136da288152657ef091bd6fabf4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2835774 Commit-Queue: Manuel Rego <[email protected]> Reviewed-by: Mason Freed <[email protected]> Cr-Commit-Position: refs/heads/master@{#874188}
Inline call to LoginDisplayHost instead Bug: 1100910 Change-Id: Id71b494c868f62f141f56ecf75f8256d08db62a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2837832 Auto-Submit: Roman Sorokin [CET] <[email protected]> Reviewed-by: Denis Kuznetsov [CET] <[email protected]> Commit-Queue: Roman Sorokin [CET] <[email protected]> Cr-Commit-Position: refs/heads/master@{#874189}
This CL has no behavior changes. Change-Id: I2949828933ba7eff4a7289bb35efafd7e8f95e23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2839244 Auto-Submit: Kent Tamura <[email protected]> Commit-Queue: Yoshifumi Inoue <[email protected]> Reviewed-by: Yoshifumi Inoue <[email protected]> Cr-Commit-Position: refs/heads/master@{#874190}
Add CRAS_METRICS_DEVICE_BLUETOOTH_WB_MIC and CRAS_METRICS_DEVICE_ALSA_LOOPBACK. BUG=b:185453191 Change-Id: I2bc9482610a65e96f678c9eeb80f8fc9f8b18a64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2827565 Reviewed-by: Hsinyu Chao <[email protected]> Commit-Queue: Yu-Hsuan Hsu <[email protected]> Cr-Commit-Position: refs/heads/master@{#874191}
…er.cc" This reverts commit 05263b5. Reason for revert: AXAuraObjCacheTest.ValidTree is failing on linux-lacros-tester-rel First failure https://ci.chromium.org/ui/p/chromium/builders/ci/linux-lacros-tester-rel/9021/overview Original change's description: > Adopt DesktopWindowTreeHostLinux::From in ax_window_obj_wrapper.cc > > This helper encapsulates the explicit static_cast, performing > some sanity checks. > > Follow up of https://crrev.com/c/871606. > > BUG=NONE > R=[email protected] > > Change-Id: Idaa19bf2c9fa0082ab30a127c62f16f3b4d0257b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2837785 > Auto-Submit: Antonio Gomes <[email protected]> > Commit-Queue: Scott Violet <[email protected]> > Reviewed-by: Scott Violet <[email protected]> > Cr-Commit-Position: refs/heads/master@{#873993} Bug: NONE Change-Id: Ifb956edbfb3cdfbf5474f823ee65808b91c11124 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2839605 Auto-Submit: Christos Froussios <[email protected]> Bot-Commit: Rubber Stamper <[email protected]> Commit-Queue: Christos Froussios <[email protected]> Owners-Override: Christos Froussios <[email protected]> Cr-Commit-Position: refs/heads/master@{#874192}
…l CI + try bot."" This reverts commit 583f98f. Reason for revert: gn gen check fails All runs of this bot have failed. https://ci.chromium.org/p/chromium/builders/ci/linux-no-base-tracing-rel?limit=200 Original change's description: > Reland "Add src-side configs for new linux-no-base-tracing-rel CI + try bot." > > This is a reland of 89857a8 > Changes are: > * Errors from "gn check" is fixed by crrev.com/c/2831543. > * additional_compile_targets is updated to "base_unittests", > according to crbug.com/1183347#c12 > > Original change's description: > > Add src-side configs for new linux-no-base-tracing-rel CI + try bot. > > > > They are linux rel builders with the gn arg enable_base_tracing=false > > > > Bug: 1183347 > > Change-Id: I38621059c6dd5c32d018d2393037720572749c30 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2822317 > > Reviewed-by: Stephen Martinis <[email protected]> > > Commit-Queue: Haiyang Pan <[email protected]> > > Cr-Commit-Position: refs/heads/master@{#872226} > > Bug: 1183347 > Change-Id: I38e2f3f1a0a268ae91559b8ad8487ba27112c03a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2832118 > Reviewed-by: Stephen Martinis <[email protected]> > Commit-Queue: Haiyang Pan <[email protected]> > Cr-Commit-Position: refs/heads/master@{#873929} Bug: 1183347 Change-Id: I551c299ef44cb30805de69c5f0f3c7f72314b5c6 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2837806 Auto-Submit: Fergal Daly <[email protected]> Bot-Commit: Rubber Stamper <[email protected]> Reviewed-by: Rakina Zata Amni <[email protected]> Commit-Queue: Fergal Daly <[email protected]> Owners-Override: Fergal Daly <[email protected]> Cr-Commit-Position: refs/heads/master@{#874193}
pull bot
pushed a commit
that referenced
this pull request
Oct 19, 2024
This CL has 2 purposes: 1) Fixes the over-painting described in the bug (see comment #2). This removes the FillLayout and custom View::Layout() override that LockContentsView was using. It replaces it with a single LayoutManager, and in doing so, removes the transient bounds that were being propagated in every layout (described in the bug), thereby removing all of its negative effects, including the indefinite loop of layouts caused by LoginExpandedPublicAccountView. 2) Clean up. The latest guidelines from the views team are to not override View::Layout() and use a LayoutManager instead. It also discourages use of DeprecatedLayoutImmediately(), which was being used in a number of spots. There is more clean-up to do in LockContentsView, but all of this cannot be fixed in a single CL. This is just a step in the right direction. every possibility side by side with a device that doesn't have this CL. Also tested all density layouts (varying the number of users). Bug: b:371322460 Test: On device, used the --show-login-dev-overlay flag and tested Change-Id: Ic371578b76a03d50952091df3c998a130d28a45c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5926181 Commit-Queue: Eric Sum <[email protected]> Reviewed-by: Denis Kuznetsov <[email protected]> Cr-Commit-Position: refs/heads/main@{#1370172}
pull bot
pushed a commit
that referenced
this pull request
Oct 19, 2024
This code has a long comment about things that are no longer true and from crash numbers this hang is still the #2 GPU crash. So simplify the code to avoid this complexity in prep for exploring other fixes for this issue. R=liberato, vikassoni Bug: 40819692, 374123602 Change-Id: Ic1d3f0465cee42ffdc0de90d2e83269c46dd736a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5939116 Reviewed-by: Frank Liberato <[email protected]> Auto-Submit: Dale Curtis <[email protected]> Reviewed-by: vikas soni <[email protected]> Commit-Queue: Frank Liberato <[email protected]> Cr-Commit-Position: refs/heads/main@{#1370334}
pull bot
pushed a commit
that referenced
this pull request
Oct 26, 2024
See https://drafts.csswg.org/css-pseudo-4/#first-text-line 1. For a block container that establishes an inline formatting context, the "first formatted line" is its first line box, if it has one. Otherwise, there is no first formatted line. 2. Otherwise, for a block container that has block children, look inside the first in-flow block child (if any) and do #1 if it establishes an inline formatting context. Otherwise, do #2. In short, we don't need to search for line boxes in blocks after the first block child. If there is no line in the first child, there's no "first formatted line". There's no spec for "last formatted line", but apply the same logic. I.e. if the last block child has no line, there's no "last formatted line". This allows us to simplify things a bit, especially when it comes to re-laying out (kTextBoxTrimEndDidNotApply). The only case where we need this now is for blocks inside inlines: If the last formatted line is inside a block-in-inline, we need to go back and re-lay it out if it turns out to be the last line (which isn't something we can check inside block-in-inline layout). Note: When adding support for block fragmentation, trimming at a fragmentainer's block end will be another case where we need to re-lay out. The motivation for this change was text box trimming inside block fragmentation (upcoming CL), and be able to add support for that and still be reasonably confident that it won't become too complicated. This fixes one existing test. Some other existing tests had to be updated because of this change (they were making incorrect assumptions about first/last formatted line). As a result of that, some new refs had to be added, since other tests were piggy-backing on the same ref. Bug: 40254880, 367766472 Change-Id: I3fcc53af86353725b1f5705a5528493a72bf2e69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5952979 Commit-Queue: Morten Stenshorne <[email protected]> Reviewed-by: Koji Ishii <[email protected]> Cr-Commit-Position: refs/heads/main@{#1373765}
pull bot
pushed a commit
that referenced
this pull request
Oct 26, 2024
This reverts commit ecb74d5. Reason for revert: A series of bots such as "Linux Tests (dbg)(1)", "Linux ASan LSan Tests (1)" started failing consistently in browser_tests for these two tests: PreviewBrowserTest.ErrorOnNonHttpsUrl PreviewBrowserTest.ErrorOnRedirectionToNonHttpsUrl after this change was submitted. More complete bot list is below [1]. Both of those tests are both prerender-related. This is the only prerender-related change on the blamelist. The former somtimes fails with vector.h(1305): Check failed: i < size() (0 vs. 0) See full stack trace below [2]. The latter sometimes fails with preview_manager.cc(73): Check failed: tab_. See full stack trace below [3]. I have also seen the former fail with the "Check failed: tab_." error message. And on some bots I have also seen a full-blown crash (unexpected abort). Also, on some both I have seen other PreviewBrowserTest failures at this time, such as PreviewBrowserTest.MojoCapabilityControl, with similar errors. [1] bots that fail: https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20ASan%20LSan%20Tests%20(1)/128871/blamelist https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20(1)/61153/blamelist https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests/47171/blamelist https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20MSan%20Tests/51450/blamelist https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20Tests%20(dbg)(1)/122977/blamelist https://ci.chromium.org/ui/p/chromium/builders/ci/linux-chromeos-dbg/37765/blamelist [2] PreviewBrowserTest.ErrorOnNonHttpsUrl [ RUN ] PreviewBrowserTest.ErrorOnNonHttpsUrl [292860:292860:1025/041435.600171:WARNING:field_trial_util.cc(106)] Field trial config study skipped: LinkPreview.EnabledAltClick (some of its features are already overridden) [292860:292860:1025/041435.613074:WARNING:field_trial_util.cc(106)] Field trial config study skipped: PreconnectToSearchDesktop.EnabledWithStartupDelayForegroundOnly (some of its features are already overridden) [292947:292947:1025/041436.521543:WARNING:gpu_memory_buffer_support_x11.cc(49)] dri3 extension not supported. [292947:292947:1025/041436.577861:WARNING:sandbox_linux.cc(430)] InitializeSandbox() called with multiple threads in process gpu-process. [292947:292947:1025/041436.602554:WARNING:viz_main_impl.cc(85)] VizNullHypothesis is disabled (not a warning) [292948:292979:1025/041438.220989:WARNING:simple_synchronous_entry.cc(1449)] Could not open platform files for entry. [292860:292860:1025/041439.058422:WARNING:idle_linux.cc(110)] None of the known D-Bus ScreenSaver services could be used. [292860:293018:1025/041439.668033:WARNING:embedded_test_server.cc(757)] Request not handled. Returning 404: /favicon.ico [293019:293019:1025/041440.636001:ERROR:html_media_element.cc(4927)] SetError: {code=4, message="MEDIA_ELEMENT_ERROR: Media load rejected by URL safety check"} [293019:293019:1025/041440.796426:FATAL:vector.h(1305)] Check failed: i < size() (0 vs. 0) #0 0x63a93d38d586 in ___interceptor_backtrace /b/s/w/ir/cache/builder/src/third_party/llvm/compiler-rt/lib/asan/../sanitizer_common/sanitizer_common_interceptors.inc:4441:13 #1 0x63a95f5dc688 in base::debug::CollectStackTrace(base::span<void const*, 18446744073709551615ul, void const**>) ./../../base/debug/stack_trace_posix.cc:1047:7 #2 0x63a95f593489 in base::debug::StackTrace::StackTrace(unsigned long) ./../../base/debug/stack_trace.cc:245:20 #3 0x63a95f253ece in logging::LogMessage::Flush() ./../../base/logging.cc:725:29 #4 0x63a95f25396d in logging::LogMessage::~LogMessage() ./../../base/logging.cc:713:3 #5 0x63a95f20756b in ~CheckLogMessage ./../../base/check.cc:193:3 #6 0x63a95f20756b in logging::(anonymous namespace)::CheckLogMessage::~CheckLogMessage() ./../../base/check.cc:190:31 #7 0x63a95f206f30 in operator() ./../../third_party/libc++/src/include/__memory/unique_ptr.h:75:5 #8 0x63a95f206f30 in reset ./../../third_party/libc++/src/include/__memory/unique_ptr.h:297:7 #9 0x63a95f206f30 in logging::NotReachedError::~NotReachedError() ./../../base/check.cc:355:16 #10 0x63a975d348af in WTF::Vector<blink::PaintChunk, 0u, blink::HeapAllocator>::at(unsigned int) const ./../../third_party/blink/renderer/platform/wtf/vector.h:1305:5 #11 0x63a975d57f4b in operator[] ./../../third_party/blink/renderer/platform/wtf/vector.h:1310:52 #12 0x63a975d57f4b in blink::PaintChunkSubset::operator[](unsigned int) const ./../../third_party/blink/renderer/platform/graphics/paint/paint_chunk_subset.h:108:12 #13 0x63a975d9700d in FirstPaintChunk ./../../third_party/blink/renderer/platform/graphics/compositing/pending_layer.cc:183:10 #14 0x63a975d9700d in blink::PendingLayer::Matches(blink::PendingLayer const&) const ./../../third_party/blink/renderer/platform/graphics/compositing/pending_layer.cc:196:54 #15 0x63a975d23989 in Find ./../../third_party/blink/renderer/platform/graphics/compositing/paint_artifact_compositor.cc:73:21 #16 0x63a975d23989 in blink::PaintArtifactCompositor::Update(blink::PaintArtifact const&, blink::PaintArtifactCompositor::ViewportProperties const&, blink::HeapVector<cppgc::internal::BasicMember<blink::TransformPaintPropertyNode const, cppgc::internal::StrongMemberTag, cppgc::internal::DijkstraWriteBarrierPolicy, cppgc::internal::DisabledCheckingPolicy, cppgc::internal::CompressedPointer>, 32u> const&, WTF::Vector<std::__Cr::unique_ptr<cc::ViewTransitionRequest, std::__Cr::default_delete<cc::ViewTransitionRequest>>, 0u, WTF::PartitionAllocator>) ./../../third_party/blink/renderer/platform/graphics/compositing/paint_artifact_compositor.cc:1006:35 #17 0x63a9711e76ef in blink::LocalFrameView::PushPaintArtifactToCompositor(bool) ./../../third_party/blink/renderer/core/frame/local_frame_view.cc:3017:31 #18 0x63a9711de07f in blink::LocalFrameView::RunPaintLifecyclePhase(blink::PaintBenchmarkMode) ./../../third_party/blink/renderer/core/frame/local_frame_view.cc:2677:5 #19 0x63a9711d825b in blink::LocalFrameView::UpdateLifecyclePhasesInternal(blink::DocumentLifecycle::LifecycleState) ./../../third_party/blink/renderer/core/frame/local_frame_view.cc:2377:3 #20 0x63a9711cfedd in blink::LocalFrameView::UpdateLifecyclePhases(blink::DocumentLifecycle::LifecycleState, blink::DocumentUpdateReason) ./../../third_party/blink/renderer/core/frame/local_frame_view.cc:2181:3 #21 0x63a9711ced65 in blink::LocalFrameView::UpdateAllLifecyclePhases(blink::DocumentUpdateReason) ./../../third_party/blink/renderer/core/frame/local_frame_view.cc:1908:54 #22 0x63a973c8b458 in blink::PageAnimator::UpdateAllLifecyclePhases(blink::LocalFrame&, blink::DocumentUpdateReason) ./../../third_party/blink/renderer/core/page/page_animator.cc:397:9 #23 0x63a97146de8d in blink::WebFrameWidgetImpl::UpdateLifecycle(blink::WebLifecycleUpdate, blink::DocumentUpdateReason) ./../../third_party/blink/renderer/core/frame/web_frame_widget_impl.cc:1663:14 #24 0x63a9761f2ce6 in UpdateVisualState ./../../third_party/blink/renderer/platform/widget/widget_base.cc:1027:12 #25 0x63a9761f2ce6 in non-virtual thunk to blink::WidgetBase::UpdateVisualState() ./../../third_party/blink/renderer/platform/widget/widget_base.cc:0:0 #26 0x63a9685d7f9e in cc::LayerTreeHost::RequestMainFrameUpdate(bool) ./../../cc/trees/layer_tree_host.cc:386:12 #27 0x63a968929d27 in cc::ProxyMain::BeginMainFrame(std::__Cr::unique_ptr<cc::BeginMainFrameAndCommitState, std::__Cr::default_delete<cc::BeginMainFrameAndCommitState>>) ./../../cc/trees/proxy_main.cc:296:21 #28 0x63a96895daca in Invoke<void (cc::ProxyMain::*)(std::__Cr::unique_ptr<cc::BeginMainFrameAndCommitState, std::__Cr::default_delete<cc::BeginMainFrameAndCommitState> >), const base::WeakPtr<cc::ProxyMain> &, std::__Cr::unique_ptr<cc::BeginMainFrameAndCommitState, std::__Cr::default_delete<cc::BeginMainFrameAndCommitState> > > ./../../base/functional/bind_internal.h:738:12 #29 0x63a96895daca in MakeItSo<void (cc::ProxyMain::*)(std::__Cr::unique_ptr<cc::BeginMainFrameAndCommitState, std::__Cr::default_delete<cc::BeginMainFrameAndCommitState> >), std::__Cr::tuple<base::WeakPtr<cc::ProxyMain>, std::__Cr::unique_ptr<cc::BeginMainFrameAndCommitState, std::__Cr::default_delete<cc::BeginMainFrameAndCommitState> > > > ./../../base/functional/bind_internal.h:954:5 #30 0x63a96895daca in void base::internal::Invoker<base::internal::FunctorTraits<void (cc::ProxyMain::*&&)(std::__Cr::unique_ptr<cc::BeginMainFrameAndCommitState, std::__Cr::default_delete<cc::BeginMainFrameAndCommitState>>), base::WeakPtr<cc::ProxyMain>&&, std::__Cr::unique_ptr<cc::BeginMainFrameAndCommitState, std::__Cr::default_delete<cc::BeginMainFrameAndCommitState>>&&>, base::internal::BindState<true, true, false, void (cc::ProxyMain::*)(std::__Cr::unique_ptr<cc::BeginMainFrameAndCommitState, std::__Cr::default_delete<cc::BeginMainFrameAndCommitState>>), base::WeakPtr<cc::ProxyMain>, std::__Cr::unique_ptr<cc::BeginMainFrameAndCommitState, std::__Cr::default_delete<cc::BeginMainFrameAndCommitState>>>, void ()>::RunImpl<void (cc::ProxyMain::*)(std::__Cr::unique_ptr<cc::BeginMainFrameAndCommitState, std::__Cr::default_delete<cc::BeginMainFrameAndCommitState>>), std::__Cr::tuple<base::WeakPtr<cc::ProxyMain>, std::__Cr::unique_ptr<cc::BeginMainFrameAndCommitState, std::__Cr::default_delete<cc::BeginMainFrameAndCommitState>>>, 0ul, 1ul>(void (cc::ProxyMain::*&&)(std::__Cr::unique_ptr<cc::BeginMainFrameAndCommitState, std::__Cr::default_delete<cc::BeginMainFrameAndCommitState>>), std::__Cr::tuple<base::WeakPtr<cc::ProxyMain>, std::__Cr::unique_ptr<cc::BeginMainFrameAndCommitState, std::__Cr::default_delete<cc::BeginMainFrameAndCommitState>>>&&, std::__Cr::integer_sequence<unsigned long, 0ul, 1ul>) ./../../base/functional/bind_internal.h:1067:14 #31 0x63a93d44d4f8 in base::OnceCallback<void ()>::Run() && ./../../base/functional/callback.h:156:12 #32 0x63a95f3ccd8c in base::TaskAnnotator::RunTaskImpl(base::PendingTask&) ./../../base/task/common/task_annotator.cc:202:34 #33 0x63a95f473609 in RunTask<(lambda at ../../base/task/sequence_manager/thread_controller_with_message_pump_impl.cc:473:11)> ./../../base/task/common/task_annotator.h:98:5 #34 0x63a95f473609 in base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWorkImpl(base::LazyNow*) ./../../base/task/sequence_manager/thread_controller_with_message_pump_impl.cc:471:23 #35 0x63a95f4718ba in base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWork() ./../../base/task/sequence_manager/thread_controller_with_message_pump_impl.cc:332:40 #36 0x63a95f474b5b in non-virtual thunk to base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWork() ./../../base/task/sequence_manager/thread_controller_with_message_pump_impl.cc:0:0 #37 0x63a95f28090b in base::MessagePumpDefault::Run(base::MessagePump::Delegate*) ./../../base/message_loop/message_pump_default.cc:40:55 #38 0x63a95f475cb8 in base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::Run(bool, base::TimeDelta) ./../../base/task/sequence_manager/thread_controller_with_message_pump_impl.cc:641:12 #39 0x63a95f34b020 in base::RunLoop::Run(base::Location const&) ./../../base/run_loop.cc:133:14 #40 0x63a97f98da9d in content::RendererMain(content::MainFunctionParams) ./../../content/renderer/renderer_main.cc:361:16 #41 0x63a95c23b8f7 in content::RunZygote(content::ContentMainDelegate*) ./../../content/app/content_main_runner_impl.cc:700:14 #42 0x63a95c23cc43 in content::RunOtherNamedProcessTypeMain(std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char>> const&, content::MainFunctionParams, content::ContentMainDelegate*) ./../../content/app/content_main_runner_impl.cc:804:12 #43 0x63a95c23fa5f in content::ContentMainRunnerImpl::Run() ./../../content/app/content_main_runner_impl.cc:1164:10 #44 0x63a95c2397f3 in content::RunContentProcess(content::ContentMainParams, content::ContentMainRunner*) ./../../content/app/content_main.cc:356:36 #45 0x63a95c23a05c in content::ContentMain(content::ContentMainParams) ./../../content/app/content_main.cc:369:10 #46 0x63a9625187d6 in content::LaunchTestsInternal(content::TestLauncherDelegate*, unsigned long, int, char**) ./../../content/public/test/test_launcher.cc:385:12 #47 0x63a962519512 in content::LaunchTests(content::TestLauncherDelegate*, unsigned long, int, char**) ./../../content/public/test/test_launcher.cc:504:10 #48 0x63a96dc8f449 in LaunchChromeTests(unsigned long, content::TestLauncherDelegate*, int, char**) ./../../chrome/test/base/chrome_test_launcher.cc:338:10 #49 0x63a95ef8f627 in main ./../../chrome/test/base/browser_tests_main.cc:60:10 #50 0x780e7da29d90 in __libc_start_call_main ./csu/../sysdeps/nptl/libc_start_call_main.h:58:16 #51 0x780e7da29e40 in __libc_start_main ./csu/../csu/libc-start.c:392:3 #52 0x63a93d34702a in _start ??:0:0 Task trace: #0 0x63a9689511e6 in cc::ProxyImpl::ScheduledActionSendBeginMainFrame(viz::BeginFrameArgs const&) ./../../cc/trees/proxy_impl.cc:760:7 #1 0x63a96892e967 in cc::ProxyMain::SendCommitRequestToImplThreadIfNeeded(cc::ProxyMain::CommitPipelineStage) ./../../cc/trees/proxy_main.cc:878:7 #2 0x63a976caa6c1 in blink::HTMLDocumentParser::SchedulePumpTokenizer(bool) ./../../third_party/blink/renderer/core/html/parser/html_document_parser.cc:890:7 #3 0x63a976caa6c1 in blink::HTMLDocumentParser::SchedulePumpTokenizer(bool) ./../../third_party/blink/renderer/core/html/parser/html_document_parser.cc:890:7 #4 0x63a976caa6c1 in blink::HTMLDocumentParser::SchedulePumpTokenizer(bool) ./../../third_party/blink/renderer/core/html/parser/html_document_parser.cc:890:7 Task trace buffer limit hit, update PendingTask::kTaskBacktraceLength to increase. Crash keys: ... [omitted rest] [3] PreviewBrowserTest.ErrorOnRedirectionToNonHttpsUrl stack trace: [ RUN ] PreviewBrowserTest.ErrorOnRedirectionToNonHttpsUrl [444109:444109:1025/041553.399357:WARNING:field_trial_util.cc(106)] Field trial config study skipped: LinkPreview.EnabledAltClick (some of its features are already overridden) [444109:444109:1025/041553.404344:WARNING:field_trial_util.cc(106)] Field trial config study skipped: PreconnectToSearchDesktop.EnabledWithStartupDelayForegroundOnly (some of its features are already overridden) [444182:444182:1025/041554.079734:WARNING:gpu_memory_buffer_support_x11.cc(49)] dri3 extension not supported. [444182:444182:1025/041554.104499:WARNING:sandbox_linux.cc(430)] InitializeSandbox() called with multiple threads in process gpu-process. [444182:444182:1025/041554.121502:WARNING:viz_main_impl.cc(85)] VizNullHypothesis is disabled (not a warning) [444183:444252:1025/041556.053677:WARNING:simple_synchronous_entry.cc(1449)] Could not open platform files for entry. [444109:444109:1025/041557.583553:WARNING:idle_linux.cc(110)] None of the known D-Bus ScreenSaver services could be used. [444109:444362:1025/041558.554846:WARNING:embedded_test_server.cc(757)] Request not handled. Returning 404: /favicon.ico [444383:444383:1025/041559.563402:ERROR:html_media_element.cc(4927)] SetError: {code=4, message="MEDIA_ELEMENT_ERROR: Media load rejected by URL safety check"} [444383:444383:1025/041559.590330:ERROR:html_media_element.cc(4927)] SetError: {code=4, message="MEDIA_ELEMENT_ERROR: Media load rejected by URL safety check"} [444383:444383:1025/041559.591717:ERROR:html_media_element.cc(4927)] SetError: {code=4, message="MEDIA_ELEMENT_ERROR: Media load rejected by URL safety check"} chrome/browser/preloading/preview/preview_test_util.cc:35: Failure Failed RunLoop::Run() timed out. Timeout set at ProxyRunTestOnMainThreadLoop@content/public/test/browser_test_base.cc:862. Stack trace: #0 0x581999742852 in base::test::(anonymous namespace)::TimeoutCallbackWithGtestFailure(base::Location const&, base::RepeatingCallback<std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char>> ()>, base::Location const&) ./../../base/test/scoped_run_loop_timeout.cc:59:3 #1 0x581999743998 in Invoke<void (*const &)(const base::Location &, base::RepeatingCallback<std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char> > ()>, const base::Location &), const base::Location &, base::RepeatingCallback<std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char> > ()>, const base::Location &> ./../../base/functional/bind_internal.h:671:12 #2 0x581999743998 in MakeItSo<void (*const &)(const base::Location &, base::RepeatingCallback<std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char> > ()>, const base::Location &), const std::__Cr::tuple<> &, const base::Location &, base::RepeatingCallback<std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char> > ()>, const base::Location &> ./../../base/functional/bind_internal.h:930:12 #3 0x581999743998 in RunImpl<void (*const &)(const base::Location &, base::RepeatingCallback<std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char> > ()>, const base::Location &), const std::__Cr::tuple<> &> ./../../base/functional/bind_internal.h:1067:14 #4 0x581999743998 in base::internal::Invoker<base::internal::FunctorTraits<void (* const&)(base::Location const&, base::RepeatingCallback<std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char>> ()>, base::Location const&)>, base::internal::BindState<false, true, false, void (*)(base::Location const&, base::RepeatingCallback<std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char>> ()>, base::Location const&)>, void (base::Location const&, base::RepeatingCallback<std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char>> ()>, base::Location const&)>::Run(base::internal::BindStateBase*, base::Location const&, base::RepeatingCallback<std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char>> ()>&&, base::Location const&) ./../../base/functional/bind_internal.h:987:12 #5 0x58199974311b in base::RepeatingCallback<void (base::Location const&, base::RepeatingCallback<std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char>> ()>, base::Location const&)>::Run(base::Location const&, base::RepeatingCallback<std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char>> ()>, base::Location const&) const & ./../../base/functional/callback.h:344:12 #6 0x581999742dde in Invoke<const base::RepeatingCallback<void (const base::Location &, base::RepeatingCallback<std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char> > ()>, const base::Location &)> &, const base::Location &, const base::RepeatingCallback<std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char> > ()> &, const base::Location &> ./../../base/functional/bind_internal.h:830:49 #7 0x581999742dde in MakeItSo<const base::RepeatingCallback<void (const base::Location &, base::RepeatingCallback<std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char> > ()>, const base::Location &)> &, const std::__Cr::tuple<base::Location, base::RepeatingCallback<std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char> > ()> > &, const base::Location &> ./../../base/functional/bind_internal.h:930:12 #8 0x581999742dde in RunImpl<const base::RepeatingCallback<void (const base::Location &, base::RepeatingCallback<std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char> > ()>, const base::Location &)> &, const std::__Cr::tuple<base::Location, base::RepeatingCallback<std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char> > ()> > &, 0UL, 1UL> ./../../base/functional/bind_internal.h:1067:14 #9 0x581999742dde in base::internal::Invoker<base::internal::FunctorTraits<base::RepeatingCallback<void (base::Location const&, base::RepeatingCallback<std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char>> ()>, base::Location const&)> const&, base::Location const&, base::RepeatingCallback<std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char>> ()> const&>, base::internal::BindState<false, true, true, base::RepeatingCallback<void (base::Location const&, base::RepeatingCallback<std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char>> ()>, base::Location const&)>, base::Location, base::RepeatingCallback<std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char>> ()>>, void (base::Location const&)>::Run(base::internal::BindStateBase*, base::Location const&) ./../../base/functional/bind_internal.h:987:12 #10 0x5819993b1250 in base::OnceCallback<void (base::Location const&)>::Run(base::Location const&) && ./../../base/functional/callback.h:156:12 #11 0x5819993aa151 in base::(anonymous namespace)::OnRunLoopTimeout(base::RunLoop*, base::Location const&, base::OnceCallback<void (base::Location const&)>) ./../../base/run_loop.cc:40:25 #12 0x5819993b0c25 in Invoke<void (*)(base::RunLoop *, const base::Location &, base::OnceCallback<void (const base::Location &)>), base::RunLoop *, base::Location, base::RepeatingCallback<void (const base::Location &)> > ./../../base/functional/bind_internal.h:671:12 #13 0x5819993b0c25 in MakeItSo<void (*)(base::RunLoop *, const base::Location &, base::OnceCallback<void (const base::Location &)>), std::__Cr::tuple<base::internal::UnretainedWrapper<base::RunLoop, base::unretained_traits::MayNotDangle, (partition_alloc::internal::RawPtrTraits)0>, base::Location, base::RepeatingCallback<void (const base::Location &)> > > ./../../base/functional/bind_internal.h:930:12 #14 0x5819993b0c25 in RunImpl<void (*)(base::RunLoop *, const base::Location &, base::OnceCallback<void (const base::Location &)>), std::__Cr::tuple<base::internal::UnretainedWrapper<base::RunLoop, base::unretained_traits::MayNotDangle, (partition_alloc::internal::RawPtrTraits)0>, base::Location, base::RepeatingCallback<void (const base::Location &)> >, 0UL, 1UL, 2UL> ./../../base/functional/bind_internal.h:1067:14 #15 0x5819993b0c25 in base::internal::Invoker<base::internal::FunctorTraits<void (*&&)(base::RunLoop*, base::Location const&, base::OnceCallback<void (base::Location const&)>), base::RunLoop*, base::Location&&, base::RepeatingCallback<void (base::Location const&)>&&>, base::internal::BindState<false, true, false, void (*)(base::RunLoop*, base::Location const&, base::OnceCallback<void (base::Location const&)>), base::internal::UnretainedWrapper<base::RunLoop, base::unretained_traits::MayNotDangle, (partition_alloc::internal::RawPtrTraits)0>, base::Location, base::RepeatingCallback<void (base::Location const&)>>, void ()>::RunOnce(base::internal::BindStateBase*) ./../../base/functional/bind_internal.h:980:12 #16 0x5819774ab4f8 in base::OnceCallback<void ()>::Run() && ./../../base/functional/callback.h:156:12 #17 0x58197f9e29d4 in void base::internal::CancelableCallbackImpl<base::OnceCallback<void ()>>::ForwardOnce<>() ./../../base/cancelable_callback.h:134:26 #18 0x58197f9e2f2e in Invoke<void (base::internal::CancelableCallbackImpl<base::OnceCallback<void ()> >::*)(), const base::WeakPtr<base::internal::CancelableCallbackImpl<base::OnceCallback<void ()> > > &> ./../../base/functional/bind_internal.h:738:12 #19 0x58197f9e2f2e in MakeItSo<void (base::internal::CancelableCallbackImpl<base::OnceCallback<void ()> >::*)(), std::__Cr::tuple<base::WeakPtr<base::internal::CancelableCallbackImpl<base::OnceCallback<void ()> > > > > ./../../base/functional/bind_internal.h:954:5 #20 0x58197f9e2f2e in void base::internal::Invoker<base::internal::FunctorTraits<void (base::internal::CancelableCallbackImpl<base::OnceCallback<void ()>>::*&&)(), base::WeakPtr<base::internal::CancelableCallbackImpl<base::OnceCallback<void ()>>>&&>, base::internal::BindState<true, true, false, void (base::internal::CancelableCallbackImpl<base::OnceCallback<void ()>>::*)(), base::WeakPtr<base::internal::CancelableCallbackImpl<base::OnceCallback<void ()>>>>, void ()>::RunImpl<void (base::internal::CancelableCallbackImpl<base::OnceCallback<void ()>>::*)(), std::__Cr::tuple<base::WeakPtr<base::internal::CancelableCallbackImpl<base::OnceCallback<void ()>>>>, 0ul>(void (base::internal::CancelableCallbackImpl<base::OnceCallback<void ()>>::*&&)(), std::__Cr::tuple<base::WeakPtr<base::internal::CancelableCallbackImpl<base::OnceCallback<void ()>>>>&&, std::__Cr::integer_sequence<unsigned long, 0ul>) ./../../base/functional/bind_internal.h:1067:14 #21 0x5819774ab4f8 in base::OnceCallback<void ()>::Run() && ./../../base/functional/callback.h:156:12 #22 0x58199942ad8c in base::TaskAnnotator::RunTaskImpl(base::PendingTask&) ./../../base/task/common/task_annotator.cc:202:34 #23 0x5819994d1609 in RunTask<(lambda at ../../base/task/sequence_manager/thread_controller_with_message_pump_impl.cc:473:11)> ./../../base/task/common/task_annotator.h:98:5 #24 0x5819994d1609 in base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWorkImpl(base::LazyNow*) ./../../base/task/sequence_manager/thread_controller_with_message_pump_impl.cc:471:23 #25 0x5819994cf8ba in base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWork() ./../../base/task/sequence_manager/thread_controller_with_message_pump_impl.cc:332:40 #26 0x5819994d2b5b in non-virtual thunk to base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWork() ./../../base/task/sequence_manager/thread_controller_with_message_pump_impl.cc:0:0 #27 0x5819996866c3 in base::MessagePumpGlib::HandleDispatch() ./../../base/message_loop/message_pump_glib.cc:649:46 #28 0x581999689959 in base::(anonymous namespace)::WorkSourceDispatch(_GSource*, int (*)(void*), void*) ./../../base/message_loop/message_pump_glib.cc:274:43 #29 0x703e1f8f4d3b in g_main_context_dispatch ??:0:0 #30 0x703e1f94a2b8 in g_io_channel_new_file ??:? #31 0x703e1f8f23e3 in g_main_context_iteration ??:0:0 #32 0x581999686cf0 in base::MessagePumpGlib::Run(base::MessagePump::Delegate*) ./../../base/message_loop/message_pump_glib.cc:683:30 #33 0x5819994d3cb8 in base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::Run(bool, base::TimeDelta) ./../../base/task/sequence_manager/thread_controller_with_message_pump_impl.cc:641:12 #34 0x5819993a9020 in base::RunLoop::Run(base::Location const&) ./../../base/run_loop.cc:133:14 #35 0x58199909ac37 in Wait ./../../chrome/browser/preloading/preview/preview_test_util.cc:35:17 #36 0x58199909ac37 in test::PreviewTestHelper::WaitUntilLoadFinished() ./../../chrome/browser/preloading/preview/preview_test_util.cc:90:16 #37 0x58197f539b56 in PreviewBrowserTest_ErrorOnRedirectionToNonHttpsUrl_Test::RunTestOnMainThread() ./../../chrome/browser/preloading/preview/preview_browsertest.cc:309:12 #38 0x58199c3a39c1 in content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() ./../../content/public/test/browser_test_base.cc:955:9 #39 0x58199c3a81c4 in Invoke<void (content::BrowserTestBase::*)(), content::BrowserTestBase *> ./../../base/functional/bind_internal.h:738:12 #40 0x58199c3a81c4 in MakeItSo<void (content::BrowserTestBase::*)(), std::__Cr::tuple<base::internal::UnretainedWrapper<content::BrowserTestBase, base::unretained_traits::MayNotDangle, (partition_alloc::internal::RawPtrTraits)0> > > ./../../base/functional/bind_internal.h:930:12 #41 0x58199c3a81c4 in RunImpl<void (content::BrowserTestBase::*)(), std::__Cr::tuple<base::internal::UnretainedWrapper<content::BrowserTestBase, base::unretained_traits::MayNotDangle, (partition_alloc::internal::RawPtrTraits)0> >, 0UL> ./../../base/functional/bind_internal.h:1067:14 #42 0x58199c3a81c4 in base::internal::Invoker<base::internal::FunctorTraits<void (content::BrowserTestBase::*&&)(), content::BrowserTestBase*>, base::internal::BindState<true, true, false, void (content::BrowserTestBase::*)(), base::internal::UnretainedWrapper<content::BrowserTestBase, base::unretained_traits::MayNotDangle, (partition_alloc::internal::RawPtrTraits)0>>, void ()>::RunOnce(base::internal::BindStateBase*) ./../../base/functional/bind_internal.h:980:12 #43 0x5819774ab4f8 in base::OnceCallback<void ()>::Run() && ./../../base/functional/callback.h:156:12 #44 0x58198e84361a in InterceptMainMessageLoopRun ./../../content/browser/browser_main_loop.cc:1074:36 #45 0x58198e84361a in content::BrowserMainLoop::RunMainMessageLoop() ./../../content/browser/browser_main_loop.cc:1086:7 #46 0x58198e84c18d in content::BrowserMainRunnerImpl::Run() ./../../content/browser/browser_main_runner_impl.cc:156:15 #47 0x58198e839c99 in content::BrowserMain(content::MainFunctionParams) ./../../content/browser/browser_main.cc:34:28 #48 0x58199629a625 in content::RunBrowserProcessMain(content::MainFunctionParams, content::ContentMainDelegate*) ./../../content/app/content_main_runner_impl.cc:732:10 #49 0x58199629e5ed in content::ContentMainRunnerImpl::RunBrowser(content::MainFunctionParams, bool) ./../../content/app/content_main_runner_impl.cc:1311:10 #50 0x58199629da92 in content::ContentMainRunnerImpl::Run() ./../../content/app/content_main_runner_impl.cc:1162:12 #51 0x5819962977f3 in content::RunContentProcess(content::ContentMainParams, content::ContentMainRunner*) ./../../content/app/content_main.cc:356:36 #52 0x58199629805c in content::ContentMain(content::ContentMainParams) ./../../content/app/content_main.cc:369:10 #53 0x58199c3a1792 in content::BrowserTestBase::SetUp() ./../../content/public/test/browser_test_base.cc:622:3 #54 0x5819991ef1d3 in InProcessBrowserTest::SetUp() ./../../chrome/test/base/in_process_browser_test.cc:542:20 [444109:444109:1025/041658.647315:FATAL:preview_manager.cc(73)] Check failed: tab_. #0 0x5819773eb586 in ___interceptor_backtrace /b/s/w/ir/cache/builder/src/third_party/llvm/compiler-rt/lib/asan/../sanitizer_common/sanitizer_common_interceptors.inc:4441:13 #1 0x58199963a688 in base::debug::CollectStackTrace(base::span<void const*, 18446744073709551615ul, void const**>) ./../../base/debug/stack_trace_posix.cc:1047:7 #2 0x5819995f1489 in base::debug::StackTrace::StackTrace(unsigned long) ./../../base/debug/stack_trace.cc:245:20 #3 0x5819992b1ece in logging::LogMessage::Flush() ./../../base/logging.cc:725:29 #4 0x5819992b196d in logging::LogMessage::~LogMessage() ./../../base/logging.cc:713:3 #5 0x58199926556b in ~CheckLogMessage ./../../base/check.cc:193:3 #6 0x58199926556b in logging::(anonymous namespace)::CheckLogMessage::~CheckLogMessage() ./../../base/check.cc:190:31 #7 0x581999264f30 in operator() ./../../third_party/libc++/src/include/__memory/unique_ptr.h:75:5 #8 0x581999264f30 in reset ./../../third_party/libc++/src/include/__memory/unique_ptr.h:297:7 #9 0x581999264f30 in logging::NotReachedError::~NotReachedError() ./../../base/check.cc:355:16 #10 0x58199a3afe8f in PreviewManager::GetWebContentsForPreviewTab() ./../../chrome/browser/preloading/preview/preview_manager.cc:73:3 #11 0x58197f539b87 in PreviewBrowserTest_ErrorOnRedirectionToNonHttpsUrl_Test::RunTestOnMainThread() ./../../chrome/browser/preloading/preview/preview_browsertest.cc:312:16 #12 0x58199c3a39c1 in content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() ./../../content/public/test/browser_test_base.cc:955:9 #13 0x58199c3a81c4 in Invoke<void (content::BrowserTestBase::*)(), content::BrowserTestBase *> ./../../base/functional/bind_internal.h:738:12 #14 0x58199c3a81c4 in MakeItSo<void (content::BrowserTestBase::*)(), std::__Cr::tuple<base::internal::UnretainedWrapper<content::BrowserTestBase, base::unretained_traits::MayNotDangle, (partition_alloc::internal::RawPtrTraits)0> > > ./../../base/functional/bind_internal.h:930:12 #15 0x58199c3a81c4 in RunImpl<void (content::BrowserTestBase::*)(), std::__Cr::tuple<base::internal::UnretainedWrapper<content::BrowserTestBase, base::unretained_traits::MayNotDangle, (partition_alloc::internal::RawPtrTraits)0> >, 0UL> ./../../base/functional/bind_internal.h:1067:14 #16 0x58199c3a81c4 in base::internal::Invoker<base::internal::FunctorTraits<void (content::BrowserTestBase::*&&)(), content::BrowserTestBase*>, base::internal::BindState<true, true, false, void (content::BrowserTestBase::*)(), base::internal::UnretainedWrapper<content::BrowserTestBase, base::unretained_traits::MayNotDangle, (partition_alloc::internal::RawPtrTraits)0>>, void ()>::RunOnce(base::internal::BindStateBase*) ./../../base/functional/bind_internal.h:980:12 #17 0x5819774ab4f8 in base::OnceCallback<void ()>::Run() && ./../../base/functional/callback.h:156:12 #18 0x58198e84361a in InterceptMainMessageLoopRun ./../../content/browser/browser_main_loop.cc:1074:36 #19 0x58198e84361a in content::BrowserMainLoop::RunMainMessageLoop() ./../../content/browser/browser_main_loop.cc:1086:7 #20 0x58198e84c18d in content::BrowserMainRunnerImpl::Run() ./../../content/browser/browser_main_runner_impl.cc:156:15 #21 0x58198e839c99 in content::BrowserMain(content::MainFunctionParams) ./../../content/browser/browser_main.cc:34:28 #22 0x58199629a625 in content::RunBrowserProcessMain(content::MainFunctionParams, content::ContentMainDelegate*) ./../../content/app/content_main_runner_impl.cc:732:10 #23 0x58199629e5ed in content::ContentMainRunnerImpl::RunBrowser(content::MainFunctionParams, bool) ./../../content/app/content_main_runner_impl.cc:1311:10 #24 0x58199629da92 in content::ContentMainRunnerImpl::Run() ./../../content/app/content_main_runner_impl.cc:1162:12 #25 0x5819962977f3 in content::RunContentProcess(content::ContentMainParams, content::ContentMainRunner*) ./../../content/app/content_main.cc:356:36 #26 0x58199629805c in content::ContentMain(content::ContentMainParams) ./../../content/app/content_main.cc:369:10 #27 0x58199c3a1792 in content::BrowserTestBase::SetUp() ./../../content/public/test/browser_test_base.cc:622:3 #28 0x5819991ef1d3 in InProcessBrowserTest::SetUp() ./../../chrome/test/base/in_process_browser_test.cc:542:20 #29 0x581996ad3b19 in HandleExceptionsInMethodIfSupported<testing::Test, void> ./../../third_party/googletest/src/googletest/src/gtest.cc:0:0 #30 0x581996ad3b19 in testing::Test::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2723:3 #31 0x581996ad61c2 in testing::TestInfo::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2874:11 #32 0x581996ad7d64 in testing::TestSuite::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:3052:30 #33 0x581996aff5b5 in testing::internal::UnitTestImpl::RunAllTests() ./../../third_party/googletest/src/googletest/src/gtest.cc:5982:44 #34 0x581996afe64f in HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool> ./../../third_party/googletest/src/googletest/src/gtest.cc:0:0 #35 0x581996afe64f in testing::UnitTest::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:5561:10 #36 0x581999761d1c in base::TestSuite::Run() ./../../base/test/test_suite.cc:421:16 #37 0x5819a7cecba7 in RunTestSuiteInternal ./../../chrome/test/base/chrome_test_launcher.cc:99:22 #38 0x5819a7cecba7 in ChromeTestSuiteRunner::RunTestSuite(int, char**) ./../../chrome/test/base/chrome_test_launcher.cc:104:10 #39 0x58199c576a7d in content::LaunchTestsInternal(content::TestLauncherDelegate*, unsigned long, int, char**) ./../../content/public/test/test_launcher.cc:409:31 #40 0x58199c577512 in content::LaunchTests(content::TestLauncherDelegate*, unsigned long, int, char**) ./../../content/public/test/test_launcher.cc:504:10 #41 0x5819a7ced449 in LaunchChromeTests(unsigned long, content::TestLauncherDelegate*, int, char**) ./../../chrome/test/base/chrome_test_launcher.cc:338:10 #42 0x581998fed627 in main ./../../chrome/test/base/browser_tests_main.cc:60:10 #43 0x703e1da29d90 in __libc_start_call_main ./csu/../sysdeps/nptl/libc_start_call_main.h:58:16 #44 0x703e1da29e40 in __libc_start_main ./csu/../csu/libc-start.c:392:3 #45 0x5819773a502a in _start ??:0:0 Crash keys: ... [omitted rest] Original change's description: > Prerender: first impl to dry run painting on prerendering page > > This CL triggers tree build right after renderer parsed the main DOM > tree. CHCKEs on the browser side will guard the metric correctness. > (See Ifd788c4b04f06a6b98caff1bb9df55af5fb8f07a) > The following CLs will: > 1. only trigger it for DSE. > 2. add more metrics on the renderer side to verify the correctness. > > Bug: 40240492 > Change-Id: Icd94bad6a6ecfc5e492e4d9c4b4c227741c041d2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5912738 > Reviewed-by: Hiroki Nakagawa <[email protected]> > Reviewed-by: Taiyo Mizuhashi <[email protected]> > Commit-Queue: Lingqi Chi <[email protected]> > Cr-Commit-Position: refs/heads/main@{#1373803} Bug: 40240492 Change-Id: I8729c84b4ceb1a77761c738f96c4c03675dfcdb0 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5966495 Commit-Queue: Mark Pearson <[email protected]> Bot-Commit: Rubber Stamper <[email protected]> Owners-Override: Mark Pearson <[email protected]> Auto-Submit: Mark Pearson <[email protected]> Cr-Commit-Position: refs/heads/main@{#1374047}
pull bot
pushed a commit
that referenced
this pull request
Nov 20, 2024
This implements the core Sanitizer logic. This is still missing spec-mandated handling of "javascript:" URLs, and will have to be updated as the spec develops. But other than that, the basics are now there. ------------------ This a re-land of crrev.com/c/5922125. Patch set #1 is the original version, as reviewed and submitted there. Patch set #2 contains the fix. Analysis of the bug is in https://issues.chromium.org/issues/356601280#comment16 Bug: 356601280, 379235386, 379246316 Change-Id: I06d4a9a378330cc76015e3922b9e288d9503881a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6021482 Reviewed-by: Yifan Luo <[email protected]> Reviewed-by: Joey Arhar <[email protected]> Commit-Queue: Daniel Vogelheim <[email protected]> Cr-Commit-Position: refs/heads/main@{#1385522}
pull bot
pushed a commit
that referenced
this pull request
Nov 20, 2024
Screencast: https://screencast.googleplex.com/cast/NTEyMzkzMjg1NTIwNTg4OHxiZGQ4YWFkZC1kZA Fixes in part #1 (this CL): - Batch Upload entry point properly reads the title, subtitle and the button content. - Account icon is not navigable. - Items icons are not navigable. - Checkbox reads it's content and is not navigable. - Toggle and Expand button reads the section title without the count for clearer context. - When unselecting last checkbox of a section, the focus goes back to the section's toggle since it got disabled. Fixes to be done in part #2 (follow CL): - Make focusing the last checked checkbox announce text that mentions that unchecking it will be disable the section. - Announce the number of selected items after checking or unchecking an item. - Make the toggle say a more specific action: "Select all/none" All changes in part #2 requires adding new strings. Fixed: b:378720472, b:378718895, b:378711564 Bug: b:378746667 Change-Id: I98251bdd5d3adcbe1a7ed3e2a7a62c2327964b58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6032478 Reviewed-by: David Roger <[email protected]> Code-Coverage: [email protected] <[email protected]> Commit-Queue: Ryan Sultanem <[email protected]> Cr-Commit-Position: refs/heads/main@{#1385535}
pull bot
pushed a commit
that referenced
this pull request
Nov 21, 2024
A previous attempt at fixing https://crbug.com/1221690 (truncated option text) was to expose different text, rather than exposing the name. However, it's important to expose the accessible name because a lot more goes into it than just appending descendant text together. For example, whitespace is added where appropriate. Therefore, the previous fix caused new bugs such as https://crbug.com/40773609. The original problem occurs because VoiceOver does not expect a descendant subtree for AXStaticText, and ends up using the subtree's text but concatenates it to the length of the AXValue. To fix this issue while retaining the accessible name, we can either: 1. Truncate the subtree for options. The problem with this is that options can have important, even interactive, descendants. 2. Use a different role than the officially recommended role. It seems that NSAccessibilityMenuItemRole is reasonable. It does cause VoiceOver to announce each option as a menu item, but it seems that the options basically are similar to menu items. Idea #2 seems to have the fewest downsides. Therefore, this CL undes the original problematic fix from CL:2976454 and instead implements idea #2. In the meantime we have contacted James Craig from Apple for a recommendation. They are going to look into a fix in VoiceOver and get back to us when there is a new recommendation. For the short term, James said it makes sense to go with solution #2 (this CL). Bug: 40773609 Change-Id: Ie56ae7755c4ea077f222e58b0910a997cabdf821 Fixed: 379289359 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6034459 Auto-Submit: Aaron Leventhal <[email protected]> Commit-Queue: Aaron Leventhal <[email protected]> Reviewed-by: Jacques Newman <[email protected]> Cr-Commit-Position: refs/heads/main@{#1386458}
pull bot
pushed a commit
that referenced
this pull request
Nov 22, 2024
Those tests fail on headless shell. Temporary run them on Chrome to make the migration easlier. Test owners should clean up this list at a later time. Bug: 40927590 Change-Id: I1f7b19c8a60f1f20ddc3a7c46c20d29b8caf3a5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6029531 Reviewed-by: Jonathan Lee <[email protected]> Commit-Queue: Weizhong Xia <[email protected]> Cr-Commit-Position: refs/heads/main@{#1386907}
pull bot
pushed a commit
that referenced
this pull request
Nov 28, 2024
This patch adds support for basic HTTP Message Signature parsing, as per RFC9421. It does not support all (or even most) of that RFC's options, limiting the accepted inputs to those that match the constraints at https://wicg.github.io/signature-based-sri/#profile. I expect we'll loosen those constraints over time, but this is a good place to start. This is part of a chain of CLs implementing this feature (#2 from https://wicg.github.io/signature-based-sri/#overview): 1. [Parsing] https://crrev.com/c/6020612 [You are here] 2. [Validation 1] https://crrev.com/c/6030571 3. [Validation 2] https://crrev.com/c/6032589 4. [Enforcement] https://crrev.com/c/6038714 Bug: 379534943 Change-Id: Id4fd08c279cf59259ec1911675ceb45fd5679fca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6020612 Reviewed-by: Kenichi Ishibashi <[email protected]> Commit-Queue: Mike West <[email protected]> Reviewed-by: Camille Lamy <[email protected]> Cr-Commit-Position: refs/heads/main@{#1389286}
pull bot
pushed a commit
that referenced
this pull request
Nov 28, 2024
This patch implements the subset of HTTP Message Signature's "signature base" concept necessary to validate signature-based SRI assertions. The core of the algorithm is the same as what's described in the spec at https://www.rfc-editor.org/rfc/rfc9421.html#name-creating-the-signature-base with a few simplifications given SRI's constraints. This is part of a chain of CLs implementing this feature (#2 from https://wicg.github.io/signature-based-sri/#overview): 1. [Parsing] https://crrev.com/c/6020612 2. [Validation 1] https://crrev.com/c/6030571 [You are here] 3. [Validation 2] https://crrev.com/c/6032589 4. [Enforcement] https://crrev.com/c/6038714 Bug: 379534943 Change-Id: Ibb9d2b5552d19f7a4ed7ff8721509473291fb8fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6030571 Reviewed-by: Camille Lamy <[email protected]> Commit-Queue: Mike West <[email protected]> Reviewed-by: Kenichi Ishibashi <[email protected]> Cr-Commit-Position: refs/heads/main@{#1389287}
pull bot
pushed a commit
that referenced
this pull request
Nov 28, 2024
This patch adds a validation mechanism which verifies an Ed25519 signature over a set of headers, relying on the previous CL's "signature base" construction to do so. This is part of a chain of CLs implementing this feature (#2 from https://wicg.github.io/signature-based-sri/#overview): 1. [Parsing] https://crrev.com/c/6020612 2. [Validation 1] https://crrev.com/c/6030571 3. [Validation 2] https://crrev.com/c/6032589 [You are here] 4. [Enforcement] https://crrev.com/c/6038714 Bug: 379534943 Change-Id: Ie30e35dadefbb0887693fe67fa4a4ac0667666e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6032589 Reviewed-by: Camille Lamy <[email protected]> Reviewed-by: Kenichi Ishibashi <[email protected]> Commit-Queue: Mike West <[email protected]> Cr-Commit-Position: refs/heads/main@{#1389292}
pull bot
pushed a commit
that referenced
this pull request
Nov 28, 2024
This patch teaches the network service's `URLLoader` how to evaluate the SRI-valid subset of HTTP Message Signatures, blocking mismatched responses once headers are received and processed. This check is implemented behind a new feature flag, which is disabled by default. End-to-end tests live in web platform tests under //web_tests/virtual/sri-message-signatures that enables the flag. This is part of a chain of CLs implementing this feature (#2 from https://wicg.github.io/signature-based-sri/#overview): 1. [Parsing] https://crrev.com/c/6020612 2. [Validation 1] https://crrev.com/c/6030571 3. [Validation 2] https://crrev.com/c/6032589 4. [Enforcement] https://crrev.com/c/6038714 [You are here] `url_loader.cc` are the only meaningful changes in behavior reported as undercovered. These are tested through the WPT included in this CL. Bug: 379534943 Low-Coverage-Reason: COVERAGE_UNDERREPORTED The changes to Change-Id: I6ece80da25ed4329a6f976c2c74c639c2799b856 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6038714 Reviewed-by: Kenichi Ishibashi <[email protected]> Reviewed-by: Camille Lamy <[email protected]> Reviewed-by: Kent Tamura <[email protected]> Commit-Queue: Mike West <[email protected]> Cr-Commit-Position: refs/heads/main@{#1389294}
pull bot
pushed a commit
that referenced
this pull request
Nov 29, 2024
Mainly remove ProfilePickerForceSigninDialogHost along with its remaining usages in the Profile Picker. Remaining todos in followup: - Remove the `from_profile_picker` url param. - Check what can be removed in the inline_login_handler. Marked dead code/unused functions with TODOs to be tackled in the followup, that might result in a lot of code to be removed. Bug: b:381231566 Change-Id: I49eec2394ed9630de674250b447fbae9db5273bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6054246 Reviewed-by: Nicolas Dossou-Gbété <[email protected]> Commit-Queue: Ryan Sultanem <[email protected]> Cr-Commit-Position: refs/heads/main@{#1389708}
pull bot
pushed a commit
that referenced
this pull request
Dec 4, 2024
…s //media." #2 This reverts commit dd89c95. Reason: https://groups.google.com/a/chromium.org/g/chromium-dev/c/KxzyXKv7adQ Based on the discussion here, I have decided to terminate this work. This CL was uploaded by git cl split. [email protected] Bug: 377144451 Change-Id: I6718ca868173be505d6d180dc1760a706eac65cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6065105 Commit-Queue: Ho Cheung <[email protected]> Reviewed-by: Nasko Oskov <[email protected]> Reviewed-by: Colin Blundell <[email protected]> Cr-Commit-Position: refs/heads/main@{#1391390}
pull bot
pushed a commit
that referenced
this pull request
Dec 4, 2024
Enforces that the Skia Graphite status of the browser matches what the arguments requested, e.g. that Skia Graphite is actually used when --enable-features=SkiaGraphite is passed in. Since this applies to multiple test types, this check and the other similar checks are moved out of the WebGL test class and into the base GPU test class. As a result of making this change, it was discovered that there are cases where: 1. Test-specific browser args conflict with suite-level browser args, which results in the actual browser args used being random due to non-deterministic set ordering between different runs in Python. 2. At least one test specifying browser args that will cause the new arg validation to fail. #1 is fixed by detecting such potential conflicts and prioritizing the test-specific args. #2 is fixed by skipping the affected tests in cases where running them does not make sense. Additionally, Skia Graphite tests are removed from stable Win/NVIDIA GTX 1660 testers for now since Skia Graphite is blocklisted on our current driver version. Bug: 372740546 Change-Id: Ia5677405dcc9aaf0196ac0e2667a834a132533cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5925013 Reviewed-by: Yuly Novikov <[email protected]> Auto-Submit: Brian Sheedy <[email protected]> Commit-Queue: Yuly Novikov <[email protected]> Cr-Commit-Position: refs/heads/main@{#1391589}
pull bot
pushed a commit
that referenced
this pull request
Dec 6, 2024
We make a series of successive small improvements:
1. Together with the parent stack, store what values we set
(i.e., were not already set). This allows us to switch away
from the CountingBloomFilter to a non-counting version,
which does not have the “stickiness” problem and is much
smaller (reducing L1 cache footprint).
2. Due to #1, we can make the filter much larger without
blowing up the cache.
3. Due to #2, we can switch from a Bloom filter to a simple
bitset, reducing the number of lookups (including cache
costs) from two to one.
4. Due to #3, we don't need 24 bits of hash anymore, but can
do with a simple uint16_t, saving a little bit of RAM
for the rulesets.
We also improve the salting (empirically improving the
collision resistance); we don't need to salt all hashes,
one of them can stay unsalted, and we don't need to waste
so many of the lower bits by using the larger primes.
Style perftest (Zen 3, LTO but no PGO):
Initial style (µs) Before After Perf 95% CI (BCa)
=================== ========= ========= ======= =================
ECommerce 5493 5432 +1.1% [ +1.1%, +1.2%]
Encyclopedia 48213 47895 +0.7% [ +0.6%, +0.7%]
Extension 52744 52202 +1.0% [ +1.0%, +1.2%]
News 22890 22795 +0.4% [ +0.3%, +1.0%]
Search 7845 7759 +1.1% [ +1.1%, +1.2%]
Social1 14198 14026 +1.2% [ +0.6%, +1.4%]
Social2 9260 9154 +1.2% [ +1.1%, +1.2%]
Sports 30637 30668 -0.1% [ -0.1%, -0.1%]
Video 19402 19189 +1.1% [ +1.0%, +1.2%]
Geometric mean +0.9% [ +0.8%, +0.9%]
Recalc style (µs) Before After Perf 95% CI (BCa)
=================== ========= ========= ======= =================
ECommerce 3006 2951 +1.8% [ +1.8%, +1.9%]
Encyclopedia 35889 35356 +1.5% [ +1.2%, +1.6%]
Extension 40928 40421 +1.3% [ +1.2%, +1.3%]
News 11580 11481 +0.9% [ +0.8%, +0.9%]
Search 2989 2924 +2.2% [ +2.1%, +2.3%]
Social1 6981 6836 +2.1% [ +2.1%, +2.2%]
Social2 4888 4810 +1.6% [ +1.6%, +1.7%]
Sports 14605 14352 +1.8% [ +1.6%, +2.4%]
Video 7942 7863 +1.0% [ +0.0%, +1.2%]
Geometric mean +1.6% [ +1.5%, +1.6%]
PartitionAlloc memory used (it is not clear why Video increases):
Video: 3560 → 3608 kB ( +48 kB)
Extension: 904 → 888 kB ( -16 kB)
News: 1948 → 1932 kB ( -16 kB)
ECommerce: 1420 → 1404 kB ( -16 kB)
Social1: 2348 → 2316 kB ( -32 kB)
Social2: 808 → 792 kB ( -16 kB)
Encyclopedia: 2212 → 2172 kB ( -48 kB)
Sports: 1888 → 1824 kB ( -64 kB)
Search: 2720 → 2704 kB ( -16 kB)
Speedometer3 is neutral.
Change-Id: I388fa7f2edc9548719401cc7a58b3e7a055a69ea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6068473
Commit-Queue: Steinar H Gunderson <[email protected]>
Reviewed-by: Anders Hartvoll Ruud <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1392869}
pull bot
pushed a commit
that referenced
this pull request
Dec 18, 2024
This reverts commit d20b009. Reason for revert: VoiceOver not reading autofill, crbug.com/379143333 Original change's description: > [A11y] Expose options as NSAccessibilityMenuItemRole > > A previous attempt at fixing https://crbug.com/1221690 (truncated > option text) was to expose different text, rather than exposing the > name. However, it's important to expose the accessible name because a > lot more goes into it than just appending descendant text together. > For example, whitespace is added where appropriate. Therefore, the > previous fix caused new bugs such as https://crbug.com/40773609. > > The original problem occurs because VoiceOver does not expect a > descendant subtree for AXStaticText, and ends up using the subtree's > text but concatenates it to the length of the AXValue. > > To fix this issue while retaining the accessible name, we can either: > 1. Truncate the subtree for options. The problem with this is that > options can have important, even interactive, descendants. > 2. Use a different role than the officially recommended role. It seems > that NSAccessibilityMenuItemRole is reasonable. It does cause VoiceOver > to announce each option as a menu item, but it seems that the options > basically are similar to menu items. > > Idea #2 seems to have the fewest downsides. Therefore, this CL > undes the original problematic fix from CL:2976454 and instead > implements idea #2. > > In the meantime we have contacted James Craig from Apple for a > recommendation. They are going to look into a fix in VoiceOver and > get back to us when there is a new recommendation. For the short term, > James said it makes sense to go with solution #2 (this CL). > > Bug: 40773609 > Change-Id: Ie56ae7755c4ea077f222e58b0910a997cabdf821 > Fixed: 379289359 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6034459 > Auto-Submit: Aaron Leventhal <[email protected]> > Commit-Queue: Aaron Leventhal <[email protected]> > Reviewed-by: Jacques Newman <[email protected]> > Cr-Commit-Position: refs/heads/main@{#1386458} Bug: 40773609 Change-Id: I2c380ed18c20003c48ed812fde905f2bac1e1418 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6101793 Commit-Queue: Aaron Leventhal <[email protected]> Auto-Submit: Aaron Leventhal <[email protected]> Reviewed-by: Jacques Newman <[email protected]> Cr-Commit-Position: refs/heads/main@{#1397628}
pull bot
pushed a commit
that referenced
this pull request
Dec 27, 2024
The answers feature check in the history WebUI controller can be safely removed, because #1 answers may be disabled for the profile even if the answers feature itself is enabled. and #2 when the feature is disabled, the answer mojom fields fall back to default values with the exception of the answer text which should be empty. Bug: 381108241 Change-Id: I2c7bcd3bd38aab64263103cbea923ac1d25ad75a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6116038 Commit-Queue: Moe Ahmadi <[email protected]> Reviewed-by: John Lee <[email protected]> Code-Coverage: [email protected] <[email protected]> Cr-Commit-Position: refs/heads/main@{#1400350}
pull bot
pushed a commit
that referenced
this pull request
Jan 7, 2025
Reason for revert in CL:6101793: VoiceOver not reading autofill, crbug.com/379143333 Fixed autofill case by only implementing the new role for content. We keep NSAccessibilityStaticTextRole for options in UI. Eventually, we hope that Apple will provide new role for options. Original commit message: A previous attempt at fixing https://crbug.com/1221690 (truncated option text) was to expose different text, rather than exposing the name. However, it's important to expose the accessible name because a lot more goes into it than just appending descendant text together. For example, whitespace is added where appropriate. Therefore, the previous fix caused new bugs such as https://crbug.com/40773609. The original problem occurs because VoiceOver does not expect a descendant subtree for AXStaticText, and ends up using the subtree's text but concatenates it to the length of the AXValue. To fix this issue while retaining the accessible name, we can either: 1. Truncate the subtree for options. The problem with this is that options can have important, even interactive, descendants. 2. Use a different role than the officially recommended role. It seems that NSAccessibilityMenuItemRole is reasonable. It does cause VoiceOver to announce each option as a menu item, but it seems that the options basically are similar to menu items. Idea #2 seems to have the fewest downsides. Therefore, this CL undoes the original problematic fix from CL:2976454 and instead implements idea #2. In the meantime we have contacted James Craig from Apple for a recommendation. They are going to look into a fix in VoiceOver and get back to us when there is a new recommendation. For the short term, James said it makes sense to go with solution #2 (this CL). Bug: 40773609 Change-Id: Ibd8ab9939cbad5ba77bfe35ac8289be84b1fec9e Fixed: 379289359 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6104178 Reviewed-by: Jacques Newman <[email protected]> Commit-Queue: Aaron Leventhal <[email protected]> Cr-Commit-Position: refs/heads/main@{#1403047}
pull bot
pushed a commit
that referenced
this pull request
Jan 9, 2025
… document.scripts()" This reverts commit 14d9421. Reason for revert: extensions_unittests failures started after this CL on Linux UBSAN, see failed build at https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20UBSan%20Tests/2624/overview Specific test failure: https://luci-milo.appspot.com/ui/inv/build-8726283549253023857/test-results?q=ScriptContextSetTest.Lifecycle&sortby=&groupby= Partial stack trace seems related to this CL: ../../v8/include/cppgc/member.h:258:43: runtime error: reference binding to null pointer of type 'blink::Element' #0 0x6285783a4e16 in operator* v8/include/cppgc/member.h:258:36 #1 0x6285783a4e16 in blink::Document::UpdateBaseURL() third_party/blink/renderer/core/dom/document.cc:4597:52 #2 0x6285783a22db in blink::Document::Document(blink::DocumentInit const&, base::EnumSet<blink::DocumentClass, (blink::DocumentClass)0, (blink::DocumentClass)7>) third_party/blink/renderer/core/dom/document.cc:918:5 #3 0x6285764452e4 in blink::HTMLDocument::HTMLDocument(blink::DocumentInit const&, base::EnumSet<blink::DocumentClass, (blink::DocumentClass)0, (blink::DocumentClass)7>) third_party/blink/renderer/core/html/html_document.cc:67:7 Original change's description: > SpeculationRules: Use Traversal<HTMLScriptElement> instead of document.scripts() > > It's possible to run Document::UpdateBaseURL() while processing the > removal of elements (ContainerNode::RemovedFrom), but before the > HTMLCollections (like document.scripts()) are invalidated (which > happens in ContainerNode::ChildrenChanged after all removals are > complete). > > Bug: 386547460 > Change-Id: Ifc8036887dad3b999e77b1a014b950b97a20484a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6148370 > Reviewed-by: Jeremy Roman <[email protected]> > Reviewed-by: Mason Freed <[email protected]> > Commit-Queue: Adithya Srinivasan <[email protected]> > Cr-Commit-Position: refs/heads/main@{#1403679} Bug: 386547460 Change-Id: Ibfaa45470d3f303610fdf8ceb4048dc22ea3029f No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6158707 Commit-Queue: Justin Lulejian <[email protected]> Bot-Commit: Rubber Stamper <[email protected]> Owners-Override: Justin Lulejian <[email protected]> Reviewed-by: Adithya Srinivasan <[email protected]> Reviewed-by: Justin Lulejian <[email protected]> Cr-Commit-Position: refs/heads/main@{#1403868}
pull bot
pushed a commit
that referenced
this pull request
Jan 20, 2025
This reverts commit a9e07e0. Reason for reland: Cronet is fixed. Original change's description: > Revert "Reland "JNI Zero: Expose empty String, List, Map as constants"" > > This reverts commit b1dbbe8. > > Reason for revert: blocking webrtc roll. Can reland after fixing cronet > jni_zero renaming see https://crbug.com/353534209 > > Original change's description: > > Reland "JNI Zero: Expose empty String, List, Map as constants" > > > > This reverts commit 8f83623. > > > > Reason for reland: Renaming a target to fix incremental builds > > > > Original change's description: > > > Revert "JNI Zero: Expose empty String, List, Map as constants" > > > > > > This reverts commit e4259e1. > > > > > > Reason for revert: Broke local build > > > > > > Original change's description: > > > > JNI Zero: Expose empty String, List, Map as constants > > > > > > > > AFAICT, ART allocates a new empty string object each time you call > > > > env->NewString*() methods. Same with List and Map. > > > > > > > > To avoid allocations for empty things, use these singletons in > > > > conversion functions. > > > > > > > > This adds a new JavaRef type: LeakedJavaGlobalRef, which is the same as > > > > ScopedJavaGlobalRef, except without a destructor. > > > > > > > > Bug: None > > > > Change-Id: Id87e7e7a8c7a8219e237d15a37ade582768383d0 > > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5645747 > > > > Reviewed-by: Mohamed Heikal <[email protected]> > > > > Commit-Queue: Andrew Grieve <[email protected]> > > > > Owners-Override: Andrew Grieve <[email protected]> > > > > Reviewed-by: Sam Maier <[email protected]> > > > > Cr-Commit-Position: refs/heads/main@{#1319347} > > > > > > Bug: None > > > Change-Id: I101ea04150b33e2c8b9ac857466aa886365aea05 > > > No-Presubmit: true > > > No-Tree-Checks: true > > > No-Try: true > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5656590 > > > Reviewed-by: Mohamed Heikal <[email protected]> > > > Bot-Commit: Rubber Stamper <[email protected]> > > > Owners-Override: Wenyu Fu <[email protected]> > > > Commit-Queue: Henrique Nakashima <[email protected]> > > > Reviewed-by: Wenyu Fu <[email protected]> > > > Cr-Commit-Position: refs/heads/main@{#1319417} > > > > Bug: None > > Change-Id: Ica1c0a14d6eb1027ae8bd674409c0d9f34c768fc > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5662098 > > Owners-Override: Andrew Grieve <[email protected]> > > Commit-Queue: Mohamed Heikal <[email protected]> > > Auto-Submit: Andrew Grieve <[email protected]> > > Commit-Queue: Andrew Grieve <[email protected]> > > Reviewed-by: Mohamed Heikal <[email protected]> > > Cr-Commit-Position: refs/heads/main@{#1320367} > > Bug: 351773023, 353534209 > Change-Id: I71507dd091b3d332c43e094b1ea358669bfe7ae4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5769676 > Reviewed-by: Andrew Grieve <[email protected]> > Auto-Submit: Mohamed Heikal <[email protected]> > Commit-Queue: Andrew Grieve <[email protected]> > Owners-Override: Andrew Grieve <[email protected]> > Cr-Commit-Position: refs/heads/main@{#1338722} Bug: 351773023, 353534209 Change-Id: I1893d044a5ced80dec2c7b96b56c23449bb2dd1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6062739 Commit-Queue: Andrew Grieve <[email protected]> Owners-Override: Andrew Grieve <[email protected]> Reviewed-by: Mohamed Heikal <[email protected]> Cr-Commit-Position: refs/heads/main@{#1408790}
pull bot
pushed a commit
that referenced
this pull request
Jan 23, 2025
- Adds tests for canceling query tasks. - Adds tests for using DB as cache and rebuilding DB. SchedulingEmbedder does two things which are specific to the History Embeddings feature: #1 Canceling stale query passages. #2 Removing non-ascii chars before sending the passages to the embedder. These functionalities need to be factored out before we can use the SchedulingEmbedder in the passage_embeddings:: namespace. This CL adds some tests around those functionalities so future changes don't break things. Adding these tests helped identify three potential bugs. #1 the first query in a series of queries always gets processed, which shouldn't. #2 enabling the feature param for removing non-ascii characters causes a crash when the passage is entirely made up of non-ascii characters. #3 attempting to compute embeddings for an empty passage causes a crash. I'll attempt to address these bugs in follow-up changes. Bug: 390241271 Change-Id: I5002b1fbaf6ea5068da405219ba153cce8378faf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6186446 Code-Coverage: [email protected] <[email protected]> Commit-Queue: Moe Ahmadi <[email protected]> Reviewed-by: Orin Jaworski <[email protected]> Cr-Commit-Position: refs/heads/main@{#1409805}
pull bot
pushed a commit
that referenced
this pull request
Jan 23, 2025
In crrev.com/c/6181046, the following blink::Vector constructors were combined to call blink::Vector::assign: 1. Vector(vector with different inline capacity) 2. Vector(same vector type, projection) 3. Vector(vector with different inline capacity, projection) 4. Vector(range) blink::Vector::assign calls reserve (in GCForbiddenScope) and base::ranges::transform(back_inserter), which has lower performance than the original UinitializedCopy(). Optimizations: - For #1, add back the original code which can use memcpy when possible. - For #2, #3, #4, call a new function TypeOperations::UninitializedTransform() (which is basically equivalent to TypeOperations::UninitializedCopy() before crrev.com/c/6181046, but accepts generic input iterator), instead of assign(). - For assign(), remove GCForbiddenScope [1], and use UninitializedTransform() instead of transform(back_inserter). The differences between this CL and the version before crrev.com/c/6181046 are: - Vector(range) now uses optimized code path; - Vector::assign(range) is optimized. [1] About GCForbiddenScope: It was added to fix crbug.com/40448463. It prevents GC during reserve/resize to prevent the change of the input collection (if it's a hash table with WeakMember keys) during GC. Before that fix, the result vector might contain extra empty elements. With the new code, the size of the result vector is based on the final size of the range, so the original problem no longer exists. The capacity may be larger than necessary in rare cases, which is not a big deal. https://pinpoint-dot-chromeperf.appspot.com/job/16bf9884a10000 shows that removing GCForbiddenScope can improve performance of a benchmark by 5% (though the improvement will not apply with the final CL because the assign() code path is no longer used for that benchmark, which can get a greater improvement). Bug: 390461329 Change-Id: I152218d56ab93c44ca89f3397d96b0b7780edd6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6185833 Reviewed-by: Kentaro Hara <[email protected]> Reviewed-by: Michael Lippautz <[email protected]> Commit-Queue: Xianzhu Wang <[email protected]> Cr-Commit-Position: refs/heads/main@{#1410367}
pull bot
pushed a commit
that referenced
this pull request
Jan 24, 2025
…puts" This reverts commit f58220e. Reason for reland: Disabled test for is_component_build=true Also removed the now unnecessary --collect-inputs-only copy of chrome executable. Original change's description: > Revert "Reland "private_code_test: Parse build.ninja to collect linker inputs"" > > This reverts commit 269acc3. > > Reason for revert: Failing locally: > logging.info('Found %d linker inputs', len(object_paths)) > ^^^^^^^^^^^^^^^^^ > TypeError: object of type 'NoneType' has no len() > build failed > > > Original change's description: > > Reland "private_code_test: Parse build.ninja to collect linker inputs" > > > > This reverts commit 83e7953. > > > > Reason for revert: Adds non-deterministics files to ignorelist > > > > Original change's description: > > > Revert "private_code_test: Parse build.ninja to collect linker inputs" > > > > > > This reverts commit a6dddc3. > > > > > > Reason for revert: Suspected of causing failure in deterministic build - https://ci.chromium.org/ui/p/chromium/builders/ci/Deterministic%20Linux/51954 (https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket/8725202020735429233/+/u/compare_build_artifacts/stdout) > > > > > > Original change's description: > > > > private_code_test: Parse build.ninja to collect linker inputs > > > > > > > > Although slower, this handles the case where GN targets are in public > > > > code, but include source files from private code. > > > > > > > > Bug: 40204298 > > > > Change-Id: If571518f07855946a16e5aeebe0cace661cc75dd > > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5756917 > > > > Commit-Queue: Andrew Grieve <[email protected]> > > > > Reviewed-by: Dirk Pranke <[email protected]> > > > > Cr-Commit-Position: refs/heads/main@{#1408713} > > > > > > Bug: 40204298 > > > Change-Id: I9584a8e46d28ce0f64d263c88d8041cb51368471 > > > No-Presubmit: true > > > No-Tree-Checks: true > > > No-Try: true > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6184083 > > > Bot-Commit: Rubber Stamper <[email protected]> > > > Reviewed-by: Andrew Grieve <[email protected]> > > > Reviewed-by: Dirk Pranke <[email protected]> > > > Commit-Queue: Andrew Grieve <[email protected]> > > > Cr-Commit-Position: refs/heads/main@{#1408751} > > > > Bug: 40204298 > > Change-Id: I330e111f9cf3ca47af8d5c5142d362728a1c429a > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6185547 > > Commit-Queue: Andrew Grieve <[email protected]> > > Reviewed-by: Dirk Pranke <[email protected]> > > Cr-Commit-Position: refs/heads/main@{#1409216} > > Bug: 40204298 > Change-Id: Ia4f3026884ed49606ac337de5f441ade433b9f0e > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6187366 > Bot-Commit: Rubber Stamper <[email protected]> > Owners-Override: Andrew Grieve <[email protected]> > Commit-Queue: Rubber Stamper <[email protected]> > Auto-Submit: Andrew Grieve <[email protected]> > Cr-Commit-Position: refs/heads/main@{#1409266} Bug: 40204298 Change-Id: If2c86c7acf2634520bfe89c0eca26d832ae939f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6194532 Reviewed-by: Dirk Pranke <[email protected]> Commit-Queue: Andrew Grieve <[email protected]> Cr-Commit-Position: refs/heads/main@{#1410508}
pull bot
pushed a commit
that referenced
this pull request
Jan 24, 2025
…inker inputs"" This reverts commit ad1ae9d. Reason for revert: Speculative revert because the original error persists: logging.info('Found %d linker inputs', len(object_paths)) ^^^^^^^^^^^^^^^^^ TypeError: object of type 'NoneType' has no len() Affected bots: arm64-unpublished-builder [58 since first detection] x64-builder [44 since first detection] Deterministic Android [12 since first detection] Original change's description: > Reland #2: "private_code_test: Parse build.ninja to collect linker inputs" > > This reverts commit f58220e. > > Reason for reland: Disabled test for is_component_build=true > > Also removed the now unnecessary --collect-inputs-only copy of > chrome executable. > > Original change's description: > > Revert "Reland "private_code_test: Parse build.ninja to collect linker inputs"" > > > > This reverts commit 269acc3. > > > > Reason for revert: Failing locally: > > logging.info('Found %d linker inputs', len(object_paths)) > > ^^^^^^^^^^^^^^^^^ > > TypeError: object of type 'NoneType' has no len() > > build failed > > > > > > Original change's description: > > > Reland "private_code_test: Parse build.ninja to collect linker inputs" > > > > > > This reverts commit 83e7953. > > > > > > Reason for revert: Adds non-deterministics files to ignorelist > > > > > > Original change's description: > > > > Revert "private_code_test: Parse build.ninja to collect linker inputs" > > > > > > > > This reverts commit a6dddc3. > > > > > > > > Reason for revert: Suspected of causing failure in deterministic build - https://ci.chromium.org/ui/p/chromium/builders/ci/Deterministic%20Linux/51954 (https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket/8725202020735429233/+/u/compare_build_artifacts/stdout) > > > > > > > > Original change's description: > > > > > private_code_test: Parse build.ninja to collect linker inputs > > > > > > > > > > Although slower, this handles the case where GN targets are in public > > > > > code, but include source files from private code. > > > > > > > > > > Bug: 40204298 > > > > > Change-Id: If571518f07855946a16e5aeebe0cace661cc75dd > > > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5756917 > > > > > Commit-Queue: Andrew Grieve <[email protected]> > > > > > Reviewed-by: Dirk Pranke <[email protected]> > > > > > Cr-Commit-Position: refs/heads/main@{#1408713} > > > > > > > > Bug: 40204298 > > > > Change-Id: I9584a8e46d28ce0f64d263c88d8041cb51368471 > > > > No-Presubmit: true > > > > No-Tree-Checks: true > > > > No-Try: true > > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6184083 > > > > Bot-Commit: Rubber Stamper <[email protected]> > > > > Reviewed-by: Andrew Grieve <[email protected]> > > > > Reviewed-by: Dirk Pranke <[email protected]> > > > > Commit-Queue: Andrew Grieve <[email protected]> > > > > Cr-Commit-Position: refs/heads/main@{#1408751} > > > > > > Bug: 40204298 > > > Change-Id: I330e111f9cf3ca47af8d5c5142d362728a1c429a > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6185547 > > > Commit-Queue: Andrew Grieve <[email protected]> > > > Reviewed-by: Dirk Pranke <[email protected]> > > > Cr-Commit-Position: refs/heads/main@{#1409216} > > > > Bug: 40204298 > > Change-Id: Ia4f3026884ed49606ac337de5f441ade433b9f0e > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6187366 > > Bot-Commit: Rubber Stamper <[email protected]> > > Owners-Override: Andrew Grieve <[email protected]> > > Commit-Queue: Rubber Stamper <[email protected]> > > Auto-Submit: Andrew Grieve <[email protected]> > > Cr-Commit-Position: refs/heads/main@{#1409266} > > Bug: 40204298 > Change-Id: If2c86c7acf2634520bfe89c0eca26d832ae939f0 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6194532 > Reviewed-by: Dirk Pranke <[email protected]> > Commit-Queue: Andrew Grieve <[email protected]> > Cr-Commit-Position: refs/heads/main@{#1410508} Bug: 40204298 Change-Id: Idbdbcca4fa4de4b76b3eebc17e0d2145ca582326 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6196857 Commit-Queue: Adem Derinel <[email protected]> Owners-Override: Ivana Žužić <[email protected]> Reviewed-by: Adem Derinel <[email protected]> Auto-Submit: Ivana Žužić <[email protected]> Cr-Commit-Position: refs/heads/main@{#1410842}
pull bot
pushed a commit
that referenced
this pull request
Jan 25, 2025
…puts" This reverts commit 7744204. Reason for reland: Adding missing dep Original change's description: > Revert "Reland #2: "private_code_test: Parse build.ninja to collect linker inputs"" > > This reverts commit ad1ae9d. > > Reason for revert: Speculative revert because the original > error persists: > logging.info('Found %d linker inputs', len(object_paths)) > ^^^^^^^^^^^^^^^^^ > TypeError: object of type 'NoneType' has no len() > > Affected bots: > arm64-unpublished-builder [58 since first detection] > x64-builder [44 since first detection] > Deterministic Android [12 since first detection] > > Original change's description: > > Reland #2: "private_code_test: Parse build.ninja to collect linker inputs" > > > > This reverts commit f58220e. > > > > Reason for reland: Disabled test for is_component_build=true > > > > Also removed the now unnecessary --collect-inputs-only copy of > > chrome executable. > > > > Original change's description: > > > Revert "Reland "private_code_test: Parse build.ninja to collect linker inputs"" > > > > > > This reverts commit 269acc3. > > > > > > Reason for revert: Failing locally: > > > logging.info('Found %d linker inputs', len(object_paths)) > > > ^^^^^^^^^^^^^^^^^ > > > TypeError: object of type 'NoneType' has no len() > > > build failed > > > > > > > > > Original change's description: > > > > Reland "private_code_test: Parse build.ninja to collect linker inputs" > > > > > > > > This reverts commit 83e7953. > > > > > > > > Reason for revert: Adds non-deterministics files to ignorelist > > > > > > > > Original change's description: > > > > > Revert "private_code_test: Parse build.ninja to collect linker inputs" > > > > > > > > > > This reverts commit a6dddc3. > > > > > > > > > > Reason for revert: Suspected of causing failure in deterministic build - https://ci.chromium.org/ui/p/chromium/builders/ci/Deterministic%20Linux/51954 (https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket/8725202020735429233/+/u/compare_build_artifacts/stdout) > > > > > > > > > > Original change's description: > > > > > > private_code_test: Parse build.ninja to collect linker inputs > > > > > > > > > > > > Although slower, this handles the case where GN targets are in public > > > > > > code, but include source files from private code. > > > > > > > > > > > > Bug: 40204298 > > > > > > Change-Id: If571518f07855946a16e5aeebe0cace661cc75dd > > > > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5756917 > > > > > > Commit-Queue: Andrew Grieve <[email protected]> > > > > > > Reviewed-by: Dirk Pranke <[email protected]> > > > > > > Cr-Commit-Position: refs/heads/main@{#1408713} > > > > > > > > > > Bug: 40204298 > > > > > Change-Id: I9584a8e46d28ce0f64d263c88d8041cb51368471 > > > > > No-Presubmit: true > > > > > No-Tree-Checks: true > > > > > No-Try: true > > > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6184083 > > > > > Bot-Commit: Rubber Stamper <[email protected]> > > > > > Reviewed-by: Andrew Grieve <[email protected]> > > > > > Reviewed-by: Dirk Pranke <[email protected]> > > > > > Commit-Queue: Andrew Grieve <[email protected]> > > > > > Cr-Commit-Position: refs/heads/main@{#1408751} > > > > > > > > Bug: 40204298 > > > > Change-Id: I330e111f9cf3ca47af8d5c5142d362728a1c429a > > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6185547 > > > > Commit-Queue: Andrew Grieve <[email protected]> > > > > Reviewed-by: Dirk Pranke <[email protected]> > > > > Cr-Commit-Position: refs/heads/main@{#1409216} > > > > > > Bug: 40204298 > > > Change-Id: Ia4f3026884ed49606ac337de5f441ade433b9f0e > > > No-Presubmit: true > > > No-Tree-Checks: true > > > No-Try: true > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6187366 > > > Bot-Commit: Rubber Stamper <[email protected]> > > > Owners-Override: Andrew Grieve <[email protected]> > > > Commit-Queue: Rubber Stamper <[email protected]> > > > Auto-Submit: Andrew Grieve <[email protected]> > > > Cr-Commit-Position: refs/heads/main@{#1409266} > > > > Bug: 40204298 > > Change-Id: If2c86c7acf2634520bfe89c0eca26d832ae939f0 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6194532 > > Reviewed-by: Dirk Pranke <[email protected]> > > Commit-Queue: Andrew Grieve <[email protected]> > > Cr-Commit-Position: refs/heads/main@{#1410508} > > Bug: 40204298 > Change-Id: Idbdbcca4fa4de4b76b3eebc17e0d2145ca582326 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6196857 > Commit-Queue: Adem Derinel <[email protected]> > Owners-Override: Ivana Žužić <[email protected]> > Reviewed-by: Adem Derinel <[email protected]> > Auto-Submit: Ivana Žužić <[email protected]> > Cr-Commit-Position: refs/heads/main@{#1410842} Bug: 40204298 Change-Id: I0cd0eabe12147264cc58cc54e74e934609548e29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6198819 Auto-Submit: Andrew Grieve <[email protected]> Reviewed-by: Dirk Pranke <[email protected]> Commit-Queue: Andrew Grieve <[email protected]> Cr-Commit-Position: refs/heads/main@{#1411095}
pull bot
pushed a commit
that referenced
this pull request
Jan 27, 2025
Tests revealed an assertion violation. There are no good way to fix it, so we decide to abort the whole rewrite when it happens. This was suggested by @AHijazi in: https://chromium-review.googlesource.com/c/chromium/src/+/6190594 Bug: 356643982 Change-Id: I523e1a17bc69ec39e1bbf52bc922011eeda8eeb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6198858 Auto-Submit: Arthur Sonzogni <[email protected]> Commit-Queue: Ali Hijazi <[email protected]> Reviewed-by: Stephen Nusko <[email protected]> Reviewed-by: Ali Hijazi <[email protected]> Cr-Commit-Position: refs/heads/main@{#1411569}
pull bot
pushed a commit
that referenced
this pull request
Jan 28, 2025
This reverts commit 5b0eb0d. Reason for revert: GlicStatusIconTest.ExecuteCommand test consistently fails on Linux UBSan Tests bot: https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20UBSan%20Tests/ First failure was in this build, the same one where the change landed: https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20UBSan%20Tests/3210/overview The failure is === [ RUN ] GlicStatusIconTest.ExecuteCommand ../../chrome/browser/glic/launcher/glic_status_icon.cc:90:57: runtime error: member call on null pointer of type 'glic::GlicProfileManager' #0 0x5715ce835751 in glic::GlicStatusIcon::ExecuteCommand(int, int) chrome/browser/glic/launcher/glic_status_icon.cc:90:57 #1 0x5715c0d9a3fd in glic::GlicStatusIconTest_ExecuteCommand_Test::TestBody() chrome/browser/glic/launcher/glic_status_icon_unittest.cc:90:17 #2 0x5715ce8a7b3e in testing::Test::Run() third_party/googletest/src/googletest/src/gtest.cc:2728:5 #3 0x5715ce8a9730 in testing::TestInfo::Run() third_party/googletest/src/googletest/src/gtest.cc:2874:11 #4 0x5715ce8abbdb in testing::TestSuite::Run() third_party/googletest/src/googletest/src/gtest.cc:3052:30 #5 0x5715ce8c3418 in testing::internal::UnitTestImpl::RunAllTests() third_party/googletest/src/googletest/src/gtest.cc:6020:44 #6 0x5715ce8c2317 in testing::UnitTest::Run() third_party/googletest/src/googletest/src/gtest.cc:5599:10 #7 0x5715cf9bba9a in base::TestSuite::Run() base/test/test_suite.cc:424:16 #8 0x5715d0b8969e in content::UnitTestTestSuite::Run() content/public/test/unittest_test_suite.cc:190:23 #9 0x5715bf16bcc3 in base::OnceCallback<int ()>::Run() && base/functional/callback.h:156:12 #10 0x5715cf9c5abf in RunTestSuite base/test/launcher/unit_test_launcher.cc:188:38 #11 0x5715cf9c5abf in base::(anonymous namespace)::LaunchUnitTestsInternal(base::OnceCallback<int ()>, unsigned long, int, unsigned long, bool, base::RepeatingCallback<void ()>, base::OnceCallback<void ()>) base/test/launcher/unit_test_launcher.cc:271:10 #12 0x5715cf9c56cf in base::LaunchUnitTests(int, char**, base::OnceCallback<int ()>, unsigned long) base/test/launcher/unit_test_launcher.cc:336:10 #13 0x5715cf9812a4 in main chrome/test/base/run_all_unittests.cc:83:10 #14 0x70e16a829d8f in __libc_start_call_main csu/../sysdeps/nptl/libc_start_call_main.h:58:16 #15 0x70e16a829e3f in __libc_start_main csu/../csu/libc-start.c:392:3 #16 0x5715b77d4029 in _start (/b/s/w/ir/out/fd58-Linux_UBSan_Bui/unit_tests+0x1ff21029) (BuildId: bc8f3031e6d09fe5) SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior ../../chrome/browser/glic/launcher/glic_status_icon.cc:90:57 === Original change's description: > Add unit test for glic status icon > > Bug: 391706417 > Change-Id: I68aca3dd194ca04fd45d1dd94daffda82ca0f77e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6203121 > Commit-Queue: Alison Gale <[email protected]> > Code-Coverage: [email protected] <[email protected]> > Reviewed-by: Erik Chen <[email protected]> > Cr-Commit-Position: refs/heads/main@{#1411859} Bug: 391706417 Change-Id: Ic227009761f576122a2f8e2a102b812fd6a66b2b No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6203514 Bot-Commit: Rubber Stamper <[email protected]> Auto-Submit: Mark Pearson <[email protected]> Commit-Queue: Rubber Stamper <[email protected]> Owners-Override: Mark Pearson <[email protected]> Cr-Commit-Position: refs/heads/main@{#1412018}
pull bot
pushed a commit
that referenced
this pull request
Jan 29, 2025
This reverts commit c1ff9e3. Reason for revert: Land with fixes for failing builder. Only request profile manager when needed Passing run: https://ci.chromium.org/ui/inv/u-agale-2025-01-28-19-50-00-97127e6aff791b32 Note that this doesn't solve the underlying initialization timing of GlobalFeatures but I want to make sure we have some test coverage checked in while investigating that. Original change's description: > Revert "Add unit test for glic status icon" > > This reverts commit 5b0eb0d. > > Reason for revert: > GlicStatusIconTest.ExecuteCommand test consistently fails on Linux UBSan Tests bot: > https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20UBSan%20Tests/ > > First failure was in this build, the same one where the change landed: > https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20UBSan%20Tests/3210/overview > > The failure is > === > [ RUN ] GlicStatusIconTest.ExecuteCommand > ../../chrome/browser/glic/launcher/glic_status_icon.cc:90:57: runtime error: member call on null pointer of type 'glic::GlicProfileManager' > #0 0x5715ce835751 in glic::GlicStatusIcon::ExecuteCommand(int, int) chrome/browser/glic/launcher/glic_status_icon.cc:90:57 > #1 0x5715c0d9a3fd in glic::GlicStatusIconTest_ExecuteCommand_Test::TestBody() chrome/browser/glic/launcher/glic_status_icon_unittest.cc:90:17 > #2 0x5715ce8a7b3e in testing::Test::Run() third_party/googletest/src/googletest/src/gtest.cc:2728:5 > #3 0x5715ce8a9730 in testing::TestInfo::Run() third_party/googletest/src/googletest/src/gtest.cc:2874:11 > #4 0x5715ce8abbdb in testing::TestSuite::Run() third_party/googletest/src/googletest/src/gtest.cc:3052:30 > #5 0x5715ce8c3418 in testing::internal::UnitTestImpl::RunAllTests() third_party/googletest/src/googletest/src/gtest.cc:6020:44 > #6 0x5715ce8c2317 in testing::UnitTest::Run() third_party/googletest/src/googletest/src/gtest.cc:5599:10 > #7 0x5715cf9bba9a in base::TestSuite::Run() base/test/test_suite.cc:424:16 > #8 0x5715d0b8969e in content::UnitTestTestSuite::Run() content/public/test/unittest_test_suite.cc:190:23 > #9 0x5715bf16bcc3 in base::OnceCallback<int ()>::Run() && base/functional/callback.h:156:12 > #10 0x5715cf9c5abf in RunTestSuite base/test/launcher/unit_test_launcher.cc:188:38 > #11 0x5715cf9c5abf in base::(anonymous namespace)::LaunchUnitTestsInternal(base::OnceCallback<int ()>, unsigned long, int, unsigned long, bool, base::RepeatingCallback<void ()>, base::OnceCallback<void ()>) base/test/launcher/unit_test_launcher.cc:271:10 > #12 0x5715cf9c56cf in base::LaunchUnitTests(int, char**, base::OnceCallback<int ()>, unsigned long) base/test/launcher/unit_test_launcher.cc:336:10 > #13 0x5715cf9812a4 in main chrome/test/base/run_all_unittests.cc:83:10 > #14 0x70e16a829d8f in __libc_start_call_main csu/../sysdeps/nptl/libc_start_call_main.h:58:16 > #15 0x70e16a829e3f in __libc_start_main csu/../csu/libc-start.c:392:3 > #16 0x5715b77d4029 in _start (/b/s/w/ir/out/fd58-Linux_UBSan_Bui/unit_tests+0x1ff21029) (BuildId: bc8f3031e6d09fe5) > > SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior ../../chrome/browser/glic/launcher/glic_status_icon.cc:90:57 > === > > Original change's description: > > Add unit test for glic status icon > > > > Bug: 391706417 > > Change-Id: I68aca3dd194ca04fd45d1dd94daffda82ca0f77e > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6203121 > > Commit-Queue: Alison Gale <[email protected]> > > Code-Coverage: [email protected] <[email protected]> > > Reviewed-by: Erik Chen <[email protected]> > > Cr-Commit-Position: refs/heads/main@{#1411859} > > Bug: 391706417 > Change-Id: Ic227009761f576122a2f8e2a102b812fd6a66b2b > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6203514 > Bot-Commit: Rubber Stamper <[email protected]> > Auto-Submit: Mark Pearson <[email protected]> > Commit-Queue: Rubber Stamper <[email protected]> > Owners-Override: Mark Pearson <[email protected]> > Cr-Commit-Position: refs/heads/main@{#1412018} Bug: 391706417 Change-Id: Ia23f037231fdfb0dcf6bbde8262f0257fc3af0d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6207131 Commit-Queue: Alison Gale <[email protected]> Reviewed-by: Erik Chen <[email protected]> Cr-Commit-Position: refs/heads/main@{#1412571}
pull bot
pushed a commit
that referenced
this pull request
Jan 29, 2025
This reverts commit fda25ea. Reason for revert: Broke msan tests https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests/49651 [ RUN ] DiskCacheEntryTest.SparseReadLength0 Uninitialized bytes in pwrite64 at offset 22 inside [0x728000028000, 1046) ==306877==WARNING: MemorySanitizer: use-of-uninitialized-value #0 0x5555619ee0ea in base::File::Write(long, char const*, int) ./../../base/files/file_posix.cc:378:10 #1 0x5555614825d2 in Write ./../../net/disk_cache/blockfile/file_posix.cc:60:13 #2 0x5555614825d2 in disk_cache::File::Write(void const*, unsigned long, unsigned long, disk_cache::FileIOCallback*, bool*) ./../../net/disk_cache/blockfile/file_posix.cc:95:12 #3 0x555560d19451 in disk_cache::EntryImpl::Flush(int, int) ./../../net/disk_cache/blockfile/entry_impl.cc:1484:14 #4 0x555560d17f21 in disk_cache::EntryImpl::~EntryImpl() ./../../net/disk_cache/blockfile/entry_impl.cc:954:15 #5 0x555560d1979d in disk_cache::EntryImpl::~EntryImpl() ./../../net/disk_cache/blockfile/entry_impl.cc:929:25 Original change's description: > SimpleCache: don't check on some empty ReadSparseData reads > > Bug: 392690731 > Change-Id: I80c093972012d6364cecaef6bd8eedcbf6ace6b2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6207149 > Reviewed-by: Adam Rice <[email protected]> > Commit-Queue: Maks Orlovich <[email protected]> > Cr-Commit-Position: refs/heads/main@{#1412904} Bug: 392690731 Change-Id: I8e7e2766dcebc7b5f023a2d2b9eb2df00ac8399c No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6214791 Bot-Commit: Rubber Stamper <[email protected]> Owners-Override: Avi Drissman <[email protected]> Auto-Submit: Avi Drissman <[email protected]> Commit-Queue: Avi Drissman <[email protected]> Cr-Commit-Position: refs/heads/main@{#1412996}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )