Skip to content

Commit

Permalink
Fix test result
Browse files Browse the repository at this point in the history
  • Loading branch information
@jarun
jarun committed Aug 6, 2018
1 parent 0347504 commit bf48169
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion tests/test_buku.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -533,7 +533,7 @@ def test_sigint_handler(capsys):
(
'Samsung GT-I5800 Galaxy 580 - Обсуждение - 4PDA',
'Samsung GT-I5800 Galaxy 580 - Обсуждение - 4PDA',
'Samsung GT-I5800 Galaxy 580 - Обсуждение - 4PDA',
None,
0, 0
)
],
Expand Down

4 comments on commit bf48169

@jarun
Copy link
Owner Author

@jarun jarun commented on bf48169 Aug 6, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rachmadaniHaryono Travis CI takes very long to finish since we added description and tag fetch. Is it possible to check which tests are actually taking this long and why?

I am not sure if it's just because of using bs4... does search take longer because of extended desc?

We can still optimize by omitting desc which match titles.

@jarun
Copy link
Owner Author

@jarun jarun commented on bf48169 Aug 6, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be great if we cna profile the time for each test (anything available from the framework?) and then analyze case by case.

@rachmadaniHaryono
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also have no idea about the long test

But I create pr for that test profile see #301 for first discussion about this and
#303 for actual pr

@jarun
Copy link
Owner Author

@jarun jarun commented on bf48169 Aug 7, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Please sign in to comment.