Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for new feature #301

Merged
merged 10 commits into from
Aug 6, 2018
Merged

fix for new feature #301

merged 10 commits into from
Aug 6, 2018

Conversation

rachmadaniHaryono
Copy link
Collaborator

@rachmadaniHaryono rachmadaniHaryono commented Aug 6, 2018

e:

  • add html5lib package
  • simplify test
  • remove unused test
  • update based on new feature

@jarun
Copy link
Owner

jarun commented Aug 6, 2018

👍

@rachmadaniHaryono
Copy link
Collaborator Author

rachmadaniHaryono commented Aug 6, 2018

this only fix test, but not test the new feature extensively.

not sure what the cause but isn't the test take too long?

based on this rachmadaniHaryono@f6cbbe8 here are slow tests

124.81s call     tests/test_bukuDb.py::test_delete_rec_range_and_delay_commit
61.51s call     tests/test_bukuDb.py::TestBukuDb::test_search_by_multiple_tags_search_all
61.49s call     tests/test_bukuDb.py::TestBukuDb::test_add_rec
61.41s call     tests/test_bukuDb.py::TestBukuDb::test_search_by_multiple_tags_search_any
61.38s call     tests/test_bukuDb.py::TestBukuDb::test_search_keywords_and_filter_by_tags
61.36s call     tests/test_bukuDb.py::TestBukuDb::test_search_by_tags_exclusion
61.32s call     tests/test_bukuDb.py::TestBukuDb::test_get_rec_id
61.25s call     tests/test_bukuDb.py::TestBukuDb::test_append_tag_at_index
61.24s call     tests/test_bukuDb.py::TestBukuDb::test_searchdb
61.24s call     tests/test_bukuDb.py::test_delete_rec_on_non_interger[a-a-1-True]
61.24s call     tests/test_bukuDb.py::TestBukuDb::test_suggest_tags
61.23s call     tests/test_bukuDb.py::TestBukuDb::test_delete_tag_at_index
61.23s call     tests/test_bukuDb.py::TestBukuDb::test_append_tag_at_all_indices
61.22s call     tests/test_bukuDb.py::TestBukuDb::test_replace_tag
61.22s call     tests/test_bukuDb.py::test_delete_rec_index_and_delay_commit
61.21s call     tests/test_bukuDb.py::test_compactdb
61.21s call     tests/test_bukuDb.py::TestBukuDb::test_get_rec_by_id
61.20s call     tests/test_bukuDb.py::TestBukuDb::test_search_by_tag
61.20s call     tests/test_bukuDb.py::TestBukuDb::test_search_and_open_in_broswer_by_range
61.19s call     tests/test_bukuDb.py::TestBukuDb::test_search_and_open_all_in_browser
60.33s call     tests/test_bukuDb.py::test_print_rec_hypothesis
14.83s call     tests/test_bukuDb.py::test_browse_by_index

e: imo this task should be added to todo list

e2: no update on changelog yet, because i haven't review all commits

This was referenced Aug 6, 2018
@jarun
Copy link
Owner

jarun commented Aug 6, 2018

imo this task should be added to todo list

Sure, please go ahead and add it.

@jarun jarun merged commit c0400c7 into jarun:master Aug 6, 2018
@jarun
Copy link
Owner

jarun commented Aug 6, 2018

Thanks for taking care of this!!!

@rachmadaniHaryono rachmadaniHaryono deleted the feature/pytest branch August 6, 2018 13:43
@github-actions github-actions bot locked and limited conversation to collaborators Jun 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants