toggle inlinehelp in jem settings #1587
Comments
jojo12
added
bug
|
I have the same issue in edit event view (backend). When the button move to the right, disappear (by 'd-none' class ). I have to debug it. |
|
Add inlinehelp button to FormView: "This pull request has been automatically rebased to 5.0-dev. No new features will be merged into Joomla! 4.3 series. Joomla! 4.4 series is a bridge release to make migration from Joomla! 4 to 5 as smooth as possible." See joomla/joomla-cms#39073 |
|
\media\system\js\inlinehelp.min.js is javascript to add 'd-none' class and hidden the bottom. |
|
Ok, but why this is working in com_config and in modules since JL4.1? |
|
I don't know, but it doesn't work. There are alot issues about this button ( joomla/joomla-cms#37819, joomla/joomla-cms#37917, joomla/joomla-cms#37849, joomla/joomla-cms#39073, joomla/joomla-cms#35610) In my debugger of javascript .... If I rename \media\system\js\inlinehelp.min.js file (not load and load inlinehelp.js) .... the 'Toggle Inline Help' buttom appears but It doesn't work. |
|
Thank for your researches. In this case I am not very happy with the responsable makers of Joomla (not with you :-) ). The guided tours isn't the better way. |
|
Alternative, prepare help pages in the JEM web. |
|
yes, I've seen. (but I think, this could be for 4.01. |
|
I have installed JEM 4.0 rc1 in Joomla 5.0.0 alfa1 with PHP 8.2 (with small version change into pkg_jem_v4.0rc1\pkg_jem\packages\com_jem.zip\com_jem\script.php to 5.1.0) and JEM works. |
|
Nothing, it doesn't work.
|
|
This isn't going to work, because in JEM views, the fields are showing with getLabel and getInput, but 'Toggle Inline Help buttom' works when the fields are generate by renderField layout (use LayoutHelper::render). This is the problem, there are to change all JEM views to use 'Toggle Inline Help buttom'. And I have doubts that it is a final solution in JL5.0 I'll think to find alternative workaround without change all view code (when the field has a description in xml file)
|
|
I think that I have found the way. |
Change getLabel and getInput for renderfield. This commit is a test, if it works, we can export other views and tabs.
|
When you have time check these two commits of this issue. Tested in JL 4.3.2 & JL 5.0.0a1
If we approve this change, we must add the styles (css) of the fields. I think it's a simple solution to adapt. |
|
yes it works: the toggle is visible and when clicking on it, the text under the field appears. It is the label. Now it only needs to finde the desc of the label. |
|
All field descriptions are in \administrator\components\com_jem\models\forms*.xml (JEM views in backend) |
|
exact! ;-) |
|
I tried in settings basiclayout. It works there too! |
Change getLabel and getInput for renderfield. This commit is a test, if it works, we can export other views and tabs.
Active Toggle Inline Help in other backend views: category, group, venues, setting.
|
See commit above. Active Toggle Inline Help in other backend views: category, group, venues, setting. |
|
@Heklaterriol See this branch https://github.com/jemproject/JEM-Project/tree/active-help and last commits. |
this file was missing from last commit about inlinehelp.
|
I like the specific help too: it links directly to the right JEM help page! |
|
But the user already has JEM-Help to see internally this static content as first resource, I think, that we can add this help button to redirect the user to external help on the JEM web (dynamic content or the help updater and extender). On the other hand:
Other extensions (Akeeba, Phoca, JCE, Acymailing, ....) has documentation on their website. Google indexes these pages and the users find help about JEM. The official documentation is the reference how Joomla does too or other event managers extension. What is better (internal or external)? |
|
You're right. Better would be both! |
|
Yes, good points mckillo! Both would be excellent. For the name I would simply refer to JEM4 (to avoid misunderstandings with Joomla4) So as URLs": www.joomlaeventmanager.net/documentation/JEM4/backend/ Agree? |
|
Yes, I agree, but as url is better in lower case /jem4/, so if there are others extension .... can be differentiated ... who knows :-) |
|
There will be to define the design style of content, I proposal to create a fisrt article (real example) to define the template for all help article, for example:
|
|
I'm not too keen to use yet another component (Phoca Documentation like you proposed). Actually, Phoca Download is one of the more complicated components to upgrade the site from Joomla3 to 4. I think the documentation can be completed with with just Joomla articles and a menu structure. For most things we do I always check with Kunena and see how they solve it. Actually, they also use articles, but their documentation contains more than just the help files. Look at this: Their help is only onder item 9 in the list: Manual. So I will set up the menu like you proposed onder Documentation. I propose to add "help" or "manual' after "jem4" for those items that will be linked from component. |
|
I only agree with Joomla (my reference/proposal was for Phoca Documentation for J4, it isn't component, not table, only content template override), but I don't remember that JEM website is in J3. It's good example of Kukena (9.Manual for backend and frontend). And yes, all urls with backend will be linked from the help button. |
|
All articles have been created. You can see them when logged in the site: a top menu item "documentation" appears. |
|
Perfect, I'm on it |
|
Please not the extra "manual" I had to add to the URL. And I just added a third navigation menu (all 3 are on the right hand side). Personally I prefer number 2, but curious for your opinion... |
|
Ok I wait that you finish it. |
|
Well, just tell me which you prefer |
|
Option 2 too, white and colapse is clear and clean. But add +1or +2 size letter, in mobile is some little. |
|
I agree to mckillo option 2 |
|
Done. Changing the font size (currently 12) into something bigger messes up the layout of the module. (I tested in Firefox). Also added some articles under the general info ("basics") about system requirements, installation and upgrading (Jojo, i stole the text from your forum post). |
|
well done!😉 |
|
rubber? |
|
Robber, my english, sorry |
|
I like it ... tomorrow I'll update the inline-help branch with the new link help button. |
|
OK. Meanwhile I have set the the documentation area to public viewing |
|
you can see the documentation, but it's written "You are not authorised to view this resource." |
|
@ernst67 Me too, same error. See PM. |
|
@mckillo |
|
it works, can this be closed? |
|
Yes, the inline help was included in the request-answer branch. All urls for Documentation (website) are in code now (v.4.0.1). |
see items #1338 and #1339 too.
I tried with these articles. now I see very short time the toggle and then it disappears.
Would be good to have it visible and enabled.
[by the way: there are a lot of description who aren't useful, because they say the same as the label. But only if you can make them visible, it is good to write better texts".]
The text was updated successfully, but these errors were encountered: