Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new organisation of JEM general settings #1871

Closed
jojo12 opened this issue Dec 4, 2024 · 14 comments
Closed

new organisation of JEM general settings #1871

jojo12 opened this issue Dec 4, 2024 · 14 comments
Labels
bug Something isn't working change fixed Have a commit with the solution.
Milestone

Comments

@jojo12
Copy link
Contributor

jojo12 commented Dec 4, 2024

The organisation of JEM general settings is not so clear:
There is a tab "event page". You have there "venues" too. And there is "venues" in "Global Parameters" in the bottom of the page.
But you have to find out the difference by yourself

"Venues" in "Event Page" is only the addition of "Venue" inside the "Event Detail view"
"Venues" in "Global Parameters" is only for the "Venue Detail view"

As user I would propose to create an additional Tab "Venue Page" and move the part in "Global Parameters" into this Tab.

@jojo12 jojo12 added the change label Dec 4, 2024
@mckillo
Copy link
Collaborator

mckillo commented Dec 4, 2024

This is simple, ony change xml file. Tell me the draft that you woild like to have.

@jojo12
Copy link
Contributor Author

jojo12 commented Dec 4, 2024

settingspage

@jojo12
Copy link
Contributor Author

jojo12 commented Dec 4, 2024

I posted the draft here. Strange! Why it is away?
EDIT: strange! After posting above comment, it came back!

@mckillo
Copy link
Collaborator

mckillo commented Dec 7, 2024

I understand that:

  1. Create a new tab called 'Venue Page'.
  2. Move Global Parameters-Venues to the left side of the new Venue Page.
  3. Move Global Parameters-Edit event under Global Parameters-Advanced Parameters (on the right side)
  4. Move Global Parameters-Edit venue under Global Parameters-Edit event (on the right side)

Is that correct?

@jojo12
Copy link
Contributor Author

jojo12 commented Dec 7, 2024

No:
Move global parameters>Recurrence events to the right under dvanced parameters
And Edit venues to the left under Edit Events

@mckillo
Copy link
Collaborator

mckillo commented Dec 21, 2024

OK. I understood it:

Create a new tab called 'Venue Page'.
Move Global Parameters-Venues to the left side of the new Venue Page.
Move Global Parameters-Recurrence event under Global Parameters-Advanced Parameters (on the right side)
Move Global Parameters-Edit venue under Global Parameters-Edit event (on the left side)

See next commit.

@mckillo mckillo added the fixed Have a commit with the solution. label Dec 21, 2024
@jojo12
Copy link
Contributor Author

jojo12 commented Dec 21, 2024

fine.
Are there others which should be changed?
If not : can be closed

@mckillo
Copy link
Collaborator

mckillo commented Dec 21, 2024

If you want to change one more...tell me. For me it's ok.

@jojo12 jojo12 removed the fixed Have a commit with the solution. label Dec 27, 2024
@jojo12
Copy link
Contributor Author

jojo12 commented Dec 27, 2024

Now the Layout settings should be ordered like it is in views!
New order: Date, Title, Venue, City, County, Category, Attendees, Eventimage
Eventimage at the end, because this is not in all views!
I think, this should be easy.

@mckillo
Copy link
Collaborator

mckillo commented Dec 29, 2024

In this case, the first fieldset needs to be separated.

image

and title could be changed to 'Table' or 'Events table', do you agree?

@mckillo
Copy link
Collaborator

mckillo commented Dec 29, 2024

Currently, this tab does not display the secondary options if the field is set to 'YES' to show them. I have updated this so that if the field is set to 'YES,' the secondary options are displayed. If the admin changes the field from 'YES' to 'NO,' the value field is reset, as it is now.

mckillo added a commit that referenced this issue Dec 29, 2024
@mckillo
Copy link
Collaborator

mckillo commented Dec 29, 2024

The new order was also applied.

@mckillo mckillo added the fixed Have a commit with the solution. label Dec 29, 2024
@jojo12 jojo12 added the bug Something isn't working label Dec 30, 2024
@jojo12
Copy link
Contributor Author

jojo12 commented Dec 30, 2024

There is a problem on new venue page! see #1878

@mckillo
Copy link
Collaborator

mckillo commented Dec 30, 2024

The #1878 was fixed.

@jojo12 jojo12 closed this as completed Jan 11, 2025
@mckillo mckillo added this to the JEM 4.3.2 milestone Jan 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working change fixed Have a commit with the solution.
Projects
None yet
Development

No branches or pull requests

2 participants