Problem on new Jem settings>venue page

[jojo12]

There are two settings which seems to be the same:
Event page>Venues and Venue page!

The venue settings in Event page define, how it looks in Event page detail view (at the end of the events, there is the locality.
Meanwhile the settings in Venue page, define how it looks in the separate Venue page detail view!

It seems, that now these settings are the same!

[mckillo]

Sorry, I didn't delete the old template in the event page tab. See the commit with the fix.

[jojo12]

No, there is a misunderstanding!
Sometimes you want venue details on event details view. This settings are in Event Page setting.
But sometimes you want venue details only on venue details view. This settings are in Venue Page setting.
Important: This settings can be different!!! Like there were before!

[mckillo]

But they are the same lines 444 =454:
<?php echo $this->loadTemplate('evvenues'); ?>
Then the error is before, there is to change the template name.

[mckillo]

Previously, there was no venue tab setting; the venue setting was located in global parameters tab.
I have to implement a new template for venue setting tab (global). I do it...

[mckillo]

Please test it. I believe I have already fixed it.

[jojo12]

not yet:
in global parameters there are now 2 titles without content: "Edit events" and "Edit venues". I think, you took them without titles to "venue page". But this isnt's so logic, because they are special editor pages, for this I think they are better in global parameters.
(the admin has to decide, if only own venues are proposed in editor form, and how many custom fields are used in editor form or for events or for venues.)

[mckillo]

Here you are.
Let's end the year with this completed.
Happy New Year!!!

[jojo12]

Happy New Year too!
But there is something, you perhaps never remarked:
There's a reason that there is two times the setting for maps: one is the map in event detail view and there is an other setting for venue detail view.
Like that, you can use e.g. google route planner on one view and openstreetmap on other view.

With your changes, you made the two views identical. Then you can't set two different views!

EDIT: The lines seem to be the same, that's right,
but the relevant field in event part it is e.g. event_show_mapserv
and the relevant field in venue part is e.g. global_show_mapserv

[jojo12]

Some changes to clarify in general JEM settings:

Event page →
COM_JEM_SETTING_EVENT_PART =»Event Part» instead of COM_JEM_EVENTS
COM_JEM_SETTING_VENUE_PART =»Venue Part» instead of COM_JEM_VENUES
Venue page →
COM_JEM_VENUE_DETAIL =»VenueView» instead of COM_JEM_VENUES

[jojo12]

only on Venue Page: remove «LINK to Venue (page)» ->Nonsense: because you are just on Venue page)

[jojo12]

#1877

[mckillo]

I think that I have undestand your indication.
For Settings - Event Page tab:

For Settings - Venues Page tab:

If they are correct, please tell me the content for these strings or confirm if they are correct:

COM_JEM_SETTING_EVENT_PART="Event"
COM_JEM_SETTING_VENUE_PART="Venue in event"
COM_JEM_VENUE_DETAIL="Venue Setting"

[mckillo]

I think that the tags should be the following to have the same nommenclature of the jem.ini (BE):
COM_JEM_SETTINGS_EVENT_PART="Event"
COM_JEM_SETTINGS_VENUE_PART="Venue in event"
COM_JEM_SETTINGS_VENUE_DETAIL="Venue Setting"

[mckillo]

See the commit, you can update the string if there are to change them. I hope I got it right.