Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frontend event description will not be saved #1891

Closed
jojo12 opened this issue Jan 22, 2025 · 24 comments
Closed

Frontend event description will not be saved #1891

jojo12 opened this issue Jan 22, 2025 · 24 comments
Labels
fixed Have a commit with the solution. proposal testing needed

Comments

@jojo12
Copy link
Contributor

jojo12 commented Jan 22, 2025

When I write in frontend editevent an event description and save it, it is not shown in frontend event detail view nor in backend event.

(When I write in backend event an event description it is always shown.)
(the editvenue part has no problems!)

@jojo12 jojo12 added bug Something isn't working releaseblocker labels Jan 22, 2025
@jojo12 jojo12 added this to the JEM 4.3.2 milestone Jan 22, 2025
@jojo12 jojo12 added testing needed and removed bug Something isn't working releaseblocker labels Jan 23, 2025
@mckillo
Copy link
Collaborator

mckillo commented Jan 23, 2025

I can't reproduce it. You can upload de setting event, I suppose that I don't have any special data of the setting.

@mckillo
Copy link
Collaborator

mckillo commented Jan 23, 2025

Sorry, I have to read it again and now, I get it.

In the recurrence review, an improvement was implemented to allow the generation of recurring events with series, specifically for the case of registering users either to a single event in the series or to all events. However, inheritance for editing content is not yet implemented.

Previously, if you wanted to edit an event, the entire series was deleted (resulting in data loss, especially if users were registered) and then rewritten with the changes. This behavior was disabled to prevent data loss, and now changes can be made to recurring events without having to delete or rewrite the entire series of events.

What you (and I) want is to apply content inheritance (at least for content-related data such as title, description, and others). This feature has not existed yet, and it still doesn’t. I mentioned in a post on another issue that we need to implement a checkbox for each event to indicate whether the inheritance of the series is broken. This will help determine which events are modified compared to the first (if they have been edited).

I have noted this as part of the second phase of the recurrence review, but it’s a complex topic that requires significant testing. It will take time, but it will come.

@mckillo
Copy link
Collaborator

mckillo commented Jan 23, 2025

Change Bug to Proposal: Enhancement of Recurrence Event Functionality

@mckillo
Copy link
Collaborator

mckillo commented Jan 23, 2025

Let me review it to see if I can adjust and resolve it since I had some changes in mind for it, but I hadn't gotten around to working on it yet.

@jojo12 jojo12 removed this from the JEM 4.3.2 milestone Jan 23, 2025
@mckillo
Copy link
Collaborator

mckillo commented Jan 23, 2025

@jojo please test it, I don't have more time today and I have done some basic test and it works.

@mckillo mckillo added the fixed Have a commit with the solution. label Jan 23, 2025
@jojo12 jojo12 removed the fixed Have a commit with the solution. label Jan 23, 2025
@jojo12
Copy link
Contributor Author

jojo12 commented Jan 23, 2025

My thumb up was only to say, I'll test it.

@mckillo: I tested:
if series:
when I use root event icon in series, the event description written in editevent is saved and visible in both frontend and backend.
SERIES--> EDIT ROOT EVENT =working

BUT when I use event icon child button, the event description written in editevent is not saved and not visible in both frontend and backend.
SERIES--> EDIT EVENT = not working

if single event: there's no problem to edit event description in frontend
SINGLE--> EDIT EVENT = working

actually I only tested event description

@jojo12 jojo12 added bug Something isn't working proposal and removed bug Something isn't working labels Jan 23, 2025
@mckillo
Copy link
Collaborator

mckillo commented Jan 23, 2025

I think that it's solved, test it.

@mckillo mckillo added the fixed Have a commit with the solution. label Jan 23, 2025
@mckillo
Copy link
Collaborator

mckillo commented Jan 23, 2025

Example: There is a series of events with 3 recurrences.

If I want to change the description of the third event, I can do so without breaking the series.
Later, if I want to change the time (or another field) of the second event, I can also make that change without breaking the series.

However, if I change the description of the first event, the updated description will be copied to all events in the series. This will overwrite any changes previously made to the description of the third event, but it will not affect the time changes made to the second event. In this case, only the modified field in the first event (the description) is propagated to the series

@mckillo
Copy link
Collaborator

mckillo commented Jan 24, 2025

This last commit is only to clean up echo statements and update the comments.

@jojo12 jojo12 added bug Something isn't working and removed fixed Have a commit with the solution. labels Jan 24, 2025
@jojo12
Copy link
Contributor Author

jojo12 commented Jan 24, 2025

you wrote:

Example: There is a series of events with 3 recurrences.

If I want to change the description of the third event, I can do so without breaking the series.

This doesn't work!

TO REPRODUCE THE PROBLEM:

(in Frontend) I create a serie of 3 events ("Testevent"). They are repeated dayly. They have not yet a event description --> ok
They are visible in frontends eventlist and in backend events. --> ok
When I open all this 3 events to the event details view, I don't see the event description. This is right, because there is nothing in the event description. This is the same in backend as in frontend.

(Now in Frontend) I open the 2nd event (with the second button, "edit event"). I write into the event description field something like "changes in the second event". I then save the changings.

With the changing the view goes directly to the event detail view of this 2nd event. But there is NO event description. -->NOT OK
I control this with opening the event in backend events. There is NO event description. --> NOT OK.

This test is made in RESPONSIVE. Until now I don't know if this works in LEGACY.
EDIT: I tested in LEGACY too. The same problem!

@mckillo
Copy link
Collaborator

mckillo commented Jan 24, 2025

Are you sure the commits have been applied? For me, your test is working; I can see the description in the 2nd event.

Image

When you change the 2nd event, do you see any message confirming the change?

If you change the description of the 2nd event from the backend, can you see the updated description?

If the commits are applied, I have no idea. Could there be any JEM setting or menu setting affecting this view?

@jojo12
Copy link
Contributor Author

jojo12 commented Jan 24, 2025

from frontend: the message is "Item saved"

Ah, I see: When I try to change the event description of the 2nd event from backend. I doesn't work!

EDIT: in addition the text ATTENTION is not working as it says.

This event is part of a set of recurring events. If you save this event, it will be removed from this set, even if you just save it without editing at all.
If you choose any recurrence in this event, a new set of recurring events will be created.

The event persists to be part of the serie the series icon and the text continues to be there!

Image

@jojo12
Copy link
Contributor Author

jojo12 commented Jan 24, 2025

when I change event description using ROOT EVENT, then the answer is

The event has been successfully updated in the following fields: introtext [ID:532]
The event has been successfully updated in the following fields: introtext [ID:533]
The event has been successfully updated in the following fields: introtext [ID:534]

@jojo12
Copy link
Contributor Author

jojo12 commented Jan 24, 2025

Image

@mckillo
Copy link
Collaborator

mckillo commented Jan 24, 2025

If you change the description of the event and only see 'Item saved' (in the front-end), then the commit isn't applied. I've updated the commit again, reviewing the comments and doing some refactoring.

@mckillo
Copy link
Collaborator

mckillo commented Jan 24, 2025

That is right, good. But in this capture, you don't display the description, You can check in the database the introtext for these events.

@mckillo
Copy link
Collaborator

mckillo commented Jan 24, 2025

What type of JEM menu are you using to view this event?

@jojo12
Copy link
Contributor Author

jojo12 commented Jan 24, 2025

commit #[33969f2] i working!

it says:

The event has been successfully updated in the following fields: introtext [ID:534]
success
Item saved.

@jojo12
Copy link
Contributor Author

jojo12 commented Jan 24, 2025

Yippieyeah!!!

@jojo12 jojo12 added fixed Have a commit with the solution. and removed bug Something isn't working labels Jan 24, 2025
@mckillo
Copy link
Collaborator

mckillo commented Jan 24, 2025

NOw, I believe this commit provides greater flexibility for recurring events and more control over custom settings within the event series, without breaking the structure, and the admin/creator can restore/update a field from the root event.

@mckillo
Copy link
Collaborator

mckillo commented Jan 24, 2025

Don't change recurrence, neither start date in the root .... because in this case, the recurrence is deleted and create new! (old method will be actived)

@mckillo
Copy link
Collaborator

mckillo commented Jan 24, 2025

If you give your approval, this issue will be resolved and can be closed.

@mckillo mckillo added bug Something isn't working and removed bug Something isn't working labels Jan 24, 2025
@jojo12
Copy link
Contributor Author

jojo12 commented Jan 24, 2025

YEs can be closed

Sorry, this issue was hard work! Uff

@jojo12 jojo12 closed this as completed Jan 24, 2025
@mckillo
Copy link
Collaborator

mckillo commented Jan 24, 2025

I agree ... was hard. One thing less.
Thanks for your testing. Good job!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fixed Have a commit with the solution. proposal testing needed
Projects
None yet
Development

No branches or pull requests

2 participants