Replace heavyweight aws-java-sdk with fine-grained plugin #238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jglick
reviewed
Oct 4, 2021
jglick
reviewed
Oct 5, 2021
| <artifactId>aws-java-sdk</artifactId> | ||
| <version>1.12.70</version> | ||
| <groupId>org.jenkins-ci.plugins.aws-java-sdk</groupId> | ||
| <artifactId>aws-java-sdk-minimal</artifactId> |
There was a problem hiding this comment.
Maybe I am missing something. Why is this entry, without a version, even here in dependencyManagement? It has no effect on Plugin-Dependencies, which lists only aws-credentials and aws-global-configuration, so we are picking up the actual SDK plugin dep only transitively, right?
[INFO] io.jenkins.plugins:artifact-manager-s3:hpi:1.16-SNAPSHOT
[INFO] +- io.jenkins.plugins:aws-global-configuration:jar:1.7:compile
[INFO] | \- org.jenkins-ci.plugins.aws-java-sdk:aws-java-sdk-minimal:jar:1.12.70:compile
[INFO] | +- com.amazonaws:aws-java-sdk-core:jar:1.12.70:compile
[INFO] | | +- software.amazon.ion:ion-java:jar:1.0.2:compile
[INFO] | | +- com.fasterxml.jackson.dataformat:jackson-dataformat-cbor:jar:2.12.3:compile
[INFO] | | \- joda-time:joda-time:jar:2.10.12:compile
[INFO] | +- com.amazonaws:aws-java-sdk-s3:jar:1.12.70:compile
[INFO] | | +- com.amazonaws:aws-java-sdk-kms:jar:1.12.70:compile
[INFO] | | \- com.amazonaws:jmespath-java:jar:1.12.70:compile
[INFO] | +- com.amazonaws:aws-java-sdk-sts:jar:1.12.70:compile
And why is S3 a dep of the “minimal” plugin? This is a specific service. I would have expected it to be bundled in some aws-java-sdk-s3 plugin.
There was a problem hiding this comment.
See jenkinsci/aws-java-sdk-plugin#540 for context.
There was a problem hiding this comment.
Correct, it should be removed from depMgmt.
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Downstream of