-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace aws-java-sdk with fine-grained plugin #20
Conversation
@jglick could you review this? |
<groupId>com.fasterxml.jackson.core</groupId> | ||
<artifactId>jackson-databind</artifactId> | ||
<version>2.11.1</version> | ||
<!-- fix upper bound --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is this for? Something we can address in bom
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
enforcer error without it is
Require upper bound dependencies error for joda-time:joda-time:2.8.1 paths to dependency are:
+-io.jenkins.plugins:aws-global-configuration:1.7-SNAPSHOT
+-org.jenkins-ci.plugins.aws-java-sdk:aws-java-sdk-minimal:1.12.70
+-com.amazonaws:aws-java-sdk-core:1.12.70
+-joda-time:joda-time:2.8.1
and
+-io.jenkins.plugins:aws-global-configuration:1.7-SNAPSHOT
+-io.jenkins.configuration-as-code:test-harness:1.52
+-com.github.erosb:everit-json-schema:1.13.0
+-com.damnhandy:handy-uri-templates:2.1.8
+-joda-time:joda-time:2.10.2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, so I think we need to add at least aws-java-sdk-minimal
to the bom
.
Downstream PR of