Allow to create the S3 bucket from the configuration page, #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed to have permissions to create a S3 Bucket
jglick
approved these changes
Jun 27, 2018
| public Bucket createS3Bucket(String name) throws IOException { | ||
| AWSStaticCredentialsProvider credentialsProvider = new AWSStaticCredentialsProvider(sessionCredentials()); | ||
| AmazonS3 client = getAmazonS3ClientBuilder().withCredentials(credentialsProvider).build(); | ||
| return client.createBucket(name); |
There was a problem hiding this comment.
Does this actually throw IOException in case of trouble, or RuntimeExceptions?
I suppose it does not matter since the caller catches Throwable, but you might want to adjust the Javadoc to make it clearer.
There was a problem hiding this comment.
sessionCredentials throws an IOException, createBucket throws some runtime exceptions, I have explained it on the javadoc
| } catch (Throwable t){ | ||
| String msg = processExceptionMessage(t); | ||
| ret = FormValidation.error(StringUtils.abbreviate(msg, 200)); | ||
| LOGGER.finest(t.getMessage()); |
There was a problem hiding this comment.
If you are going to log at sub-INFO levels, you may as well include the whole stack trace for analysis.
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it is needed to have permissions to create an S3 Bucket