Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lock guava to 20.0 #66

Merged
merged 1 commit into from
Jul 4, 2018
Merged

Lock guava to 20.0 #66

merged 1 commit into from
Jul 4, 2018

Conversation

carlossg
Copy link
Contributor

@carlossg carlossg commented Jul 4, 2018

Otherwise 21.0 causes
java.lang.NoSuchMethodError: com.google.common.util.concurrent.MoreExecutors.sameThreadExecutor()Lcom/google/common/util/concurrent/ListeningExecutorService;

Broken with #62

Otherwise 21.0 causes
java.lang.NoSuchMethodError: com.google.common.util.concurrent.MoreExecutors.sameThreadExecutor()Lcom/google/common/util/concurrent/ListeningExecutorService;
@carlossg carlossg requested a review from kuisathaverat July 4, 2018 09:31
Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we just use guava from the core?

@carlossg carlossg merged commit 0b983ae into master Jul 4, 2018
@carlossg carlossg deleted the guava branch July 4, 2018 10:46
@jglick
Copy link
Member

jglick commented Jul 9, 2018

I suspect what you meant to do was to use an <exclusion> of guava from io.findify:s3mock_2.12…?

@jglick
Copy link
Member

jglick commented Jul 9, 2018

cf. #44

@carlossg
Copy link
Contributor Author

carlossg commented Jul 9, 2018

I don't know if s3mock needs any specific version of guava, at least it works with 20. May not work with previous versions

@jglick
Copy link
Member

jglick commented Jul 9, 2018

It is just that we care a lot about jclouds and the AWS SDK being bundled with a preferred version of Guava; and not at all about S3Mock getting a particular version—either the tests pass or they do not. Using exclusion assures us that the version is picked up from the right place even if we update the libs being used at runtime.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants