Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build Failure Analyzer integration: show number of detected failures #115

Merged
merged 1 commit into from
Jun 4, 2015

Conversation

patrickdepinguin
Copy link
Contributor

The build monitor can show failures detected by the Build Failure
Analyzer plugin, with output like:
Identified problems: foo, bar, baz

This commit adds the number of detected failures, as follows:
Identified problems (3): foo, bar, baz

This commit is similar to pull request #28, but leverages the existing integration with the Build Failure Analyzer plugin, which supports recognition of JUnit test results since version 1.11.0.

The build monitor can show failures detected by the Build Failure
Analyzer plugin, with output like:
    Identified problems: foo, bar, baz

This commit adds the number of detected failures, as follows:
    Identified problems (3): foo, bar, baz
@patrickdepinguin
Copy link
Contributor Author

Any feedback?

@jan-molak
Copy link
Member

Hey @patrickdepinguin - how does it work with failed JUnit tests? I'm guessing it should show the number of failed tests, is that right?

@patrickdepinguin
Copy link
Contributor Author

Hey @jan-molak, I'm not fully sure what you mean. A while back, I added support for detecting JUnit tests in Build Failure Analyzer. Once the configuration option (of BFA) for this is set, a JUnit test failure will be detected by the Build Failure Analyzer, just like you already could predefine certain failure patterns in that plugin. If you only care about JUnit tests, then you do not need any configuration in BFA (apart from the enabling of the feature).
Since Build Monitor plugin knows about the failures (detected patterns or JUnit test failures) it will display it.
This commit specifically just adds a count, not making a distinction between JUnit failures or other types of failures reported by BFA.
Hope this is an answer to your question...

@jan-molak jan-molak merged commit 5c8d404 into jenkinsci:master Jun 4, 2015
jan-molak added a commit that referenced this pull request Jun 4, 2015
jan-molak added a commit that referenced this pull request Jun 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants