-
-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show number of failed tests in job view #28
Conversation
Hi Bobby, thanks for your feedback and spending your time contributing to this project! Could you please elaborate a bit more on why you guys find this metric useful? I know this might sound like an odd question to ask, but please have a quick look at my comment on not supporting "unstable" builds, as I believe it should shed some more light on my rationale behind not displaying the number of failed tests. If your point of view is different I'd be very happy to learn more about it and change mine if necessary :) |
Thanks for looking at this, Jan! Just read your comment on the "unstable" builds pull request. It's a fair viewpoint. My situation my be unique, but I do think both ways have benefits. We have two jobs set up in Jenkins: one which compiles our software, and another which runs our testing. We're working on some embedded development, and our testing job run our software on real hardware using a Python script to control everything. We send some messages to our software, make sure we get the right results back, and the Python script generates a JUnit XML report. Some of our tests do fail from time to time, and while the team doesn't find this acceptable, we have some strange timing issues that are taking longer to debug. Partly because of this, it's nice to know if only one test has failed, or if there are two or three tests that are failing. Additionally, the number of failing tests can change the sense of urgency to get things fixed. Yes, a build that is passing tests is no good, but a build that fails 5 tests might mean "drop everything", while a build that passes one test might mean "I need to look at this when I get a chance." We had been using another Jenkins plugin (unfortunately, I'm not sure which one) that displayed this information, but wasn't very pretty. We moved over to this plugin because, frankly, it's beautiful and works very well. However, this information was missing and our team found it valuable. Of course, no hard feelings if you feel that it isn't right for this project :) |
I agree that showing the number of failed tests is helpful information and I agree with Jan that it shouldn't be used as an excuse to ignore a failed build. The number of tests failing is helpful for us to quickly figure out the type of problem. For a web (browser/headless-driven) build, if the majority of tests fail then we know that the webapp itself probably didn't deploy correctly whereas if a few fail then it's a functional problem. Either way, the option to view this stat would be nice. |
Hey jan, Do you have any plan to get this request merged ? |
Hi Jan, |
Hi, yes, I'll be adding this functionality at some point, probably in a slightly changed form. Stay tuned! In the meantime you might want to consider using the BuildFailureAnalyzer Plugin that should allow to achieve a similar result? |
Hey @arpitgold, would you mind raising a separate ticket for that? Also I'll need a bit more context, so could you please mention:
Thanks! |
Hi Jan, |
Hi Jan, any updates on this ?? |
I'll close this in favour of using Build Failure Analyzer as described by @patrickdepinguin in #99 |
We've been using a different plugin to display our build wall, since it also shows the number of failed tests -- a metric we find useful on the wall. This change makes the necessary modifications to the build monitor plugin to allow it to show the number of failed tests, as shown in the screenshot below.