-
-
Notifications
You must be signed in to change notification settings - Fork 9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JENKINS-68699] Upgrade Yarn from 1.22.19 to 3.2.0 #5824
Conversation
I think we should wait for eirslett/frontend-maven-plugin#1012 |
@StefanSpieker eirslett/frontend-maven-plugin#1012 was released in 1.12.1, which we upgraded to in #6139. |
The outstanding blockers have been addressed by now, do you mind resolving the merge conflicts so we can pick the PR up for another review @StefanSpieker ? |
I resolved the hard/physical merge conflicts at least. There may still be soft/logical conflicts. |
I just pushed some commits that should complete this effort. |
Didn't realize this was checking in a multi MB blob
Oh dear, |
In commit b54f044 I found a trick to download Yarn Berry via Maven Antrun Plugin rather than Frontend Maven Plugin. If accepted, it is critical that this PR be squash merged to avoid bloating the repository size. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested it out locally and all seems good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for investigating into an alternative solution, basil, works out great so far when checking out locally.
Non blocking nit: berry 3.2.1 is out by now which we could use over 3.2.0.
I am glad this is non-blocking, because I would decline to accommodate it after going above and beyond the expectations for a maintainer to the degree that I already have regarding this PR which I did not submit myself. |
This PR is now ready for merge. We will merge it after approximately 24 hours if there is no negative feedback. Please see the merge process documentation for more information about the merge process. Thanks! |
Please take a moment and address the merge conflicts of your pull request. Thanks! |
Renovate doesn't seem to like this in #6892. |
I'll take a look, renovate definitely supports it |
looking at renovatebot/renovate#14797 |
Not sure this matters, but the antrun execution breaks offline usage. |
The antrun execution is a hack to work around eirslett/frontend-maven-plugin#1032. The long-term solution should be implemented in |
Upgrade to yarn 3.0 and minor node update. Accoring to this issue we still need to install the latest 1.x release to use the 3.0 ...
Proposed changelog entries
Proposed upgrade guidelines
N/A
Submitter checklist
Proposed changelog entries
section only if there are breaking changes or other changes which may require extra steps from users during the upgradeDesired reviewers
@mention
Maintainer checklist
Before the changes are marked as
ready-for-merge
:Proposed changelog entries
are correctupgrade-guide-needed
label is set and there is aProposed upgrade guidelines
section in the PR title. (example)lts-candidate
to be considered (see query).