Fix for view based priority sorting jelly #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
monluk
force-pushed
the
bugfix/ViewBasedForJenkins277
branch
from
2ab95ac to
eb7bc24
Compare
monluk
force-pushed
the
bugfix/ViewBasedForJenkins277
branch
from
eb7bc24 to
c203f62
Compare
|
Thanks very much for the pull request. I had hoped that it would resolve multiple issue reports like JENKINS-65859, JENKINS-66938, and JENKINS-67218. Unfortunately, when I save the Job Priorities page a second time with Jenkins 2.303.3 using this pull request, it throws the same exception. |
MarkEWaite
approved these changes
Nov 26, 2021
There was a problem hiding this comment.
Included in the fix for JENKINS-66938 in #88 . Thanks very much for detecting and fixing this issue!
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong
In Jenkins - starting from version 2.264 - it was not possible to add or make changes to priority sorter for "Jobs included in a view".
Format of data in a json was not handled properly.
What has been done
Structure of elements in UI was wrong. The part of the UI responsible for filtering based on regular expression was placed inside views selector.
How to test
The test will result in "Oops!" page while using Priority Sorter plugin in version 4.0 and will work fine with the fixed version.
It has been tested and works fine on Jenkins 2.263.4 and 2.277.2