Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cross compilation issue: strip detection #221

Closed
egavrin opened this issue Jun 21, 2015 · 2 comments
Closed

Cross compilation issue: strip detection #221

egavrin opened this issue Jun 21, 2015 · 2 comments
Assignees
@egavrin
Labels
bug Undesired behaviour enhancement An improvement infrastructure Related to GH Actions or the tested targets minor
Milestone
Maintenance of EC...

Comments

@egavrin
Copy link
Contributor

egavrin commented Jun 21, 2015

There is one minor issue leftover: If we cross-compile to x86_64 then it is possible that the line

find_program(CMAKE_STRIP NAMES x86_64-linux-gnu-strip x86_64-unknown-linux-gnu-strip strip)

in the build/configs/toolchain_linux_x86_64.cmake file would make the CMAKE_STRIP to use the
default strip binary, which could be incorrect for the given target, as the strip would be for the host.

Reported by @galpeter in comments to #71
@egavrin egavrin added bug Undesired behaviour enhancement An improvement minor infrastructure Related to GH Actions or the tested targets labels Jun 21, 2015
@egavrin egavrin added this to the Core ECMA features milestone Jun 21, 2015
@egavrin egavrin mentioned this issue Jun 21, 2015
Closed
@egavrin egavrin self-assigned this Jun 21, 2015
@egavrin
Copy link
Contributor Author

egavrin commented Jun 21, 2015

Regular strip can be removed from config, native or cross compilers should provide x86_64-linux-gnu-strip links.

Can be fixed within #206

egavrin added a commit that referenced this issue Jun 22, 2015
@egavrin
Fix for issue #221
c139d17 
JerryScript-DCO-1.0-Signed-off-by: Evgeny Gavrin [email protected]
egavrin added a commit that referenced this issue Jun 22, 2015
@egavrin
Fix for issue #221
d2f6959 
JerryScript-DCO-1.0-Signed-off-by: Evgeny Gavrin [email protected]
@galpeter
Copy link
Contributor

Regular strip can be removed from config, native or cross compilers should provide x86_64-linux-gnu-strip links.

That's maybe true for cross compilers, but not true for native compilers. For example on my system the native compiler gives just the strip.

This was referenced May 17, 2020
Closed
Closed
This was referenced Oct 20, 2020
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@egavrin egavrin

Labels
bug Undesired behaviour enhancement An improvement infrastructure Related to GH Actions or the tested targets minor
Projects
None yet
Milestone
Maintenance of ECMA functionality
Development

No branches or pull requests
3 participants
@egavrin @LaszloLango @galpeter