Add support of cross-compilation for linux-based targets. #206

egavrin · 2015-06-18T10:54:27Z

Usage:

Cross compile:
make debug.linux TOOLCHAIN=./build/configs/toolchain_linux_armv7l-el.cmake
Build unittests
make unittests TOOLCHAIN=./build/configs/toolchain_linux_armv7l-el.cmake
Run unittests on target board
./tools/runners/run-unittests-remote.sh
Run JavaScript test on target board
./tools/runners/run-tests-remote.sh debug.linux

JerryScript-DCO-1.0-Signed-off-by: Evgeny Gavrin [email protected]

ruben-ayrapetyan · 2015-06-18T15:44:17Z

tools/runners/run-javascript-tests.sh

+mkdir -p ${LOGS_PATH_PARSE_ONLY}
+mkdir -p ${LOGS_PATH_FULL}
+
+RAND=`strings /dev/urandom | grep -o '[[:alnum:]]' | head -n 5 | tr -d '\n'; echo`


Maybe, it is better to use mktemp utility for generation of a directory with random name.

egavrin · 2015-06-22T08:28:00Z

jerry-core/parser/js/opcodes-dumper.cpp

-  const opcode_t opcode = getop_meta (OPCODE_META_TYPE_CALL_SITE_INFO,
-                                      flags,
-                                      (flags & OPCODE_CALL_FLAGS_HAVE_THIS_ARG) ? this_arg.data.uid : INVALID_VALUE);
+  const opcode_t opcode = getop_meta(OPCODE_META_TYPE_CALL_SITE_INFO,


This change is not related to the PR, but required for cross building. I'll push this change as a separate commit.

egavrin · 2015-06-22T12:37:07Z

@ruben-ayrapetyan gcc version 4.7.4 (Ubuntu/Linaro 4.7.4-2ubuntu1)

egavrin · 2015-06-22T12:37:47Z

@ruben-ayrapetyan Fix build error using GCC 4.7.4?

ruben-ayrapetyan · 2015-06-22T12:47:06Z

@egavrin, looks good.

egavrin · 2015-06-22T13:16:31Z

Folks, I've updated the PR, please check.

//cc @galpeter @LaszloLango @ruben-ayrapetyan

ruben-ayrapetyan · 2015-06-22T21:03:31Z

tools/precommit-full-testing.sh

+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+OUT_DIR=$1


Maybe, it is better to wrap variables into quotes, like "$1". In the case, space wouldn't divide variable's value and special characters in path would not be replaced.

http://www.tldp.org/LDP/abs/html/quotingvar.html
"When referencing a variable, it is generally advisable to enclose its name in double quotes. This prevents reinterpretation of all special characters within the quoted string -- except $, ` (backquote), and \ (escape)."

Agree, it should be wrapped, but other our scripts doesn't follow this style. I may fix it within this PR, but we should fix this in other scripts too.

egavrin · 2015-06-23T07:13:23Z

I'll rise a separate pull request to fix other issues in scripts, likewise.

egavrin · 2015-06-23T07:42:24Z

PR was updated.

galpeter · 2015-06-26T07:52:29Z

build/configs/toolchain_linux_x86_64.cmake

@@ -17,7 +17,6 @@ set(CMAKE_SYSTEM_PROCESSOR x86_64)

 find_program(CMAKE_C_COMPILER NAMES x86_64-linux-gnu-gcc x86_64-unknown-linux-gnu-gcc)
 find_program(CMAKE_CXX_COMPILER NAMES x86_64-linux-gnu-g++ x86_64-unknown-linux-gnu-g++)
-# FIXME: This could break cross compilation, when the strip is not for the target architecture
-find_program(CMAKE_STRIP NAMES x86_64-linux-gnu-strip x86_64-unknown-linux-gnu-strip strip)
+find_program(CMAKE_STRIP NAMES x86_64-linux-gnu-strip x86_64-unknown-linux-gnu-strip)


Did the strip at the end made the x86_64 cross compilation to cause any problems?

@galpeter no, not really. I may add it back.
I think we can add native toolchain configuration with a separate PR, like Add toolchain_native.cmake.

egavrin · 2015-06-29T17:28:26Z

@galpeter PR was updated, I restored strip.

galpeter · 2015-06-30T11:02:27Z

tools/precommit.sh

-[ $RESULT_OK -eq 1 ] || exit 1
-
-echo -e "Full testing completed successfully\n\n================\n\n"
+./tools/precommit-full-testing.sh ${OUT_DIR} ${TARGETS} || exit 1


Wouldn't this pass the ${TARGETS} as the 2nd, 3rd and etc args? For example if the TARGETS are: debug.linux release.linux. the command will look like this:
./tools/precommit-full-testing.sh ${OUT_DIR} debug.linux release.linux

Maybe we need to enclose the arguments into quotes.

galpeter · 2015-06-30T11:48:18Z

seems good to me.

egavrin · 2015-06-30T12:02:41Z

Great! Thank you!

JerryScript-DCO-1.0-Signed-off-by: Evgeny Gavrin [email protected]

Usage: - Cross compile: make debug.linux TOOLCHAIN=./build/configs/toolchain_linux_armv7l-el.cmake - Build unittests make unittests TOOLCHAIN=./build/configs/toolchain_linux_armv7l-el.cmake - Run unittests on target board ./tools/runners/run-unittests-remote.sh <ip> <login> <pass> - Run JavaScript test on target board ./tools/runners/run-tests-remote.sh debug.linux <ip> <login> <pass> JerryScript-DCO-1.0-Signed-off-by: Evgeny Gavrin [email protected]

egavrin added enhancement An improvement infrastructure Related to GH Actions or the tested targets development Feature implementation labels Jun 18, 2015

egavrin added this to the Core ECMA features milestone Jun 18, 2015

ruben-ayrapetyan reviewed Jun 18, 2015
View reviewed changes

egavrin mentioned this pull request Jun 21, 2015

Cross compilation issue: strip detection #221

Closed

egavrin self-assigned this Jun 21, 2015

egavrin force-pushed the origin/cross-dev branch from 4fc8161 to e0f8c72 Compare June 22, 2015 07:42

egavrin reviewed Jun 22, 2015
View reviewed changes

egavrin force-pushed the origin/cross-dev branch 2 times, most recently from e456ab5 to d8a9c3e Compare June 22, 2015 12:35

egavrin force-pushed the origin/cross-dev branch from d8a9c3e to 74c56b1 Compare June 22, 2015 13:15

egavrin assigned galpeter and unassigned egavrin Jun 22, 2015

egavrin changed the title ~~Add support for cross compilation for linux-based targets.~~ Add support of cross-compilation for linux-based targets. Jun 22, 2015

egavrin force-pushed the origin/cross-dev branch from 74c56b1 to 9b7ece4 Compare June 22, 2015 18:14

ruben-ayrapetyan reviewed Jun 22, 2015
View reviewed changes

egavrin force-pushed the origin/cross-dev branch from 9b7ece4 to b9b1704 Compare June 23, 2015 07:08

egavrin force-pushed the origin/cross-dev branch 2 times, most recently from 5ecc00a to 8dc8678 Compare June 23, 2015 10:05

galpeter reviewed Jun 26, 2015
View reviewed changes

egavrin force-pushed the origin/cross-dev branch from 8dc8678 to 6a1b90e Compare June 29, 2015 17:27

egavrin force-pushed the origin/cross-dev branch 3 times, most recently from f855b19 to 00e00df Compare June 29, 2015 17:48

egavrin mentioned this pull request Jun 30, 2015

Add parallel test262 runner. #275

Merged

galpeter reviewed Jun 30, 2015
View reviewed changes

egavrin force-pushed the origin/cross-dev branch from 00e00df to 6267696 Compare June 30, 2015 11:45

galpeter removed their assignment Jun 30, 2015

egavrin added 2 commits June 30, 2015 15:03

Fix build error using GCC 4.7.4

be2de16

JerryScript-DCO-1.0-Signed-off-by: Evgeny Gavrin [email protected]

egavrin force-pushed the origin/cross-dev branch from 6267696 to 444bd32 Compare June 30, 2015 12:03

egavrin merged commit 444bd32 into master Jun 30, 2015

egavrin deleted the origin/cross-dev branch June 30, 2015 12:59

This was referenced May 17, 2020

stack-overflow in vm_loop #3750

Closed

stack-overflow in ecma_regexp_match #3753

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support of cross-compilation for linux-based targets. #206

Add support of cross-compilation for linux-based targets. #206

egavrin commented Jun 18, 2015

ruben-ayrapetyan Jun 18, 2015

egavrin Jun 22, 2015

egavrin Jun 22, 2015

egavrin commented Jun 22, 2015

egavrin commented Jun 22, 2015

ruben-ayrapetyan commented Jun 22, 2015

egavrin commented Jun 22, 2015

ruben-ayrapetyan Jun 22, 2015

egavrin Jun 22, 2015

egavrin Jun 23, 2015

egavrin commented Jun 23, 2015

egavrin commented Jun 23, 2015

galpeter Jun 26, 2015

egavrin Jun 26, 2015

egavrin commented Jun 29, 2015

galpeter Jun 30, 2015

egavrin Jun 30, 2015

galpeter commented Jun 30, 2015

egavrin commented Jun 30, 2015

Add support of cross-compilation for linux-based targets. #206

Add support of cross-compilation for linux-based targets. #206

Conversation

egavrin commented Jun 18, 2015

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

egavrin commented Jun 22, 2015

egavrin commented Jun 22, 2015

ruben-ayrapetyan commented Jun 22, 2015

egavrin commented Jun 22, 2015

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

egavrin commented Jun 23, 2015

egavrin commented Jun 23, 2015

Choose a reason for hiding this comment

Choose a reason for hiding this comment

egavrin commented Jun 29, 2015

Choose a reason for hiding this comment

Choose a reason for hiding this comment

galpeter commented Jun 30, 2015

egavrin commented Jun 30, 2015