Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

targets: add nuttx interpreter build #805

Closed

Conversation

seanshpark
Copy link
Contributor

JerryScript-DCO-1.0-Signed-off-by: SaeHie Park [email protected]

JerryScript-DCO-1.0-Signed-off-by: SaeHie Park [email protected]
@seanshpark
Copy link
Contributor Author

any one interested to review? :)

@zherczeg
Copy link
Member

In general argument, function comments are missing from main-nuttx.cpp. I think there was a discussion to reduce the number of main-**.cpp files. Do we really need a separated file this platform?

@seanshpark
Copy link
Contributor Author

@zherczeg , well,I wasn't thinking of adding snapshot to arm/nuttx and when I made this code, linux and darwin was in separate files. And I think for embed target ports, I prefer more simple codes as an example and entry.

@zherczeg
Copy link
Member

Is it still a valid PR or you plan some changes?

@seanshpark
Copy link
Contributor Author

Hope to merge as is but if you think better to use main-unix.cpp, I need to check how it works.

@LaszloLango
Copy link
Contributor

The main reason of merging main-linux.cpp and main-darwin.cpp was that they were almost identical. I think it is OK to place in a separate file, because main-nuttx.cpp is different.

@zherczeg
Copy link
Member

zherczeg commented Feb 5, 2016

Ok I was just asking.

@zherczeg
Copy link
Member

zherczeg commented Feb 5, 2016

LGTM, though it would be good to reduce code duplications on these main-*.cpp files in a followup patches.

@LaszloLango LaszloLango assigned seanshpark and egavrin and unassigned seanshpark Feb 5, 2016
@LaszloLango
Copy link
Contributor

Landed (ef1252e)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants