-
Notifications
You must be signed in to change notification settings - Fork 677
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
targets: add nuttx interpreter build #805
Conversation
3844dc3
to
ffcdab9
Compare
JerryScript-DCO-1.0-Signed-off-by: SaeHie Park [email protected]
ffcdab9
to
2b0a152
Compare
any one interested to review? :) |
In general argument, function comments are missing from main-nuttx.cpp. I think there was a discussion to reduce the number of main-**.cpp files. Do we really need a separated file this platform? |
@zherczeg , well,I wasn't thinking of adding snapshot to arm/nuttx and when I made this code, linux and darwin was in separate files. And I think for embed target ports, I prefer more simple codes as an example and entry. |
Is it still a valid PR or you plan some changes? |
Hope to merge as is but if you think better to use main-unix.cpp, I need to check how it works. |
The main reason of merging |
Ok I was just asking. |
LGTM, though it would be good to reduce code duplications on these main-*.cpp files in a followup patches. |
Landed (ef1252e) |
JerryScript-DCO-1.0-Signed-off-by: SaeHie Park [email protected]