Abort the build-process when the build-configuration is unsupported #866
Conversation
|
@LaszloLango, this change independent from #790 |
|
@bzsolt, I see. LGTM |
The MCU targets doesn't support Valgrind. Related issue: jerryscript-project#762 JerryScript-DCO-1.0-Signed-off-by: Zsolt Borbély [email protected]
bzsolt
force-pushed
the
fix_issue_762
branch
from
4177912 to
41f2f91
Compare
|
Hm, this might have beed a tad too quick. Would it not have been better to implement this check on CMakeLists.txt side? The more checks we have there the better IMHO, since this Makefile is just a wrapper around the cmake-generated build system. There are some use cases where this Makefile is not called at all. Those cases cannot utilize these sanity checks. |
|
I think the Makefile should be an interface for builds and calling directly the CMake is a bit hack. What use cases use the CMakeList.txt directly? I don't mind if you move this to CMakeLists.txt side, but the merged PR is still good for me. Maybe we should rework the whole build system. :) |
|
Our own makefiles at The build system rework is exactly what I'm working on and this patch will cause trouble rebasing to. |
|
@akiss77, I see. Sorry for the inconvenience. BTW, nuttx target PR (#805) is landed. :) I accept your arguments. This change would be better on the CMakeList.txt side. Could you do this in part of your rework? |
|
@akiss77 @LaszloLango Sorry for the trouble, if necessary, I could move this to the CMake side too. |
Related pull request: jerryscript-project#866 JerryScript-DCO-1.0-Signed-off-by: Zsolt Borbély [email protected]
The MCU targets doesn't support Valgrind.
Related issue: #762
JerryScript-DCO-1.0-Signed-off-by: Zsolt Borbély [email protected]