-
-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace Travis with GitHub Actions #326
Replace Travis with GitHub Actions #326
Conversation
runs-on: ubuntu-latest | ||
strategy: | ||
matrix: | ||
node-version: [12.x, 14.x, 16.x] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we currently support node 8. I'm down with just supporting the current LTSes, tho 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah. I didn't realize that. I like the idea of supporting only current LTS, but what does Jest itself officially support? Or is that what you meant by "we"?
"babel-cli": "^6.26.0", | ||
"babel-core": "^6.26.0", | ||
"babel-eslint": "^8.0.1", | ||
"babel-jest": "^23.0.1", | ||
"babel-jest": "^24.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because I bumped Jest to 24 so I could use --color
, I also bumped this dependency. Both are dev dependencies.
@@ -99,7 +99,7 @@ | |||
"babel-plugin-transform-es2015-modules-commonjs", | |||
"transform-object-rest-spread", | |||
"transform-async-to-generator", | |||
"babel-jest-assertions", | |||
"./node_modules/babel-jest-assertions", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"./node_modules/babel-jest-assertions", | |
"module:babel-jest-assertions", |
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought that was a Babel 7 syntax? If I'm mistaken, then yea, I prefer that (I did it in the Babel 7 PR already)
node-version: ${{ matrix.node-version }} | ||
- run: yarn install | ||
- run: yarn lint | ||
- run: yarn test:coverage |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be enough to add https://github.com/codecov/codecov-action, and that'll use GH_TOKEN
or something
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a good idea.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I thought public repos fell under the "free" tier of 2,000 minutes per month. But now I see what you're saying
Even better! |
What
Switching from Travis to GitHub Actions.
Why
Travis changed their pricing model, which allocates 10,000 credits/minutes for open source projects. Once those credits are consumed, you must repeat the process to request more credits.
Notes