-
-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace Travis with GitHub Actions #326
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
name: 'GitHub CI' | ||
on: | ||
push: | ||
branches: [ master ] | ||
pull_request: | ||
branches: [ master ] | ||
jobs: | ||
ci: | ||
runs-on: ubuntu-latest | ||
strategy: | ||
matrix: | ||
node-version: [12.x, 14.x, 16.x] | ||
steps: | ||
- uses: actions/checkout@v2 | ||
- name: Use Node.js ${{ matrix.node-version }} | ||
uses: actions/setup-node@v1 | ||
with: | ||
node-version: ${{ matrix.node-version }} | ||
- run: yarn install | ||
- run: yarn lint | ||
- run: yarn test:coverage | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. should be enough to add https://github.com/codecov/codecov-action, and that'll use There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. That's a good idea. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
- run: yarn test:report |
This file was deleted.
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -17,7 +17,7 @@ | |||||
"prepublishOnly": "yarn build", | ||||||
"precommit": "lint-staged", | ||||||
"prettier": "prettier 'src/**/*.js' --write --single-quote=true --print-width=120", | ||||||
"test": "jest", | ||||||
"test": "jest --color=true", | ||||||
"test:coverage": "yarn test -- --coverage", | ||||||
"test:report": "codecov", | ||||||
"test:watch": "yarn test -- --watch" | ||||||
|
@@ -35,11 +35,11 @@ | |||||
"license": "MIT", | ||||||
"repository": "jest-community/jest-extended", | ||||||
"devDependencies": { | ||||||
"@types/jest": "^23.3.2", | ||||||
"@types/jest": "^24.0.0", | ||||||
"babel-cli": "^6.26.0", | ||||||
"babel-core": "^6.26.0", | ||||||
"babel-eslint": "^8.0.1", | ||||||
"babel-jest": "^23.0.1", | ||||||
"babel-jest": "^24.0.0", | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Because I bumped Jest to 24 so I could use |
||||||
"babel-jest-assertions": "^0.1.0", | ||||||
"babel-plugin-gwt": "^1.0.0", | ||||||
"babel-plugin-transform-async-to-generator": "^6.24.1", | ||||||
|
@@ -51,7 +51,7 @@ | |||||
"eslint-plugin-jest": "^21.2.0", | ||||||
"husky": "^0.14.3", | ||||||
"import-all.macro": "^2.0.3", | ||||||
"jest": "^23.0.1", | ||||||
"jest": "^24.0.0", | ||||||
"jest-each": "^0.5.0", | ||||||
"jest-watch-typeahead": "^0.2.0", | ||||||
"lint-staged": "^6.0.0", | ||||||
|
@@ -99,7 +99,7 @@ | |||||
"babel-plugin-transform-es2015-modules-commonjs", | ||||||
"transform-object-rest-spread", | ||||||
"transform-async-to-generator", | ||||||
"babel-jest-assertions", | ||||||
"./node_modules/babel-jest-assertions", | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I thought that was a Babel 7 syntax? If I'm mistaken, then yea, I prefer that (I did it in the Babel 7 PR already) |
||||||
"gwt", | ||||||
"macros" | ||||||
] | ||||||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we currently support node 8. I'm down with just supporting the current LTSes, tho 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah. I didn't realize that. I like the idea of supporting only current LTS, but what does Jest itself officially support? Or is that what you meant by "we"?