-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
General check and fix cleanup #237
General check and fix cleanup #237
Conversation
The branch can be tried out by running:
|
LGTM so far (note for me, last commit I checked was Remove unused errorToLeft/RightRange) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still looks good to me so far 👍
, parentRange = checkInfo.parentRange | ||
, first = checkInfo.left | ||
collectionUnionWithLiteralsChecks | ||
{ first = checkInfo.left | ||
, second = checkInfo.right | ||
, operationRange = checkInfo.operatorRange | ||
, operation = "++" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Additional simplification: The operator is in checkInfo.operation
Fighting elm/compiler#2312, this somehow worked out now. E.g. Sensible solutions might be to not alias |
I'm fine with not having |
…DoesNotChangeIt checks
40ce5df
to
6d745b1
Compare
Great work 😊 |
checkInfo
arguments implicitly(-)
,(+)
,(*)
,(/)
,(//)
,(++)
,(<)
,(<=)
,(>)
,(>=)
,(&&)
,(||)
,(&&)
,(==)
,(/=)
unnecessaryMessage
,unnecessaryDetails
,alwaysSameDetails
and other error helpersoperationSides
unnecessaryCompositionAfterEmptyCheck
last.argCount
toCompositionIntoCheckInfo
ConstructWithOneArg
asempty
directly by requiring an extrais
propertylistDetermineLength
usegetSpecificFnCall
for singletonNote that
unnecessaryCompositionAfterEmptyCheck
enables new simplifications, e.g.Task.map f << Task.fail --> Task.fail
which are deliberately not included in this PR.Switching to
Fn.Array.map
will be the next PR