Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General check and fix cleanup #237

Merged
merged 82 commits into from
Oct 4, 2023
Merged

General check and fix cleanup #237

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
82 commits
Select commit Hold shift + click to select a range
5ea76c3
Replace record patterns by variables
lue-bird Oct 2, 2023
0f076d4
group size-related type properties
lue-bird Oct 2, 2023
da496df
CollectionProperties don't include EmptiableProperties
lue-bird Oct 2, 2023
0f05a20
Rename literalUnionLeftElementsStayOnTheLeft to unionLeft...
lue-bird Oct 2, 2023
e734cdc
group fromListLiteral type properties
lue-bird Oct 2, 2023
d12ff57
Make checkInfo argument implicit
lue-bird Oct 2, 2023
31c30cf
alwaysReturnsLastArgError use fullyAppliedLastArg
lue-bird Oct 2, 2023
f27f599
Replace matching on "" by stringCollection.empty.is
lue-bird Oct 2, 2023
c900f49
equalityChecks use operationToSides
lue-bird Oct 2, 2023
13b0078
and_isRightSimplifiableError use fixTo<side>Range
lue-bird Oct 3, 2023
1ef8e5b
and_isLeftSimplifiableError use fixTo<side>Range
lue-bird Oct 3, 2023
3190703
or_isRightSimplifiableError use fixTo<side>Range
lue-bird Oct 3, 2023
276f099
or_isLeftSimplifiableError use fixTo<side>Range
lue-bird Oct 3, 2023
3cf7a6d
Rename fixTo<side>Range to remove<side>Range
lue-bird Oct 3, 2023
ce116d4
minusChecks use replaceBySubExpressionFix
lue-bird Oct 3, 2023
dbc2328
Move checkInfo.expectNaN test into checkIfMinusResultsInZero
lue-bird Oct 3, 2023
9d24663
removeAlongWithOtherFunctionCheck use onCallToInverseReturnsItsArgume…
lue-bird Oct 3, 2023
b61f939
Remove unused doubleToggleErrorInfo
lue-bird Oct 3, 2023
2e9f17b
Rename removeAlongWithOtherFunctionCheck to toggleCallChecks
lue-bird Oct 3, 2023
f5c052f
Move toggle checks near inverse checks
lue-bird Oct 3, 2023
f92bd5e
Move not and negate near other Basics checks
lue-bird Oct 3, 2023
d39e74d
Introduce andSideCheck
lue-bird Oct 3, 2023
d3feacb
Introduce orSideChecks
lue-bird Oct 3, 2023
39371ca
minusChecks use keepOnlyFix
lue-bird Oct 3, 2023
b0b9c9a
divisionChecks use keepOnlyFix
lue-bird Oct 3, 2023
e7c9647
operationToSides info to node and otherNode
lue-bird Oct 3, 2023
a0e63c8
Rename operationToSides to sides
lue-bird Oct 3, 2023
c51eed0
operationSides order to left then right
lue-bird Oct 3, 2023
3a356cf
orChecks use operationSides
lue-bird Oct 3, 2023
ca581f1
andChecks use operationSides
lue-bird Oct 3, 2023
15c740d
Rename andSideCheck to andSideChecks
lue-bird Oct 3, 2023
03d425c
Remove unused removeLeft/RightRange
lue-bird Oct 3, 2023
52bbb76
Replace errorTo<side>Range by operatorRange
lue-bird Oct 3, 2023
9469022
Remove unused errorToLeft/RightRange
lue-bird Oct 3, 2023
09e17ab
Tweak (+), (-) error infos
lue-bird Oct 3, 2023
029110b
Tweak * 1 error info
lue-bird Oct 3, 2023
8e3920a
Tweak divide error infos
lue-bird Oct 3, 2023
9b510d5
Tweak (//) error infos more
lue-bird Oct 3, 2023
7b6a55f
replace case on list literal by listCollection.empty.is
lue-bird Oct 3, 2023
aa81089
Introduce appendEmptyCheck
lue-bird Oct 3, 2023
d702283
Report unnecessary not on both sides at operator range
lue-bird Oct 3, 2023
1519da2
Tweak unnecessary negation on both sides error info
lue-bird Oct 3, 2023
f4acca9
Correct negation on both sides fix
lue-bird Oct 3, 2023
11762f9
Convert case on Maybe.map2 pair to case on tuple
lue-bird Oct 3, 2023
a2ba6f9
Rename "function" in ast helpers to "fn" where appropriate
lue-bird Oct 3, 2023
ffcccfb
Separate a == a check
lue-bird Oct 3, 2023
669d2bd
Rename comparisonChecks to numberComparisonChecks
lue-bird Oct 3, 2023
12e85fb
Tweak comparisonError
lue-bird Oct 3, 2023
b828ff7
Remove unused comparisonIsAlwaysMessage
lue-bird Oct 3, 2023
7ab0ce3
Improve && True and || False error infos
lue-bird Oct 3, 2023
5dc3338
Improve || False and && True error ranges
lue-bird Oct 3, 2023
1018b38
Improve && False and || True error infos
lue-bird Oct 3, 2023
356958a
Remove unnecessary operationSides
lue-bird Oct 3, 2023
4507bcb
collectionUnionWithLiteralsChecks take operation info separately
lue-bird Oct 3, 2023
315c9ca
Move andBetweenRange near range helpers
lue-bird Oct 3, 2023
ccf2288
Implement removeBoundariesFix using keepOnlyFix
lue-bird Oct 3, 2023
6b06e02
Remove unused rightBoundaryRange
lue-bird Oct 3, 2023
23e53c1
Introduce compositionFromEmptyReturnsEmptyCheck
lue-bird Oct 3, 2023
fbdd25d
Add failing test for List.intersperse << singleton
lue-bird Oct 3, 2023
fbe29c2
Correct compositionAfterWrapIsUnnecessaryCheck
lue-bird Oct 3, 2023
4724317
Introduce unnecessaryCompositionAfterCheck
lue-bird Oct 3, 2023
88a2f44
Rename compositionFromEmptyReturnsEmptyCheck to unnecessaryCompositio…
lue-bird Oct 3, 2023
528fef8
Add later.argCount to CompositionIntoCheckInfo
lue-bird Oct 3, 2023
a074392
Use later arg count from check info
lue-bird Oct 3, 2023
c8f6f98
Introduce onlyLastArgIsCurried
lue-bird Oct 3, 2023
323e77a
Correct operationDoesNotChangeResultOfOperationCompositionCheck
lue-bird Oct 3, 2023
5357fba
Move operationDoesNotChangeResultOfOperation checks near other callOn…
lue-bird Oct 3, 2023
03cd79a
Move fullyAppliedLastArg near onlyLastArgIsCurried
lue-bird Oct 3, 2023
a051e44
Improve diff/union ... empty error info
lue-bird Oct 3, 2023
e22a03d
Improve diff empty error message
lue-bird Oct 3, 2023
4a34ae5
Rename callOnDoesNotChangeItCheck to unnecessaryCallOnCheck
lue-bird Oct 3, 2023
280d8b6
Rename callOnWrappedDoesNotChangeItCheck to unnecessaryCallOnWrappedC…
lue-bird Oct 3, 2023
8c9aa6e
Rename compositionAfterWrapIsUnnecessaryCheck to unnecessaryCompositi…
lue-bird Oct 3, 2023
9902e6c
Rename callOnEmptyReturnsEmptyCheck to unnecessaryCallOnEmptyCheck
lue-bird Oct 3, 2023
b994baa
Rename callOnWrapReturnsItsValue to callOnWrapReturnsItsValueCheck
lue-bird Oct 3, 2023
4df0bd6
Let constants and constructs with one arg share `is` property
lue-bird Oct 3, 2023
447b958
Use TypeSubsetProperties in argument types
lue-bird Oct 3, 2023
e9f5d4d
EmptiableProperties take empty properties as a type arg
lue-bird Oct 3, 2023
a5c19ca
Correct typo
lue-bird Oct 3, 2023
76cd3e2
listDetermineLength use getSpecificFnCall for singleton
lue-bird Oct 3, 2023
cf23388
Do not include TypeProperties in -Properties
lue-bird Oct 3, 2023
6d745b1
Extract randomGeneratorConstantConstruct
lue-bird Oct 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,9 @@
Bug fixes:
- Fixed an issue where `Dict.intersect Dict.empty` would be fixed to `Dict.empty`
- Fixed an issue where `Set.intersect Set.empty` would be fixed to `Set.empty`
- Fixed an issue where `(a |> not) == (b |> not)` would be fixed to `(a |> ) == (b |> )`
- Fixed an issue where `List.intersperse << List.singleton` would be fixed to `List.singleton`
- Fixed an issue where e.g. `List.sortBy f << g` would be fixed to `g`

## [2.1.2] - 2023-09-28

Expand Down
Loading