Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle missing newlines or trailing spaces at end of file #8

Open
jhorstmann opened this issue Aug 28, 2015 · 3 comments · Fixed by #32
Open

Handle missing newlines or trailing spaces at end of file #8

jhorstmann opened this issue Aug 28, 2015 · 3 comments · Fixed by #32
Labels
Milestone

Comments

@jhorstmann
Copy link
Owner

jhorstmann commented Aug 28, 2015

I think the parser currently fails if the last line in the feature file does not end with a newline. There are two possible solutions:

  • Change the grammar to handle EOF same as EOL when the token can appear at the end of the file
  • Wrap the reader so that it automatically appends a missing EOL at the end of the file
@jhorstmann jhorstmann added the bug label Nov 8, 2017
@lukasniemeier-zalando
Copy link
Collaborator

👍

@lukasniemeier-zalando
Copy link
Collaborator

Did he misunderstand your "This does not fix #8" sentence? 😆

@lukasniemeier-zalando
Copy link
Collaborator

Together with #33 this is a very good candidate for a next release. Proposal (1) sounds better (antlr/grammars-v4#772) - but I guess proposal (2) may be a quick-win?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants