Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Append new line at end of feature files if missing. #42

Merged
merged 1 commit into from
May 30, 2018

Conversation

jmatusewicz
Copy link
Contributor

After wasting again lot of time because of #8, here is a quick fix.

}

private static String appendNewLineAtEOFIfMissing(String input) {
final String newLine = System.getProperty("line.separator");
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -518,4 +518,9 @@ public void shouldIgnoreTrailingComments() {
assertEquals(asList(), step.getComments());
}

@Test
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe there is an ignored test somewhere already that tests this.

@jhorstmann
Copy link
Owner

👍

@jhorstmann jhorstmann merged commit 3127cd9 into jhorstmann:master May 30, 2018
@jmatusewicz jmatusewicz deleted the fix-eol-bug branch May 31, 2018 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants