Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jimp UTIF dependency breaking elasticbeanstalk/AWS deploys #560

Closed
rxluz opened this issue Aug 21, 2018 · 13 comments · Fixed by #591
Closed

Jimp UTIF dependency breaking elasticbeanstalk/AWS deploys #560

rxluz opened this issue Aug 21, 2018 · 13 comments · Fixed by #591
Labels
bug there is a bug in the way jimp behaves

Comments

@rxluz
Copy link

rxluz commented Aug 21, 2018

Expected Behavior

The application runs without errors

Current Behavior

When I tried to update JIMP to 0.3.5 it's break my AWS deploy once UTIF uses jpgjs from github, not from npm, probably AWS doesn't accept this dependency type

Steps to Reproduce

  1. Update JIMP to 0.3.5
  2. Deploy to elasticbeanstalk/AWS

Context

  • Jimp Version: 0.3.5
  • Operating System: Linux
  • Node version: 8.9.3

Failure Logs

I received this message:

Error: Cannot find module 'jpgjs'
at Function.Module._resolveFilename (module.js:536:15)
at Function.Module._load (module.js:466:25)
at Module.require (module.js:579:17)
at require (internal/module.js:11:18)
at /var/app/current/node_modules/utif/UTIF.js:10:74
at Object. (/var/app/current/node_modules/utif/UTIF.js:911:3)
at Module._compile (module.js:635:30)
at Object.Module._extensions..js (module.js:646:10)
at Module.load (module.js:554:32)
at tryModuleLoad (module.js:497:12)
at Function.Module._load (module.js:489:3)
at Module.require (module.js:579:17)
at require (internal/module.js:11:18)
at Object. (/var/app/current/node_modules/jimp/dist/utils/image-bitmap.js:20:36)

@hipstersmoothie
Copy link
Collaborator

@rxluz do you have git installed?

@hipstersmoothie
Copy link
Collaborator

Also please post a comment here. photopea/UTIF.js#39 The more complaining we do the faster they can merge

@lipho
Copy link

lipho commented Aug 23, 2018

We are encountering this issue. Have git installed in the container and also have other git/github dependencies resolve correctly.

@hipstersmoothie
Copy link
Collaborator

@lipho can you go to the mentioned issue and comment there too? Part of the problem is that they’re using an unmaintained fork of that library

@lipho
Copy link

lipho commented Aug 24, 2018

Updating npm to 6.4.0 seems to have fixed it. Might be a problem with nested github resolutions in older npm versions.

@hipstersmoothie
Copy link
Collaborator

Oh yeah there was a bug for git resolution in older nom. @lipho I’d still appreciate a comment of the utif issue!

@rxluz
Copy link
Author

rxluz commented Aug 24, 2018

@hipstersmoothie Yes I have, but the issue isn't in my local environment, the problem is when I try to update the application to AWS, probably they don't accept git dependencies in package.json, I backed to Jimp 0.2.28 version and worked well

@hipstersmoothie
Copy link
Collaborator

hipstersmoothie commented Aug 24, 2018 via email

@rthomps7
Copy link

I've actually seen this issue in a couple other places: Heroku deploys and CI integrations.

What's odd is it seems inconsistent. Sometimes I redeploy without any changes (or rerun my CI) and things work.

@hipstersmoothie
Copy link
Collaborator

If you care about this issue please go bug the project owners on this issue. photopea/UTIF.js#43 and 🙏 for a fast release.

@cccRaim
Copy link

cccRaim commented Aug 31, 2018

I rollback version to 0.2.28, and remove the jpgjs dependency successful.


I just need change 'xxxxxAsync' to 'xxxxx'.
Because I don't use tiff, so the downgrade action is convince for me.


I will not update Jimp, unless the jpgjs problem is solved

@hipstersmoothie
Copy link
Collaborator

hipstersmoothie commented Aug 31, 2018 via email

@hipstersmoothie
Copy link
Collaborator

Released in v0.4.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug there is a bug in the way jimp behaves
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants