-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Netlify Deployment fails with jimp Version 0.3.5 #84
Comments
This issue as been imported as question since it does not respect pwa-module issue template. Only bug reports and feature requests stays open to reduce maintainers workload. |
Thanks for this bug report. While waiting for @hipstersmoothie's new release i''ll fallback jimp version |
You can make a custom build of jimp using https://github.com/oliver-moran/jimp/tree/master/packages/custom and exclude the TIFF package. Or you can wait until the new version of UTIF is released. |
FWIW, I am having the same error on Heroku. |
i have the same problem with 2.4.0 |
I encourage anyone who wants this fixed to go bug the maintainers of UTIF on this issue photopea/UTIF.js#43 @husayt @chrysanthos |
I experienced this issue now even with the latest release? Seems we need to get UTIF released quickly to get this covered. I've added "jpgjs": "github:makr28/jpgjs" to my package.json dependencies. Should do the trick in the meantime. |
No release has covered this yet on jimp's end. You could always make a custom build of jimp that doesn't use the tiff type https://github.com/oliver-moran/jimp/tree/master/packages/custom |
The issue here is not with jimp, but with this module using a library which
is not yet ready for use.
…On Thu, 30 Aug 2018, 08:32 Andrew Lisowski, ***@***.***> wrote:
No release has covered this yet on jimp's end. You could always make a
custom build of jimp that doesn't use the tiff type
https://github.com/oliver-moran/jimp/tree/master/packages/custom
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#84 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABHXrBWEl6U94hMPS7tBxL1NZ_AuZ9n2ks5uV5UDgaJpZM4WLfjS>
.
|
I totally agree. Regardless though it's breaking your build. To sidestep this right now you could just configure a custom Jimp and get all your builds passing. But it's only a band-aid if you really need TIFF support. |
Fixed with >= 0.4.0: jimp-dev/jimp#560 (comment) |
pwa-module/packages/icon/package.json
Line 13 in ef670b8
It fails with the error: "Cannot find module 'jpgjs'"
I guess this will happen on every AWS environment.
If i add the following to my package.json, everything works fine:
"jimp": "0.3.4"
Related: jimp-dev/jimp#560
The text was updated successfully, but these errors were encountered: