fix(JPC) skip processing remote audio sources when startSilent #2619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoids having any actual remote audio tracks, which can mess with the mobile audio session.
jallamsetty1
approved these changes
Jan 21, 2025
paweldomas
reviewed
Jan 21, 2025
|
|
||
| if (mediaType === MediaType.AUDIO && this.options.startSilent) { | ||
|
|
||
| return; |
There was a problem hiding this comment.
is the session going to eventually catch up with the skipped sources? or does startSilent mean no audio for the entire session?
There was a problem hiding this comment.
The latter. A full session restart is necessary for getting the missing sources.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoids having any actual remote audio tracks, which can mess with the mobile audio session.