Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(JPC) skip processing remote audio sources when startSilent #2619

Merged
merged 1 commit into from
Jan 21, 2025
Merged

fix(JPC) skip processing remote audio sources when startSilent #2619

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions modules/xmpp/JingleSessionPC.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -553,6 +553,13 @@ export default class JingleSessionPC extends JingleSession {

for (const description of descriptionsWithSources) {
const mediaType = $(description).attr('media');

if (mediaType === MediaType.AUDIO && this.options.startSilent) {

// eslint-disable-next-line no-continue
continue;
}

const sources = $(description).find('>source');
const removeSsrcs = [];

Expand Down Expand Up @@ -1835,6 +1842,12 @@ export default class JingleSessionPC extends JingleSession {
if (!FeatureFlags.isSsrcRewritingSupported()) {
return;
}

if (mediaType === MediaType.AUDIO && this.options.startSilent) {

return;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is the session going to eventually catch up with the skipped sources? or does startSilent mean no audio for the entire session?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The latter. A full session restart is necessary for getting the missing sources.

}

const newSsrcs = [];

for (const src of message.mappedSources) {
Expand Down
Loading