switch builtin pager to streampager #4203
Open
+726
−246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuja
commented
Aug 3, 2024
|
I would really like a version of IIRC, streampager's interface seemed a bit annoying in parts by default, so we might want to change its default config (or try it out at least). Apart from that, I think this might be great! |
4 tasks
Totally agree, and the stripped-down version exists in Sapling tree. Asked question at markbt/streampager#61 |
4 tasks
yuja
force-pushed
the
push-vwqpwvoxokrt
branch
from
193516d to
7ea0283
Compare
yuja
force-pushed
the
push-vwqpwvoxokrt
branch
3 times, most recently
from
2c07fa0 to
b2e8fdf
Compare
yuja
changed the title
|
Updated dependency to sapling-streampager. |
This helps work around dependency version conflicts with streampager.
Perhaps, the "windows" feature was enabled through "minus" or "scm-record". If I removed "minus", the Windows build of crossterm 0.27.0 failed.
yuja
force-pushed
the
push-vwqpwvoxokrt
branch
from
b2e8fdf to
097b69f
Compare
The WTFPL license is added to the allow list. I've never heard about this license, but it's basically the same as public domain according to wikipedia.
According to the discussion on Discord, streampager is still maintained. It brings more dependencies, but seems more reliable in our use case. For example, the streampager doesn't consume inputs indefinitely whereas minus does. We can also use OS-level pipe to redirect child stderr to the pager.
yuja
force-pushed
the
push-vwqpwvoxokrt
branch
from
097b69f to
7bf4644
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
If applicable:
CHANGELOG.md