Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: include error sources in pager warning #4206

Merged
merged 1 commit into from
Aug 5, 2024
Merged

Conversation

yuja
Copy link
Contributor

@yuja yuja commented Aug 4, 2024

Extracted from #4203

Checklist

If applicable:

  • I have updated CHANGELOG.md
  • I have updated the documentation (README.md, docs/, demos/)
  • I have updated the config schema (cli/src/config-schema.json)
  • I have added tests to cover my changes

An error in builtin pager can be nested.
Copy link
Contributor

@ilyagr ilyagr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess you are doing this for parity with other errors jj prints? Or do you know a case where it makes a difference?

In any case, it can't hurt.

@yuja
Copy link
Contributor Author

yuja commented Aug 5, 2024

I guess you are doing this for parity with other errors jj prints? Or do you know a case where it makes a difference?

MinusError is now printed as "Failed to initialize the terminal: The standard output is not a valid terminal", etc. It's not super important here, but sometimes the outermost error message is useless.

@yuja yuja merged commit ce2bc8d into jj-vcs:main Aug 5, 2024
17 checks passed
@yuja yuja deleted the push-krqouoymtllt branch August 5, 2024 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants