Fix bounds checks on Focus::narrow and split_at #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 20, 2025
kevinaboos
added a commit
to project-robius/matrix-rust-sdk
that referenced
this pull request
Jan 25, 2025
A bounds check was recently relaxed in `imbl`'s `Focus::narrow()` function: jneem/imbl#89, which fixed a bug that would cause a panic if the downstream user of `matrix-sdk-ui` attempted to narrow a focus of Timeline items using a range that included the last item in the Timeline. Example: project-robius/robrix#330 This fix has been incorporated in `eyeball-im` and `eyeball-im-util` and has been tested by me to no longer trigger upon the aforementioned conditions.
jplatte
pushed a commit
to matrix-org/matrix-rust-sdk
that referenced
this pull request
Jan 25, 2025
A bounds check was recently relaxed in `imbl`'s `Focus::narrow()` function: jneem/imbl#89, which fixed a bug that would cause a panic if the downstream user of `matrix-sdk-ui` attempted to narrow a focus of Timeline items using a range that included the last item in the Timeline. Example: project-robius/robrix#330 This fix has been incorporated in `eyeball-im` and `eyeball-im-util` and has been tested by me to no longer trigger upon the aforementioned conditions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that these methods were more restrictive than necessary, as compared to subslicing a slice (or even Vector::slice), making it hard (though not impossible) to end up with an empty Focus. Additionally
narrow()allowed its end index to go pastlen()which could lead to other problems.I added some tests for these methods too.