Upgrade imbl, eyeball-im, eyeball-im-util to fix bounds check
#4583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A bounds check was recently relaxed in `imbl`'s `Focus::narrow()` function: jneem/imbl#89, which fixed a bug that would cause a panic if the downstream user of `matrix-sdk-ui` attempted to narrow a focus of Timeline items using a range that included the last item in the Timeline. Example: project-robius/robrix#330 This fix has been incorporated in `eyeball-im` and `eyeball-im-util` and has been tested by me to no longer trigger upon the aforementioned conditions.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4583 +/- ##
==========================================
- Coverage 85.41% 85.41% -0.01%
==========================================
Files 286 286
Lines 32213 32213
==========================================
- Hits 27516 27515 -1
- Misses 4697 4698 +1 ☔ View full report in Codecov by Sentry. |
jplatte
approved these changes
Jan 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bounds check was recently relaxed in
imbl'sFocus::narrow()function: jneem/imbl#89, which fixed a bug that would cause a panic if the downstream user ofmatrix-sdk-uiattempted to narrow a focus of Timeline items using aRangethat included the last item in the Timeline. Example: project-robius/robrix#330This fix has been incorporated in
eyeball-imandeyeball-im-utiland has been tested by me in Robrix to no longer trigger upon the aforementioned conditions.Signed-off-by: Kevin Boos [email protected]