Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Direct3d Pixel Shaders & Scaler won´t work #3316

Closed
2 tasks done
Starfoxfs opened this issue Mar 6, 2022 · 3 comments
Closed
2 tasks done

Direct3d Pixel Shaders & Scaler won´t work #3316

Starfoxfs opened this issue Mar 6, 2022 · 3 comments
Labels

Comments

@Starfoxfs
Copy link

Code of Conduct & Contributing Guidelines

  • I agree to follow the code of conduct and the contributing guidelines.

Have you checked that no other similar bug report(s) already exists?

  • I have searched and didn't find any similar issues.

What operating system(s) this bug have occurred on?

Windows 11 21H2

What version(s) of DOSBox-X have this bug?

Dosbox-X 0.83.23 SDL2 Visual Studio Win64

Describe the bug

The Direct3D Pixel Shaders and the Scaler will not work in Dosbox-X 0.83.23 SDL2 64bit Visual Studio Build.

Expected behavior

OpenGL and OpenGL Shaders work.

Scaler have no effect
Direct3d Pixel Shader have no effect

Steps to reproduce the behaviour

  1. Start Dosbox-X
  2. Pixel Shaders stored in shaders Directory
  3. Select Direct3D as Output in Video Menue
  4. Select D3D Pixel Shader in Video Menue

Used configuration

Output = direct3d


frameskip      = 0
aspect         = false
char9          = true
euro           = -1
doublescan     = true
scaler         = normal2x
glshader       = none
pixelshader    = none
autofit        = true
monochrome_pal = green

and 

frameskip      = 0
aspect         = false
char9          = true
euro           = -1
doublescan     = true
scaler         = normal2x
glshader       = none
pixelshader    = ColorSketch.fx
autofit        = true
monochrome_pal = green

Emulator log

No response

Additional context

No response

@Starfoxfs Starfoxfs added the bug label Mar 6, 2022
@Starfoxfs
Copy link
Author

Update: Shaders works if Doublescan is disabled, but Direct3d Pixel Shaders still don't work.

@maron2000
Copy link
Contributor

According to the source code, it uses D3DXCreateEffectCompilerFromFile function (link).
It requires d3dx9 library so I think you need to install Direct X9 runtime to work on Windows10 and 11.

// cited from ScalingEffect.cpp
// First create an effect compiler
    HRESULT hr = D3DXCreateEffectCompilerFromFile(filename, NULL, NULL, 0,
						&lpEffectCompiler, &lpErrors);

Shaders work fine on my Windows8.1 PC.
This issue is a duplicate of #2884

@Starfoxfs
Copy link
Author

Hi,
ok thanks for the Info. I don´t know that it needs Directx9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants