[4.0] [a11y] Multilingual Associations buttons #23989
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It it looks like a button and acts like a button then it should be a <button> This PR makes sure that the two buttons to select and clear an association are real buttons
Quy
reviewed
Feb 22, 2019
| @@ -75,6 +75,7 @@ protected function getInput() | |||
| $html[] = '<button' | |||
| . ' class="btn btn-secondary' . ($value ? '' : ' hidden') . '"' | |||
| . ' onclick="return Joomla.submitbutton(\'undo-association\');"' | |||
| . ' type="button"' | |||
There was a problem hiding this comment.
The inline js has to be replaced
There was a problem hiding this comment.
@HLeithner thats beyond the scope of the pr which was just to make it a button
There was a problem hiding this comment.
I only wanted to notice.
Is the layout changed because you rewite css is outofscope of this pr.
|
No layout change. It just looks bad |
|
Extraneous |
|
Note: some changes from 3.9 are not yet forwarded to 4.0 and there are other errors in the functionality (Reference not loaded) YES, I KNOW it is not related to this PR. Just useful to remember. |
|
Why close it? It makes sense afterdeleting |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It it looks like a button and acts like a button then it should be a
This PR makes sure that the two buttons to select and clear an association are real buttons
Any styling issues are beyond the scope of this PR