Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] [a11y] Multilingual Associations buttons #23989

Closed
wants to merge 2 commits into from
Closed

[4.0] [a11y] Multilingual Associations buttons #23989

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dbd4b46
[4.0] [a11y] Multilingual Associations buttons
brianteeman Feb 22, 2019
3a7f689
oops
brianteeman Feb 22, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions administrator/components/com_associations/Field/Modal/AssociationField.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,13 +59,13 @@ protected function getInput()
$urlSelect = $linkAssociations . '&' . Session::getFormToken() . '=1';

// Select custom association button
$html[] = '<a'
$html[] = '<button'
. ' id="select-change"'
. ' class="btn btn-secondary' . ($value ? '' : ' hidden') . '"'
. ' data-toggle="modal"'
. ' data-select="' . Text::_('COM_ASSOCIATIONS_SELECT_TARGET') . '"'
. ' data-change="' . Text::_('COM_ASSOCIATIONS_CHANGE_TARGET') . '"'
. ' role="button"'
. ' type="button"'
. ' href="#associationSelect' . $this->id . 'Modal">'
. '<span class="icon-file" aria-hidden="true"></span> '
. '<span id="select-change-text"></span>'
Expand All @@ -75,6 +75,7 @@ protected function getInput()
$html[] = '<button'
. ' class="btn btn-secondary' . ($value ? '' : ' hidden') . '"'
. ' onclick="return Joomla.submitbutton(\'undo-association\');"'
. ' type="button"'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert since it has onclick?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The inline js has to be replaced

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah oops

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HLeithner thats beyond the scope of the pr which was just to make it a button

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only wanted to notice.

Is the layout changed because you rewite css is outofscope of this pr.

. ' id="remove-assoc">'
. '<span class="icon-remove" aria-hidden="true"></span> ' . Text::_('JCLEAR')
. '</button>';
Expand Down