[4.0] Active menu does not exist, fatal error #31100

sakiss · 2020-10-15T14:25:30Z

Pull Request for Issue # .
#30812

Summary of Changes

$app->getMenu()->getActive();
can return a MenuItem or null

by calling a function when null is returned, it generates a fatal error.

Testing Instructions

Add a dummy/non existent ItemId in your non sef urls.
E.g. /index.php?option=com_content&view=article&id=2:another-article&catid=9&itemId=5000
In that case there is no menu item with id 5000

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

No fatal error

Documentation Changes Required

No

SharkyKZ · 2020-10-15T14:34:33Z

Can you do it the same as in error.php?

joomla-cms/templates/cassiopeia/error.php

Lines 28 to 29 in f4b2644

    
           $menu     = $app->getMenu()->getActive(); 
        
           $pageclass = $menu !== null ? $menu->getParams()->get('pageclass_sfx', '') : '';

Otherwise $pageclass is undefined when no menu item.

richard67 · 2020-10-15T15:11:24Z

@SharkyKZ This PR here changes error.php, too, and I don't understand why. It was ok like it was before, or not? Am I missing something?

richard67 · 2020-10-15T15:15:27Z

@sakiss Please revert your change in error.php. It was good like it was before, using the ternary expression, and you now introduced an error with undefined $pageclass when there is no menu item. And as @SharkyKZ suggested please change index.php so it uses the same ternary expression as error.php does without your change.

richard67 · 2020-10-15T19:05:01Z

@sakiss And in addition to the above comment, please update the branch of this PR to the latest 4.0-dev branch of the CMS repository, not of your fork. It seems your 4.0-dev branch was very outdated when you have created this PR and the other one, #31099 based on it, because both PRs fail in our automated test due to outdated testing configuration from before February.

Let me know if you need help with.

Thanks in advance.

templates/cassiopeia/error.php

richard67 · 2020-10-16T09:51:02Z

Added the "Updates Requested" label so it's clear for testers that this PR needs changes as specified in review comments above.

…from 3.10 (joomla#30383) * Move mod_version to position "status" on update from 3.10 * Revert "Move mod_version to position "status" on update from 3.10" This reverts commit 71719e1. * Move mod_version to the right place when updating from 3.10 * SQL CS even if I don't like this but it seems to be commonly used

* Check multilanguage setting to display language column * Optimize code * Apply check to Contacts and Newsfeeds * Add multilanguage check * Check frontend too * Revert

) * [4.0] Installation: Adding a hint in Password field * fix accessibility * Added small

* [4.0] Fix Safari issue with overflow hidden * correcting scss format * Another solution adapted to various versions of Safari * scss cs * scss cs * last scss cs...

* [4.0] URL LANGUAGE CODE is not a prefix * modified desc as suggested

children

* Add Icon Webpage to contact config * add webpage to the list, add alt-texts to images, remove the old images * if no image is set, use an icon instead * add an icon for msc information * remove old icons for contact * remove spaces, indent * phpcs shoter lines, phpcs * replace empty(..) by !( ) * Update components/com_contact/tmpl/contact/default_address.php Co-authored-by: Quy <[email protected]> * Update components/com_contact/tmpl/contact/default_address.php Co-authored-by: Quy <[email protected]> * Update components/com_contact/tmpl/contact/default_address.php Co-authored-by: Quy <[email protected]> Co-authored-by: Quy <[email protected]>

Removes the margin bottom from tables included in cpanel cards.

Add missing import so that "Exception\ResourceNotFound" is correctly resolved.

* Move calls out of the loop * Combine pathinfo() calls

…a#31066) Variable key is used in both the inner and outer foreach loops which could cause issues (it doesn't but it could, and is code smell reported by phpStorm)

Return value type is not compatible with declared type in PHPDoc block

This fixes joomla#30967. When empty searches are allowed and the search is non-empty, but not matching, then it shouldn't return any results.

…app (joomla#31060) * Update PHPDoc comment to match method signatures in installation app * Update PHPDoc comment to match method signatures in installation app * code style * Update installation/src/Application/InstallationApplication.php Co-authored-by: Richard Fath <[email protected]> * Update installation/src/Application/InstallationApplication.php Co-authored-by: Richard Fath <[email protected]> * Update installation/src/Application/InstallationApplication.php Co-authored-by: Richard Fath <[email protected]> Co-authored-by: Richard Fath <[email protected]>

* [4.0] Share image link Steps to reproduce the issue Go to media manager in admin, select an image and select to get the shareable link. click "Get shareable link" Expected result When clicking the copy button, the left border doesn't disappear Actual result left border of the copy button disappears on click, and on any click/selection of the actual url * cs

…a#31057)

…s planed (joomla#30986)

Fix paths in codeowners file.

…31051)

cs fix

sakiss · 2020-10-16T17:58:21Z

I am closing this due to conflicts. Will open a new one.

joomla-cms-bot added the PR-4.0-dev label Oct 15, 2020

Quy mentioned this pull request Oct 15, 2020

[4.0][Cassiopea] Wrong ItemId: Call to a member function getParams() on null #30812

Closed

richard67 mentioned this pull request Oct 15, 2020

[4.0] Finder pagination #31099

Merged

wilsonge reviewed Oct 15, 2020

View reviewed changes

templates/cassiopeia/error.php Outdated Show resolved Hide resolved

richard67 added the Updates Requested Indicates that this pull request needs an update from the author and should not be tested. label Oct 16, 2020

infograf768 and others added 20 commits October 16, 2020 20:48

seperating multiple messages with border top

7cc2d74

[4.0] Ignore null results in events (joomla#30408)

61d699b

[4.0] Fix debuguser/debuggroup icon color (joomla#30414)

bf872f2

[4.0] Hide language column if not multilanguage in modal (joomla#30344)

1794991

* Check multilanguage setting to display language column * Optimize code * Apply check to Contacts and Newsfeeds * Add multilanguage check * Check frontend too * Revert

[4.0] Installation: Adding a hint on top of Password field (joomla#30402

4154ef1

) * [4.0] Installation: Adding a hint in Password field * fix accessibility * Added small

Remove coloring from icons (joomla#30415)

f912a01

[4.0] Fix multilingual status icons colors (joomla#30411)

22e1bfe

Increase minimum length

3148ce0

Fix meter displaying complete message prematurely

40e3e31

Add strenthmeter attribute to installation

42f8943

[4.0] Fix Safari issue with overflow hidden (joomla#30420)

ab32ea8

* [4.0] Fix Safari issue with overflow hidden * correcting scss format * Another solution adapted to various versions of Safari * scss cs * scss cs * last scss cs...

Change meter values to display green when password requirements are met

3bec1c6

[4.0] {Cassiopea] Implementing Password length/meter

ccf78d4

[4.0] Fix Fieldset description display (joomla#30435)

3212941

[4.0] Url Language Code is not a prefix (joomla#30440)

bb52fb0

* [4.0] URL LANGUAGE CODE is not a prefix * modified desc as suggested

[4.0] Implementing display of fieldset descriptions for fieldset

597855f

children

Taking off description

62a5310

scss cs

bb78b6d

use @Quy suggestion

a74d812

chmst and others added 20 commits October 16, 2020 20:49

[4.0] Extra space cpanel tables (joomla#31030)

3c93dcd

Removes the margin bottom from tables included in cpanel cards.

Add missing import for exception (joomla#31081)

9de1502

Add missing import so that "Exception\ResourceNotFound" is correctly resolved.

[4.0] Move calls out of the loop (joomla#31080)

498f265

* Move calls out of the loop * Combine pathinfo() calls

Variable key is used in both the inner and outer foreach loops (jooml…

4d32c98

…a#31066) Variable key is used in both the inner and outer foreach loops which could cause issues (it doesn't but it could, and is code smell reported by phpStorm)

Return value type is not compatible with declared (joomla#31061)

b30361a

Return value type is not compatible with declared type in PHPDoc block

[4.0] Non-empty, non-matching searches shouldn't return anything (31040)

912a5d6

This fixes joomla#30967. When empty searches are allowed and the search is non-empty, but not matching, then it shouldn't return any results.

Remove unused array - Array is only updated, but never queried (jooml…

c0dc31e

…a#31057)

Correcting addInline() to support WebAssetItemInterface and String, a…

cbc02da

…s planed (joomla#30986)

Fixed frontend module editing for non-superusers. (joomla#30779)

aa6241e

Fix paths (joomla#31102)

4f28a12

Fix paths in codeowners file.

Remove unused namespace declaration (joomla#31007)

952d00d

Fixing "expand all" for com_finder (joomla#31073)

740ae3e

Return is unnecessary as the last statement in a void method (joomla#…

8451623

…31051)

no need to check again code.edit.state

44c9265

[4.0] Fix retrieving articles for contact (joomla#31107)

9433cf3

Update HtmlView.php

f15a3fe

cs fix

Use of ternary instead of if

53f4e77

sakiss requested review from bembelimen, HLeithner, laoneo, rdeutz and zero-24 as code owners October 16, 2020 17:52

joomla-cms-bot added the Unit/System Tests label Oct 16, 2020

sakiss closed this Oct 16, 2020

sakiss deleted the active_menu_null branch October 16, 2020 17:58

sakiss mentioned this pull request Oct 19, 2020

[4.0] Active menu does not exist, fatal error #31156

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[4.0] Active menu does not exist, fatal error #31100

[4.0] Active menu does not exist, fatal error #31100

sakiss commented Oct 15, 2020

SharkyKZ commented Oct 15, 2020

richard67 commented Oct 15, 2020

richard67 commented Oct 15, 2020

richard67 commented Oct 15, 2020

richard67 commented Oct 16, 2020

sakiss commented Oct 16, 2020

[4.0] Active menu does not exist, fatal error #31100

[4.0] Active menu does not exist, fatal error #31100

Conversation

sakiss commented Oct 15, 2020

Summary of Changes

Testing Instructions

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Documentation Changes Required

SharkyKZ commented Oct 15, 2020

richard67 commented Oct 15, 2020

richard67 commented Oct 15, 2020

richard67 commented Oct 15, 2020

richard67 commented Oct 16, 2020

sakiss commented Oct 16, 2020