[5.2] Enhance translation "Empty trash"

[chmst]

Pull Request for Issue #41106 .
Replacement of #41116.

Summary of Changes

Replace the text "Empty trash" as proposed in #41106.

Testing Instructions

Check a trash can before and after patch

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Link to documentations

Please select:

• Documentation link for docs.joomla.org:

• No documentation changes for docs.joomla.org needed

• Pull Request link for manual.joomla.org:

• No documentation changes for manual.joomla.org needed

[Quy]

Is Permanently necessary? See under Users, Media, Smart Search where the button is Delete only?

[chmst]

TBH - I have no opinion here, only want to get rid of the "empty trash".
Agree that we say only "delete" in other cases. Would bee nice to get a few opinions.

[brianteeman]

I am not too concerned about the selection. For me there is nothing wrong with the current text.

We put items in the trash (by changing the state)
Then we empty the trash.

That is the same language construct used in windows

[chmst]

Speaking for me:
When I empty a bin, I empty it completely, I don't pick out single items. This is why I would prefer the word "delete".
This is a UX thing, maybe @crystalenka s team can help.

Edit:

That is the same language construct used in windows

Windows does what I use to do with the bin "empty trash" == Empty completely.

[Quy]

Delete implies permanent so no need to mention it. See menu options when deleting a file in the recycle bin.

[chmst]

Interesting feature :) Changing the language string to "delete" is easy, of course.
But it is not the best solution. Because in users or menus we have the "delete" in the action dropdown.

If we are following the windows behaviour we must have:
The "empty trash" button which then really deletes the whole trash (after message "do you really want..." )
and a delete button in the action drop down menu.

This is a big action, as all our backend views are concerned.

[brianteeman]

This is a big action, as all our backend views are concerned.

Which is why its never been done before. it is also a potentially big b/c break for 3pd

[HLeithner]

For me the problem is not the text, instead the way to get there, 9 clicks to delete an item is the problem not if it's called "empty trash" or "delete" or "burn it down the house".

Edit: it's 9 clicks instead of 7

[brianteeman]

suggestions

remove the requirement to select an item before the empty trash button is active. if nothing is selected then everything is deleted. if something is selected then just delete the selected items

remove the "are you sure" confirmation. going from published to trashed should be enough of an opportunity to change your mind without being asked again

[HLeithner]

Additional to brians suggestions:
Add a button to go directly to the trash filter and allow "shift" + "trash button" to directly delete items (like any system allows this) and change the text if shift button is hold down.

[chmst]

@HLeithner fully agree.
I would like a quick icon "thrash" in the dashboard which allows managing all trash in one step - like global checkin.
This would be self explaining also for newbies.

But not in scope here :)

[brianteeman]

I would like a quick icon "thrash" in the dashboard which allows managing all trash in one step - like global checkin.

I tried to write that some time ago but my code was not good.

Additional to brians suggestions:
Add a button to go directly to the trash filter and allow "shift" + "trash button" to directly delete items (like any system allows this) and change the text if shift button is hold down.

if that is possible then great - not something I have seen in a web ui before

[chmst]

allow "shift" + "trash button" to directly delete items (like any system allows this) and change the text if shift button is hold down.

This is a developer solution but I am advocate of normal users, I doubt if this is self-explaining and a11y ?

[HLeithner]

if that is possible then great - not something I have seen in a web ui before

it's basically the same as the joomla shortcuts, something like this:

document.querySelector('body').addEventListener("keydown", (e) => {      
  if (e.key === "Shift") {
    result.innerText = "Shift Key Pressed";
  }
});

document.querySelector('body').addEventListener("keyup", (e) => {      
  if (e.key === "Shift") {
    result.innerText = "Shift Key Not Pressed";
  }
});

[HLeithner]

allow "shift" + "trash button" to directly delete items (like any system allows this) and change the text if shift button is hold down.

This is a developer solution but I am advocate of normal users, I doubt if this is self-explaining and a11y ?

you can explain it in a guided tour, but it's also only an additonal way

[brianteeman]

Removing the "are you sure" is a simple one line change in each component for example delete this line

joomla-cms/administrator/components/com_content/src/View/Articles/HtmlView.php

Line 231 in c944137

->message('JGLOBAL_CONFIRM_DELETE')

Making the button deleteAll without having selected anything is a bigger change as that is in the library

[coolcat-creations]

I love this PR, It confuses so much of my customers that its called Empty trash but does not do it

[HLeithner]

Changing the meaning of a language string is a b/c break and not allowed at all per policy if we like to use "Delete" as string instead of "Empty Trash" then we need a new language string and use this one. Also "Delete Permanently" is redundant language as mentioned by @Quy

[HLeithner]

This pull request has been automatically rebased to 5.1-dev.

[RickR2H]

I have tested this item ✅ successfully on 500df90

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41119.}

[viocassel]

I have tested this item ✅ successfully on 500df90

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41119.}

[HLeithner]

Yes please create a new translation string, and make it simple, maybe use "Nuke" ;-)

[paternax]

I have tested this item ✅ successfully on 500df90

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41119.}

[fgsw]

I have tested this item ✅ successfully on 500df90

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41119.}

[tecpromotion]

Yes please create a new translation string, and make it simple, maybe use "Nuke" ;-)

@chmst is that still up to date? Any plans for 5.1?

[Quy]

Maybe do it like Clear Cache. Add Delete and either keep Empty Trash or change to Delete All.

[crimle]

I have tested this item ✅ successfully on 500df90

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41119.}

[HLeithner]

This pull request has been automatically rebased to 5.2-dev.

[dorisdreher]

I have tested this item ✅ successfully on 500df90

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41119.}

[richard67]

There are still updates requested, see #41119 (comment) .

[ChrisHoefliger]

I have tested this item ✅ successfully on 500df90

I have tested this successfully, the new text seems more plausible.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41119.}

[brianteeman]

6.1.6 Language keys
Changing or deleting a language key is considered a backwards compatibility break. Adding new ones is not. Substantially changing the meaning associated with a language key is a compatibility break. Rephrasing something for a more accurate description or proper en-GB grammar is not.

[richard67]

@brianteeman I am not really sure how to categorize, if it’s substantially changing the meaning or if it’s just rephrasing for better understanding.

Update; Ah, I see it was discussed already above.

[crimle]

Here the meaning of this language string is in fact being changed. But in this case a b/c break must be taken into consideration, since the button's current caption «Empty trash» is not only misunderstanding but obviously wrong.

«Empty trash» means literally «Delete any items that are currently in the trash, regardless if they are selected or not selected». Careful and inexperienced users are reluctant to use this button because they fear losing the whole content of the trash.

By the way: Microsoft Windows is handling this exactly the same way. The Windows button «Empty trash» removes any item that is currently in the trash.

«Remove from trash» makes it obvious that selected items are affected only.

«Delete permanently» is acceptable as well, although in my opinion «Remove from trash» is slightly more precise. «Delete permanently» focuses on the result of the action (the selected items can not be restored after this action) wheras «Remove from trash» exactly describes what will be going on by pressing this button.

@Quy points out that «permanently» is a redundant word. «You can't delete something unpermanently». Yes you can! Any item that is being moved to a location called «trash» is deleted unpermanently since it can be undeleted if necessary. When you remove the item form the trash you delete it permanently since there will be no way to undo the process.

From a user's point of view «Delete permanently» is a precise wording.

[brianteeman]

@crimle you completely missed the fact that every time you press the "empty trash" button you are asked to confirm that you want to permanently delete the items. Therefor if the wording is changed to delete permanently the word permanently is a redundant superflous word and not needed.

[HLeithner]

I set this pr on the next maintainer meeting and requested a change from "Empty Trash" (JTOOLBAR_EMPTY_TRASH) to "Delete" (JTOOLBAR_DELETE), so hopefully we have a decision next week...

[crimle]

I agree with «Delete». It is simple and very good as well. Together with the following confirmation request, it is quite clear what's going on. By the way, the confirmation text looks a bit clumsy to me:
«Are you sure you want to delete? Confirming will permanently delete the selected item(s)!»
What about
«Do you want to permanently delete the selected item(s)?»
It's shorter and consists of one sentence only.

[chmst]

Sorry for delay, I have changed the button to Delete.
This is a minmum consent and schould not be a b/c break and can go into 5.2

For a few good suggestions I will make new issues / PRs as they are not in scope or need much more coding.

• Shorter text for the delete - confirmation
• Improve usability of our trash management

[HLeithner]

I think changing the text is wrong or at least unexpected for others, using the JTOOLBAR_DELETE language tag in the relevant function should work better

[chmst]

@HLeithner points out that changing the meaning of a language stribg is a b/c break

I don't agree that this changes the meaning of the language string. In my opinion it is a bug fix in usability. But I am ok with moving this to 6.0.

[brianteeman]

+100 @HLeithner

While it might be "safe to change" in core this is a global language string and we have no way of knowing how it is used in 3pd extensions where it may even be used without listCheck(true);

[chmst]

I think changing the text is wrong or at least unexpected for others, using the JTOOLBAR_DELETE language tag in the relevant function should work better

ok