Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Language string DELETE_FROM_TRASH and replace alle occurences of … #43841

Merged
merged 3 commits into from
Jul 31, 2024

Conversation

chmst
Copy link
Contributor

@chmst chmst commented Jul 24, 2024

Pull Request for Issue #41106 .
Replacement for PR #41119.

Summary of Changes

The String "Empty Trash"in list views is replaced by "Delete". To avoid a b/c break by modifying the Language String a new Languages string has been added.

Testing Instructions

Code review, have a look on list views when the state filter is set to "trashed"

Actual result BEFORE applying this Pull Request

The Button says "Empty Trash"

Expected result AFTER applying this Pull Request

The Button says "Delete"

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-5.2-dev labels Jul 24, 2024
@brianteeman
Copy link
Contributor

As I wrote on the original PR

For me there is nothing wrong with the current text.

We put items in the trash (by changing the state) Then we empty the trash.

That is the same language construct used in windows

Technically this PR is correct however

@LadySolveig
Copy link
Contributor

I have tested this item ✅ successfully on e66327e


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43841.

@Quy
Copy link
Contributor

Quy commented Jul 24, 2024

Why add another string? Use JTOOLBAR_DELETE.

@brianteeman
Copy link
Contributor

Why add another string? Use JTOOLBAR_DELETE.

because it is a b/c break as it is more than a grammar or typo correction. See original PR for more

@Quy
Copy link
Contributor

Quy commented Jul 24, 2024

@HLeithner suggested the same thing. #41119 (comment)

@Hackwar Hackwar added RTC This Pull Request is Ready To Commit and removed RTC This Pull Request is Ready To Commit Language Change This is for Translators UI/UX PR-5.2-dev labels Jul 27, 2024
@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-5.2-dev RTC This Pull Request is Ready To Commit labels Jul 27, 2024
@rdeutz rdeutz enabled auto-merge (squash) July 31, 2024 17:05
@HLeithner
Copy link
Member

@HLeithner suggested the same thing. #41119 (comment)

was a bad idea

@Iniestaso
Copy link

Please describe millestone 5.2, this PR is not visible to translators. I only discovered it when comparing versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Language Change This is for Translators PR-5.2-dev
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants