-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Language string DELETE_FROM_TRASH and replace alle occurences of … #43841
Conversation
As I wrote on the original PR
Technically this PR is correct however |
I have tested this item ✅ successfully on e66327e This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43841. |
Why add another string? Use |
because it is a b/c break as it is more than a grammar or typo correction. See original PR for more |
@HLeithner suggested the same thing. #41119 (comment) |
was a bad idea |
Please describe millestone 5.2, this PR is not visible to translators. I only discovered it when comparing versions. |
joomla/joomla-cms#43232 + joomla/joomla-cms#43378 + joomla/joomla-cms#43216 + joomla/joomla-cms#43260 + joomla/joomla-cms#43386 + joomla/joomla-cms#43575 + joomla/joomla-cms#43491 + joomla/joomla-cms#43760 - (upmerge, внесено в 5.1х) joomla/joomla-cms#43247 + joomla/joomla-cms#43579 + joomla/joomla-cms#43690 + joomla/joomla-cms#43829 + joomla/joomla-cms#43840 + joomla/joomla-cms#43841 + joomla/joomla-cms#43885 - (upmerge, только для др. пакетов) joomla/joomla-cms#43223 + joomla/joomla-cms#43810 - (только для en-GB) joomla/joomla-cms#43898 + joomla/joomla-cms#43432 + joomla/joomla-cms#43870 + joomla/joomla-cms#42850 + joomla/joomla-cms#43937 - (upmerge, только для др. пакетов) joomla/joomla-cms#43862 + joomla/joomla-cms#43975 + joomla/joomla-cms#43910 + joomla/joomla-cms#43965 + joomla/joomla-cms#43738 + joomla/joomla-cms#43814 + joomla/joomla-cms#44000 + joomla/joomla-cms#44050 + (upmerge, с 4.4.9) joomla/joomla-cms#43966 + joomla/joomla-cms#44065 +
Pull Request for Issue #41106 .
Replacement for PR #41119.
Summary of Changes
The String "Empty Trash"in list views is replaced by "Delete". To avoid a b/c break by modifying the Language String a new Languages string has been added.
Testing Instructions
Code review, have a look on list views when the state filter is set to "trashed"
Actual result BEFORE applying this Pull Request
The Button says "Empty Trash"
Expected result AFTER applying this Pull Request
The Button says "Delete"
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed