-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5.2] Vote : add aggregateRating in article's schemaorg information #42933
Conversation
Thanks for raising hand. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42933. |
This fix works with Joomla! 5.0 but, as there won't be any more 5.0 release, I put it in 5.1 branch. |
I have experienced the same issue. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42933. |
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42933. |
This issue also concerns Joomla 4. |
@ManuelVoileux Does that mean a successful test? If so, please go to the issue tracker here https://issues.joomla.org/tracker/joomla-cms/42933 and mark your test result by using the blue "Test this" button at the top left corner, then selecting the appropriate test result (success) and submit. Every pull request needs 2 successful human tests, and it needs to submit the test result with the issue tracker so the tests are properly counted. Thanks in advance. |
@conseilgouz If this is right, it would need to make this pull request for the 4.4-dev branch. Later maintainers will merge it up into the 5.1-dev branch when the 4.4-dev PR will have been tested and merged. |
This solution is correct for J4 which uses itemprop etc |
I have tested this item ✅ successfully on ceb86b1 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42933. |
Not that easy. The page does not contain Product, how it can have the product rating then? Just try https://search.google.com/test/rich-results?hl=en
It will ask you for full product information. |
A better fix would be to remove all HTML schema from layout |
If the Schema tab is filled in, the itemscope, itemtype should be taken from the schema type, and the rating result should be merged in the schema output. |
Correct, that what I mean in #42933 (comment) |
I had a doubt about Product type. This idea comes from JED pages : if you take a look at https://extensions.joomla.org/extension/cg-isotope/ source code, it's done this way and Google search gives me nice stars. |
Same code, same issue in Joomla 4.4. @richard67 : is 4.4-dev PR a new PR ? @conseilgouz You can rebase this PR here by changing the base branch with use of the "Edit" button right beside the title on GitHub, or you make a new one for the 4.4-dev branch, whatever is easier for you. |
Missing item name
closed, move to 4.4-dev branch #42934 |
You could have changed the branche here to move to 4.4 |
No, that not correct example. |
Product is a generic type, it could be anything : https://schema.org/Product In JED page, I did not find any other schema.org line other than reviews and aggregateRating, and Google seems to be happy with this. |
I tried but I broke it (I'm not a great github user). |
It may be more applicable to use ?
instead of:
Customer reviews: (Microdata) See examples |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42933. |
I have tested this item ✅ successfully on 556e59e This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42933. |
I have tested this item ✅ successfully on 556e59e This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42933. |
@cybersalt @growunder Thank you for your test. |
This pull request has been automatically rebased to 5.2-dev. |
Thanks @conseilgouz ! |
( see discussion #42920)
Summary of Changes
When vote plugin is enabled, Rich results are created but are rejected by Google Rich Results tool.
Testing Instructions
Enable Vote plugin.
Enable Voting in Articles component configuration.
Vote for one or more articles
Set different schemaorg type for your articles
Check your articles using https://search.google.com/test/rich-results
Actual result BEFORE applying this Pull Request
Google Rich Results check gives an error

Review snippets shows 2 errors :
Expected result AFTER applying this Pull Request
Google Rich Results check is OK

Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed