Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.4] Revert #42934, do not force Product schema for every article #43827

Merged
merged 2 commits into from
Aug 6, 2024

Conversation

Fedik
Copy link
Member

@Fedik Fedik commented Jul 23, 2024

Pull Request for Issue #43797 .

Summary of Changes

Do not force Product schema for every article
Revert #42934

Testing Instructions

Review

Actual result BEFORE applying this Pull Request

Product schema added to every article with Vote enabled

Expected result AFTER applying this Pull Request

No product schema

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:
  • No documentation changes for docs.joomla.org needed
  • Pull Request link for manual.joomla.org:
  • No documentation changes for manual.joomla.org needed

@Quy
Copy link
Contributor

Quy commented Jul 23, 2024

I have tested this item ✅ successfully on ec7a482


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43827.

1 similar comment
@viocassel
Copy link
Contributor

I have tested this item ✅ successfully on ec7a482


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43827.

@Quy
Copy link
Contributor

Quy commented Jul 23, 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43827.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jul 23, 2024
@Slava287
Copy link

Thanks, will this be fixed in future updates?

@bembelimen
Copy link
Contributor

Do we now have Google complaining again?

@brianteeman
Copy link
Contributor

If this is a full revert then the original issue will be present so that will still need to be fixed

@Fedik
Copy link
Member Author

Fedik commented Jul 24, 2024

Yes, but that is less critical than this one. I think

@laoneo laoneo merged commit 98a4b2a into joomla:4.4-dev Aug 6, 2024
3 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Aug 6, 2024
@laoneo
Copy link
Member

laoneo commented Aug 6, 2024

Merging this as it is done properly in #42933. Thanks for the help @Fedik.

@laoneo laoneo added this to the Joomla! 4.4.7 milestone Aug 6, 2024
@Fedik Fedik deleted the revert-42934 branch August 6, 2024 13:46
dgrammatiko pushed a commit to dgrammatiko/joomla-cms that referenced this pull request Aug 11, 2024
dgrammatiko pushed a commit to dgrammatiko/joomla-cms that referenced this pull request Aug 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error in microdata after updating to Joomla! 5.1.2 Stable
8 participants