-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.4] Revert #42934, do not force Product schema for every article #43827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have tested this item ✅ successfully on ec7a482 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43827. |
1 similar comment
I have tested this item ✅ successfully on ec7a482 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43827. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43827. |
Thanks, will this be fixed in future updates? |
Do we now have Google complaining again? |
If this is a full revert then the original issue will be present so that will still need to be fixed |
Yes, but that is less critical than this one. I think |
dgrammatiko
pushed a commit
to dgrammatiko/joomla-cms
that referenced
this pull request
Aug 11, 2024
dgrammatiko
pushed a commit
to dgrammatiko/joomla-cms
that referenced
this pull request
Aug 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #43797 .
Summary of Changes
Do not force Product schema for every article
Revert #42934
Testing Instructions
Review
Actual result BEFORE applying this Pull Request
Product schema added to every article with Vote enabled
Expected result AFTER applying this Pull Request
No product schema
Link to documentations
Please select: