-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5.2] Added link class selection to TinyMCE dialog #43260
Conversation
works great. I never would have found it on the advanced tab |
Co-authored-by: Brian Teeman <[email protected]>
Co-authored-by: Brian Teeman <[email protected]>
Co-authored-by: Brian Teeman <[email protected]>
I could move it to the first "Plugin" tab? Would that be a better option? |
…into tinymce-link-classes
I would prefer that. It is where I added all the other tinymce customisations in the past |
@brianteeman I added it to the first tab at the bottom. I also removed the description of the single fields and added an overall description. |
great - please update the description and screenshots in the original post to match |
I have tested this item ✅ successfully on 0f4bbcb This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43260. |
Co-authored-by: Quy <[email protected]>
Co-authored-by: Quy <[email protected]>
Co-authored-by: Quy <[email protected]>
I have tested this item ✅ successfully on 96ee302 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43260. |
@brianteeman could you please do one more test? Code is fine now... |
@RickR2H Please rebase for v5.2 as this will be considered as a new feature. Only bug fixes will be merged in v5.1. Thank you! |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43260. |
Restored tests as latest changes are cs only. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43260. |
Thanks @RickR2H ! |
joomla/joomla-cms#43232 + joomla/joomla-cms#43378 + joomla/joomla-cms#43216 + joomla/joomla-cms#43260 + joomla/joomla-cms#43386 + joomla/joomla-cms#43575 + joomla/joomla-cms#43491 + joomla/joomla-cms#43760 - (upmerge, внесено в 5.1х) joomla/joomla-cms#43247 + joomla/joomla-cms#43579 + joomla/joomla-cms#43690 + joomla/joomla-cms#43829 + joomla/joomla-cms#43840 + joomla/joomla-cms#43841 + joomla/joomla-cms#43885 - (upmerge, только для др. пакетов) joomla/joomla-cms#43223 + joomla/joomla-cms#43810 - (только для en-GB) joomla/joomla-cms#43898 + joomla/joomla-cms#43432 + joomla/joomla-cms#43870 + joomla/joomla-cms#42850 + joomla/joomla-cms#43937 - (upmerge, только для др. пакетов) joomla/joomla-cms#43862 + joomla/joomla-cms#43975 + joomla/joomla-cms#43910 + joomla/joomla-cms#43965 + joomla/joomla-cms#43738 + joomla/joomla-cms#43814 + joomla/joomla-cms#44000 + joomla/joomla-cms#44050 + (upmerge, с 4.4.9) joomla/joomla-cms#43966 + joomla/joomla-cms#44065 +
* Added link list * Fix indentation * Fix missing space * Update plugins/editors/tinymce/tinymce.xml Co-authored-by: Brian Teeman <[email protected]> * Update administrator/language/en-GB/plg_editors_tinymce.ini Co-authored-by: Brian Teeman <[email protected]> * Update plugins/editors/tinymce/tinymce.xml Co-authored-by: Brian Teeman <[email protected]> * Move parameters to Plugin tab * Update plugins/editors/tinymce/forms/setoptions.xml Co-authored-by: Quy <[email protected]> * Update plugins/editors/tinymce/src/PluginTraits/DisplayTrait.php Co-authored-by: Quy <[email protected]> * Update plugins/editors/tinymce/tinymce.xml Co-authored-by: Quy <[email protected]> * Make CI happy * Remove empty line * Update plugins/editors/tinymce/src/PluginTraits/DisplayTrait.php --------- Co-authored-by: Brian Teeman <[email protected]> Co-authored-by: Quy <[email protected]>
Pull Request for Issue # .
Summary of Changes
Add a class selector to the "create link" dialog. The selected class will be added to the link. This can be very useful in styling links on the website. Adding Bootstrap button classes will convert the link to a button.
Testing Instructions
Actual result BEFORE applying this Pull Request
Adding classed only possible in the source code editor.
Expected result AFTER applying this Pull Request
Classes can be selected in the link dialog.
Link to documentations
Please select:
Documentation link for docs.joomla.org: (will be created after merging the PR)
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed