Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.2] [Guided Tours] unescaped quotes in a language string #44110

Merged
merged 2 commits into from
Sep 18, 2024

Conversation

tecpromotion
Copy link
Contributor

Pull Request for Issue # .

Summary of Changes

see #44106

add \

Testing Instructions

code review

Actual result BEFORE applying this Pull Request

class="fw-medium"

Expected result AFTER applying this Pull Request

class=\"fw-medium\"

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@sandewt
Copy link
Contributor

sandewt commented Sep 18, 2024

I have tested this item ✅ successfully on 20b5c7c

code revieuw


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44110.

@Quy
Copy link
Contributor

Quy commented Sep 18, 2024

I have tested this item ✅ successfully on 20b5c7c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44110.

@Quy
Copy link
Contributor

Quy commented Sep 18, 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44110.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Sep 18, 2024
@Hackwar Hackwar enabled auto-merge (squash) September 18, 2024 21:25
@Hackwar Hackwar added this to the Joomla! 5.2.0 milestone Sep 18, 2024
@Hackwar
Copy link
Member

Hackwar commented Sep 18, 2024

Thanks for your contribution @tecpromotion!

@Hackwar Hackwar disabled auto-merge September 18, 2024 21:54
@Hackwar Hackwar merged commit c5810f2 into joomla:5.2-dev Sep 18, 2024
3 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Sep 18, 2024
@tecpromotion tecpromotion deleted the fix-class-quotes-guided-tours branch September 18, 2024 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Language Change This is for Translators PR-5.2-dev
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants