Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Articles Module: (Re)Introduced dynamic mode as on mod_articles_category #44145

Merged
merged 5 commits into from
Sep 28, 2024

Conversation

drmenzelit
Copy link
Contributor

Pull Request for Issue # .

Summary of Changes

Added the option for dynamic mode as it was in mod_articles_category

Testing Instructions

Create a module selecting dynamic mode. Create some menu items for different categories and check if the module display the articles of the category dynamically

Inline help:

Please select the mode you would like to use. If Normal Mode is chosen, then configure the module and it will display a static list of Articles on the menu items you assign the module to. If Dynamic Mode is chosen, then you can still configure the module normally, however now the Category option will no longer be used. Instead, the module will dynamically detect if you are on a Category view and will display the list of articles within that Category. When Dynamic Mode is chosen, it is best to leave the module set to display on all pages, as it will decide to display anything dynamically.

Actual result BEFORE applying this Pull Request

No dynamic mode present

Expected result AFTER applying this Pull Request

The module display a list of articles depending on the category from the menu item

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-5.2-dev labels Sep 26, 2024
@Kostelano
Copy link
Contributor

Sorry, I wrote about the need to change the demo data plugin, but I didn't notice that it was already done.

@RickR2H
Copy link
Member

RickR2H commented Sep 27, 2024

I have tested this item ✅ successfully on 28cc184


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44145.

@Bodge-IT
Copy link

I have tested this item ✅ successfully on 28cc184

Tested on Cat Blog & List menu items.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44145.

@alikon
Copy link
Contributor

alikon commented Sep 28, 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44145.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Sep 28, 2024
@brianteeman
Copy link
Contributor

I thought we were in a language freeze for 5.2?

@Hackwar
Copy link
Member

Hackwar commented Sep 28, 2024

Yes, we are. And I'm unhappy with all of this, but the alternative is that we revert the whole articles module.

@Hackwar Hackwar merged commit ea1a413 into joomla:5.2-dev Sep 28, 2024
0 of 2 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Sep 28, 2024
@Hackwar Hackwar added this to the Joomla! 5.2.0 milestone Sep 28, 2024
@Hackwar
Copy link
Member

Hackwar commented Sep 28, 2024

Thank you for your contribution @drmenzelit!

@brianteeman
Copy link
Contributor

Yes, we are. And I'm unhappy with all of this, but the alternative is that we revert the whole articles module.

No - the alternative was to add dynamic mode as a new feature in a future release.

There is/was zero urgency at all to merge this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Language Change This is for Translators PR-5.2-dev
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants