-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Articles Module: (Re)Introduced dynamic mode as on mod_articles_category #44145
Conversation
Sorry, I wrote about the need to change the demo data plugin, but I didn't notice that it was already done. |
I have tested this item ✅ successfully on 28cc184 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44145. |
I have tested this item ✅ successfully on 28cc184 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44145. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44145. |
I thought we were in a language freeze for 5.2? |
Yes, we are. And I'm unhappy with all of this, but the alternative is that we revert the whole articles module. |
Co-authored-by: Quy <[email protected]>
Thank you for your contribution @drmenzelit! |
No - the alternative was to add dynamic mode as a new feature in a future release. There is/was zero urgency at all to merge this |
joomla/joomla-cms#44106 - (только для en-GB) joomla/joomla-cms#44075 + joomla/joomla-cms#44093 + joomla/joomla-cms#43694 + joomla/joomla-cms#44082 + joomla/joomla-cms#44110 - (только для en-GB) joomla/joomla-cms#44111 + joomla/joomla-cms#44105 + joomla/joomla-cms#44146 - (только для др. пакетов) joomla/joomla-cms#44142 + joomla/joomla-cms#44127 - (только для en-GB) joomla/joomla-cms#44132 + joomla/joomla-cms#44137 + joomla/joomla-cms#44145 +
Pull Request for Issue # .
Summary of Changes
Added the option for dynamic mode as it was in mod_articles_category
Testing Instructions
Create a module selecting dynamic mode. Create some menu items for different categories and check if the module display the articles of the category dynamically
Inline help:
Actual result BEFORE applying this Pull Request
No dynamic mode present
Expected result AFTER applying this Pull Request
The module display a list of articles depending on the category from the menu item
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed