Docker "make dev" WSL2 support #109
Conversation
- Makefile auto detects WSL and uses different yaml file
- Use catch all for server_name - Add port 80
docker/nginx/nginx.wsl.conf
Outdated
| access_log /var/log/nginx.access_log main; | ||
|
|
||
| location / { | ||
| proxy_pass http://127.0.0.1:3000/; |
There was a problem hiding this comment.
I think you could just change the other nginx config to be 127.0.0.1 to make it work with windows?
It would be better if the current nginx config wasn't on localhost anyways
There was a problem hiding this comment.
Want to give that try and see if you can delete this duplicate one?
There was a problem hiding this comment.
Deleted the nginx.wsl.conf file and tried using the original one with 127.0.0.1 instead of frontend and backend and it worked. But I'm suspicious as to if this would now work on other docker clients or does this break it?
- removes nginx.wsl.conf
|
Looking at this now it looks like a misguided you in saying we could have the nginx.conf support both. Technically we could if the original docker-compose was in host network mode, but to save some time I jsut ported over your change before I asked you to merge in the 2 nginx configs. |
Description:
Docker networking in WSL2 requires a different approach than Linux it seems, might have issues with other OS's. After lots of testing I managed to get this setup to work, might not be the best but everything seems to work. Before I was not able to localhost port 80 nor 443, just got timed out.
Related issue
Changes made:
docker-compose-dev.wsl.yaml- same as regular one but with host networkingnginx.wsl.conf- points to 127.0.0.1 instead of service namesNow:
Going to localhost works and redirects you to https://localhost which also works.
Everything else works as it did before, only when developing on windows using WSL you should now be able to access the website on https://localhost