Implement environment variables #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- added styling, new elements also
- delay wasnt actually working
- MIME type validation using regex patterns to support various vendor-specific formats - Created utils folder and moved file handlers to utils/files.js for better code organization - Now supports additional CSV MIME types (e.g., 'application/vnd.ms-excel')
- So contributors will hopefully all use consistent formatting
joshzcold
reviewed
Dec 28, 2024
joshzcold
reviewed
Dec 28, 2024
joshzcold
reviewed
Dec 28, 2024
joshzcold
reviewed
Dec 28, 2024
joshzcold
requested changes
Dec 28, 2024
- Also added some explaning comments
- Was causing errors
- Since we are slowly upgrading and starting to use .jsx, we need to update the file types that tailwind parses - Also to address the warning tailwind gives 'purge' is now 'content' and darkMode false is 'media' See https://tailwindcss.com/docs/upgrade-guide#configure-content-sources and https://tailwindcss.com/docs/upgrade-guide#remove-dark-mode-configuration
joshzcold
requested changes
Dec 29, 2024
- Also fix for ws image upload not using env var - Added better explanation in .env file
|
The title page logo/title sizing needs an overhaul, I've made a band-aid fix to it, but it should be simpler than what is currently done, also merge conflicts should be solved I'm not sure why it is still showing conflicts |
|
Waiting for #109 |
- Prevent server crash when accessing session array index without proper bounds checking. Previously, accessing session[1] would panic if cookie didn't contain colons.
- Send full session string on game view - Prevent player_not_found errors for spectator pings
- Add useEffect hook to set initial timer value when entering final round
joshzcold
requested changes
Dec 30, 2024
joshzcold
approved these changes
Dec 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #97
Fixes #93
Description:
Introduces 3 new env vars
Changes made:
56de767 solves #97, adds t("Join at") {link} to /game page
586dfd1 adds csv and image max upload size vars
29003ce fixes a setTimeout bug
e0db5e2 solves #93 by checking actual file extension, also introduces utils/ folder for commonly used JS functions
c8cf2b3 adds prettier config so contributors can format with the same settings