DayOne: Editing existing entries with tags removes the tags when saving #358

flight16 · 2015-05-31T08:37:09Z

Create a DayOne entry using DayOne.app and add a tag using the tag button at the top of the entry (don't include the tag in the body).
Click save and see that the entry is now tagged.
Close DayOne
Run jrnl dayone -n 1 --edit and edit the entry you just added, and save it.
Open DayOne and note that the latest entry is no longer tagged.

flight16 · 2015-06-01T01:40:49Z

This bug appears to have been caused by fd46ffe, but I haven't had time to investigate yet.

I think this highlights to missing tests:

A test to flex the --edit code path which launches an external editor and make sure data round-trips OK.
A test to verify the format of saved DayOne .xml to make sure it conforms to DayOne's expected format.

minchinweb · 2015-06-04T03:39:09Z

I've been able to confirm the issue.

I think it is somewhat related to #351.

It actually exists much earlier. It exists as of ea6060d and as of 3912693, which dates to last September. Which makes me wonder if it has ever worked...

The problem seems to be here -> DayOneJournal.py which calls this function -> Entry.py

Does 8f12d62 fix it?

Fixes jrnl-org#358, See also jrnl-org#159

stale · 2019-07-07T09:15:49Z

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Fixes jrnl-org#358, See also jrnl-org#159

stale · 2019-09-27T01:15:04Z

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

minchinweb · 2019-09-27T15:59:37Z

waiting on merge of PR #350

wren · 2019-09-27T23:12:24Z

@minchinweb Sorry, but it looks like #350 has merge conflicts again.

Honestly, I'm having some trouble with what to do with Day One functionality. I'm hoping we can talk it through a bit, since it seems to be an important feature for you.

The way I see it, the Day One functionality in jrnl needs some work to get it, and its tests, up to snuff. And then it also needs someone that can seriously commit to maintaining it long term. When I first started fixing up jrnl, I have to admit that the Day One functionality seemed like a top candidate for cutting out (for a variety of reasons that I'm happy to get into, if you're interested).

That being said, I want to respect the existing community of users, and especially existing contributors. If there's a feature that you value this much, I want to make sure it gets the attention it deserves.

I want to apologize for not being able to review your PRs in a timely manner. The main problem I'm having is that I have no way to run and/or test Day One Classic. And without it, I can't verify that a test entered into our current test suite works as intended. I also can't work on, or even review PRs that address Day One functionality in any meaningful way. So, whoever ends up fixing and maintaining the Day One functionality in jrnl, I don't think that person can be me.

All of that is to say, do you think that person can be you (or anyone else reading this)? Can you fix this part of jrnl and keep it maintained? If you want to make a serious commitment to do this, can we can talk through some steps to get this done? If not, that's perfectly fine. Either way, just let me know, and we can go from there.

minchinweb · 2019-10-02T01:09:06Z

Hi @wren,

Let me preface this discussion by saying that there are two versions of Day One: the "Classic" version, and the current version, "DayOne 2". The Classic version allowed you to sync to Dropbox, which made the entries easily accessible to anywhere else you have your Dropbox synced to. v2 includes a sync feature, but seems to only be through an inaccessible, proprietary system. v2 was launched in 2016 and the Classic version was quickly thereafter sunsetted and removed from the App store. Dropbox changed their API about a year ago and so even if you somehow had access to the original app, it's unlikely the Dropbox sync would work today.

I'd be happy to do the work to keep support for DayOne Classic in jrnl. Let's leave the discussion for DayOne v2 for another day (as I don't use it). I don't actually have a way to run Day One Classic either, but I'm not sure it's really needed. Supporting a dead program like this has the added bonus that the file format should be entirely stable, warts and all. If you want more confidence that the test suite is actually testing what we're trying to do, we can work on expanding that.

What this issue is about is just being able to roundtrip correctly. That should be simple to build into the test suite (although I see it hasn't really been done in the case of #350). What I can say is that I've been running #350 locally for probably two years without issue.

Let me know what you think should be in place to feel more confident in our DayOne code.

minchinweb · 2019-10-02T01:18:52Z

The merge conflict for #350 has been resolved, all the tests pass, and should be good to merge!

micahellison · 2019-10-06T00:16:52Z

Hi @minchinweb, I read through #350 and I'm a little confused about this. What is your use case for integrating Journaley with jrnl?

minchinweb · 2019-10-07T15:57:33Z

Journaley is a GUI client for DayOne Classic on Windows. Because both Journaley and jrnl read the DayOne Classic data files, I can use both to interact with my "journal". I use Journaley as an editing client for my daily work journal, and I use jrnl to covert that journal into a personal-use website (via Pelican).

wren · 2019-10-25T00:29:25Z

@minchinweb Thanks for the explanation about everything. If we want to proceed, I'd like to take a few steps to make sure this functionality is fully supported, and also doesn't affect the rest of the project in any negative way.

I must confess that having a feature that nobody can test in any meaningful way makes me very weary. But I'm willing to proceed if you are willing to handle all of the Day One-related issues. This is the plan I would like to follow:

Tests - Get a PR with the full set of Day One tests reinstated and updated to fully pass on the current version of jrnl. These should be separated into a Day One test file, and should, to the best of our ability, work on Mac and Windows. This PR should only have tests (no other code).
PRs - New PRs should be contained entirely in the jrnl/DayOneJournal.py file. If there needs to be any changes outside of that file, they should be filed as a separate PR, with an associated issue filed to justify the change. From then on, I will rubber-stamp any changes to jrnl/DayOneJournal.py that you approve without any further testing on my part.

What do you think?

minchinweb · 2019-10-28T02:31:43Z

@wren It sounds workable indeed; I'm happy to shepherd this along. If this doesn't work quite the way we haven imagined, we can always revisit our process. The only caveat that I would add is I intend to support only DayOne "Classic".

I'll start working on getting the pieces ready to cleanly merge. Is 2.5 the branch I should be targeting?

wren · 2019-10-28T20:31:06Z

@minchinweb Yup, v2.5 sounds good. You can submit PRs to master, though, and I'll update as needed to hit our milestones.

I agree about Classic. We're currently not in a place to support Day One 2. Would you mind updating the docs, to reflect that as part of this?

minchinweb · 2019-11-11T20:01:07Z

@wren #733 has been submitted to this end! Please let me know if there are any issues in getting it merged in.

wren · 2019-11-13T00:33:37Z

@minchinweb Is it possible for you to submit a PR first with just the tests for Day One, per the plan we agreed to above? It would make it a lot easier to review.

minchinweb · 2019-11-14T01:15:28Z

@wren : Created #742 with just DayOne tests! I didn't add any new tests, but just pulled in the ones that were previously removed.

stale · 2020-01-13T01:45:12Z

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

minchinweb · 2020-01-14T15:52:57Z

bump

stale · 2020-03-14T16:46:46Z

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

minchinweb · 2020-03-15T14:28:23Z

bump

wren · 2020-03-15T18:26:04Z

@minchinweb Thanks for the reminder. Are you still planning to submit the follow-up PR for this?

minchinweb · 2020-03-16T02:18:55Z

Yes, I intend to. The code is there in my previous omnibus PR's, I just need to figure out what code (from the omnibus PR) still needs to be merged in.

wren · 2020-03-16T03:33:15Z

Ah, okay. Just wanted to make sure you weren't waiting on me for anything. Let me know if you need anything.

Fixes jrnl-org#358, See also jrnl-org#159

stale · 2020-05-15T04:27:10Z

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

micahellison · 2020-05-16T17:49:01Z

Looks like there's a PR in progress for this issue. Bumping to keep it from staling out.

* Updating changelog [ci skip] * Incrementing version to v2.4 [ci skip] * [DayOne] remove extra spaces from the titles of edited DayOne entries Otherwise, a leading space was being introduced * [DayOne] maintain existing tags stored in DayOne metadata * [DayOne] brings back extended DayOne attributes * [DayOne] maintain metadata on edited entries Fixes #358, See also #159 * [DayOne Exporter] apply black formatting * [JSON Exporter] add support for extended DayOne Metadata * [DayOne] [Tests] test that extended DayOne metadata is added to new entries Co-authored-by: Jrnl Bot <[email protected]>

flight16 referenced this issue Jun 1, 2015

[Dayone] cut extended attributes for now

fd46ffe

minchinweb added a commit to minchinweb/jrnl that referenced this issue Jun 4, 2015

[Dayone] maintain metadata on edited entries;

c9f655e

Fixes jrnl-org#358, See also jrnl-org#159

minchinweb mentioned this issue Sep 25, 2015

Don't drop extra DayOne metadata when editing a DayOne journal #377

Closed

minchinweb added a commit to minchinweb/jrnl that referenced this issue Nov 13, 2017

[Dayone] maintain metadata on edited entries;

5a98089

Fixes jrnl-org#358, See also jrnl-org#159

stale bot added the stale label Jul 7, 2019

minchinweb added the day one Issues related to Day One (dayoneapp.com) label Jul 8, 2019

wren removed the stale label Jul 29, 2019

minchinweb added a commit to minchinweb/jrnl that referenced this issue Aug 2, 2019

[Dayone] maintain metadata on edited entries;

71329a7

Fixes jrnl-org#358, See also jrnl-org#159

stale bot added the stale Inactive issue: will be closed soon if no activity label Sep 27, 2019

stale bot removed the stale Inactive issue: will be closed soon if no activity label Sep 27, 2019

minchinweb mentioned this issue Nov 11, 2019

Dayone fixes (updated for 2.2-dev master) #733

Closed

7 tasks

minchinweb mentioned this issue Nov 14, 2019

[Dayone] re-add tests #742

Merged

7 tasks

stale bot added the stale Inactive issue: will be closed soon if no activity label Jan 13, 2020

stale bot removed the stale Inactive issue: will be closed soon if no activity label Jan 14, 2020

stale bot added the stale Inactive issue: will be closed soon if no activity label Mar 14, 2020

stale bot removed the stale Inactive issue: will be closed soon if no activity label Mar 15, 2020

minchinweb added a commit to minchinweb/jrnl that referenced this issue Apr 27, 2020

[DayOne] maintain metadata on edited entries

19c29dd

Fixes jrnl-org#358, See also jrnl-org#159

minchinweb mentioned this issue Apr 27, 2020

Add extended metadata support for DayOne Classic #928

Merged

7 tasks

stale bot added the stale Inactive issue: will be closed soon if no activity label May 15, 2020

stale bot removed the stale Inactive issue: will be closed soon if no activity label May 16, 2020

micahellison closed this as completed in #928 Jun 6, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

DayOne: Editing existing entries with tags removes the tags when saving #358

DayOne: Editing existing entries with tags removes the tags when saving #358

flight16 commented May 31, 2015

flight16 commented Jun 1, 2015

minchinweb commented Jun 4, 2015

stale bot commented Jul 7, 2019

stale bot commented Sep 27, 2019

minchinweb commented Sep 27, 2019

wren commented Sep 27, 2019

minchinweb commented Oct 2, 2019

minchinweb commented Oct 2, 2019

micahellison commented Oct 6, 2019

minchinweb commented Oct 7, 2019

wren commented Oct 25, 2019

minchinweb commented Oct 28, 2019

wren commented Oct 28, 2019

minchinweb commented Nov 11, 2019

wren commented Nov 13, 2019

minchinweb commented Nov 14, 2019

stale bot commented Jan 13, 2020

minchinweb commented Jan 14, 2020

stale bot commented Mar 14, 2020

minchinweb commented Mar 15, 2020

wren commented Mar 15, 2020

minchinweb commented Mar 16, 2020

wren commented Mar 16, 2020

stale bot commented May 15, 2020

micahellison commented May 16, 2020

DayOne: Editing existing entries with tags removes the tags when saving #358

DayOne: Editing existing entries with tags removes the tags when saving #358

Comments

flight16 commented May 31, 2015

flight16 commented Jun 1, 2015

minchinweb commented Jun 4, 2015

stale bot commented Jul 7, 2019

stale bot commented Sep 27, 2019

minchinweb commented Sep 27, 2019

wren commented Sep 27, 2019

minchinweb commented Oct 2, 2019

minchinweb commented Oct 2, 2019

micahellison commented Oct 6, 2019

minchinweb commented Oct 7, 2019

wren commented Oct 25, 2019

minchinweb commented Oct 28, 2019

wren commented Oct 28, 2019

minchinweb commented Nov 11, 2019

wren commented Nov 13, 2019

minchinweb commented Nov 14, 2019

stale bot commented Jan 13, 2020

minchinweb commented Jan 14, 2020

stale bot commented Mar 14, 2020

minchinweb commented Mar 15, 2020

wren commented Mar 15, 2020

minchinweb commented Mar 16, 2020

wren commented Mar 16, 2020

stale bot commented May 15, 2020

micahellison commented May 16, 2020