[Dayone] remove extra spaces from the titles of edited DayOne entries #350
Conversation
|
Now also maintains existing metadata (location, weather, creator) on Dayone entries across edits. |
|
Manually resolved merge conflict with #355 |
|
Thanks for the leading space fix. I encountered this issue, too. Looking forward to it getting merged back into the 2.0 branch. |
|
Is this PR still relevant? It seems like fixes for Day One before their 2.0 release is outdated, but I honestly don't know if people still use the older Day One client. |
|
@wren I actually use a DayOne Classic compatible client on Windows. (DayOne has never released official client for Windows). |
|
@minchinweb Which client? Are there any similar client for Mac? Do you know if Day One supports their old client anymore? |
|
I'm using Journaley. I don't have a Mac, so I've never gone looking for something similar there. I rather doubt Day One is still supporting their old clients; it seems they haven't updated it to work with Dropbox's new API. This also helps with old entries, written in the original DayOne (iPad/iPhone) client when it was still current. |
Otherwise, a leading space was being introduced
Brings back extended Dayone attributes
Fixes jrnl-org#358, See also jrnl-org#159
When filtering on DayOne tags that contain upper case, no entries are returned. maebert/jrnl#354
minchinweb
force-pushed
the
2.0-dayone-fixes
branch
from
de83d00 to
e188b83
Compare
|
@wren this has been rebased against the current master, add all test are passing. It should be ready to be merged! These are all bug fixes, so I'd love it if it made the 2.0 cutoff. |
|
We may need to review what we're doing with line endings. This is one of the raw strings that was being testing against:
(notice the total mis-match of line endings.) Some of it, I'm sure, is due to Windows, and some due to Git, but it was making for tests that passed on Travis, but failed locally. |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
I'm going to close this for a bit, while we wait for the day one-related tests to come back. |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Otherwise, a leading space was being introduced