GitHub Pull Request Template Update #927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # .github/PULL_REQUEST_TEMPLATE.md
pyflakes here is given only certain subdirectories because `.` will try and run across all packages installed in the virtual environment, if the virtual environment is within the project's root folder (which is my common practice).
wren
approved these changes
May 2, 2020
|
@minchinweb Thanks for this. Out of curiosity, do you have |
|
No, I don't have invoke might be a good pure-Python alternative that I've used in the past that might do what you want. |
|
That's great; I was actually hoping you didn't have it. Would you mind going through the contributing doc and getting set up? I'd love your notes on whether there's enough info there or not for the Windows setup. |
|
Forgot to @minchinweb for the above comment. |
wren
pushed a commit
that referenced
this pull request
Jul 25, 2020
* Improve GitHub PR Template * suggest running commands with `poetry run ...` pyflakes here is given only certain subdirectories because `.` will try and run across all packages installed in the virtual environment, if the virtual environment is within the project's root folder (which is my common practice).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Further to #911, this aims to improve the Pull Request template, by including a reminder of the commands to run locally for test, lints, etc.
Checklist